1355277 - change h2 origin extension frame type to 0xc

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement)

Description

[Patrick McManus [:mcmanus]]

While testing firefox's implementation of this draft Vlad determined that some versions of Chrome throw PROTOCOL_ERROR and close the connection if it receives a type 0xB frame with a non zero length on stream 0.

Other frame type numbers, such as 0xC do not seem to have that problem.

testing indicates this is fixed in version 59 and is a problem previous to that. (57 is in release as I write this).

presumably this is related to historical code around BLOCKED which was proposed to use 0xB.

Prudence says to just use a different code point for the moment.

we discussed this in the f2f in ORD so it shouldnt be a problem
https://github.com/httpwg/http-extensions/pull/323

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: Bug 1355277 - change h2 origin frame codepoint to 0xc

Review commit: https://reviewboard.mozilla.org/r/128702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128702/

Comment 2

[u408661]

Comment on attachment 8856776 [details]
Bug 1355277 - change h2 origin frame codepoint to 0xc

https://reviewboard.mozilla.org/r/128702/#review131476

::: netwerk/protocol/http/Http2Session.cpp:229
(Diff revision 1)
>    Http2Session::RecvPing,
>    Http2Session::RecvGoAway,
>    Http2Session::RecvWindowUpdate,
>    Http2Session::RecvContinuation,
>    Http2Session::RecvAltSvc, // extension for type 0x0A
> -  Http2Session::RecvOrigin  // extension for type 0x0B
> +  Http2Session::RecvUnused, // 0x0B ignore for now

nit: Note that this used to be BLOCKED, but that's gone now?

::: testing/xpcshell/node-http2/lib/protocol/framer.js:1072
(Diff revision 1)
>      }
>      // Otherwise, we just ignore this
>    }
>  };
>  
> -frameTypes[0xB] = 'ORIGIN';
> +// frame 0xB was BLOCKED and some versions of chrome will

This is fine for here, but I'll probably need to do some work in the main repo to make this not choke in real-world situations. This is more a note to myself than anything for you to do here.

Comment 3

[Patrick McManus [:mcmanus]]

Comment on attachment 8856776 [details]
Bug 1355277 - change h2 origin frame codepoint to 0xc

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128702/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f7d40d274fb
change h2 origin frame codepoint to 0xc r=nwgh

Comment 5

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/0f7d40d274fb