change h2 origin extension frame type to 0xc

RESOLVED FIXED in Firefox 55

Status

()

Core
Networking: HTTP
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: mcmanus, Unassigned)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [necko-active][spdy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
While testing firefox's implementation of this draft Vlad determined that some versions of Chrome throw PROTOCOL_ERROR and close the connection if it receives a type 0xB frame with a non zero length on stream 0.

Other frame type numbers, such as 0xC do not seem to have that problem.

testing indicates this is fixed in version 59 and is a problem previous to that. (57 is in release as I write this).

presumably this is related to historical code around BLOCKED which was proposed to use 0xB.

Prudence says to just use a different code point for the moment.

we discussed this in the f2f in ORD so it shouldnt be a problem
https://github.com/httpwg/http-extensions/pull/323
(Reporter)

Updated

8 months ago
Blocks: 1337791
Whiteboard: [necko-active][spdy]
Comment hidden (mozreview-request)
Comment on attachment 8856776 [details]
Bug 1355277 - change h2 origin frame codepoint to 0xc

https://reviewboard.mozilla.org/r/128702/#review131476

::: netwerk/protocol/http/Http2Session.cpp:229
(Diff revision 1)
>    Http2Session::RecvPing,
>    Http2Session::RecvGoAway,
>    Http2Session::RecvWindowUpdate,
>    Http2Session::RecvContinuation,
>    Http2Session::RecvAltSvc, // extension for type 0x0A
> -  Http2Session::RecvOrigin  // extension for type 0x0B
> +  Http2Session::RecvUnused, // 0x0B ignore for now

nit: Note that this used to be BLOCKED, but that's gone now?

::: testing/xpcshell/node-http2/lib/protocol/framer.js:1072
(Diff revision 1)
>      }
>      // Otherwise, we just ignore this
>    }
>  };
>  
> -frameTypes[0xB] = 'ORIGIN';
> +// frame 0xB was BLOCKED and some versions of chrome will

This is fine for here, but I'll probably need to do some work in the main repo to make this not choke in real-world situations. This is more a note to myself than anything for you to do here.
Attachment #8856776 - Flags: review?(hurley) → review+
Comment hidden (mozreview-request)

Comment 4

8 months ago
Pushed by mcmanus@ducksong.com:
https://hg.mozilla.org/integration/autoland/rev/0f7d40d274fb
change h2 origin frame codepoint to 0xc r=nwgh

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0f7d40d274fb
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.