1355349 - stylo: Additive SMIL animations

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Comment 1

[Brian Birtles (:birtles)]

Attachment: WIP patch for defining zero values

The idea here is we'll expose an FFI where we pass in a RawServoComputedValue and you'll get back a computed value for the same property with a suitable zero value, or None. Then we'll use this to implement the Stylo equivalent of GetZeroValueForUnit (but without the unit).

Just dropping this patch here for a while since it's not very useful until we implement additive animation (bug 1329878).

Comment 2

[Brian Birtles (:birtles)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7caf6db9ed84ebd0529e184ae13ec19f2714d21

Comment 3

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Get unanimated style in nsComputedDOMStyle::DoGetStyleContextNoFlush for Servo too;

Review commit: https://reviewboard.mozilla.org/r/143098/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143098/

Comment 4

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Add get_zero_value to Animatable trait;

Review commit: https://reviewboard.mozilla.org/r/143100/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143100/

Comment 5

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Use Servo's zero values to fill in missing SMIL animation endpoints;

Review commit: https://reviewboard.mozilla.org/r/143102/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143102/

Comment 6

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Add FFI for calling Servo's add and accumulate methods on animation values;

Review commit: https://reviewboard.mozilla.org/r/143104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143104/

Comment 7

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Drop 'virtual' annotation from overridden methods in nsSMILCSSValueType.h

Our coding style says we should only use one of either 'virtual' or 'override'.
In the next patch I would like to add another override to this header so first
we should tidy up the existing declarations.

Review commit: https://reviewboard.mozilla.org/r/143106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143106/

Comment 8

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Call Servo's add and accumulate methods for SMIL animations;

Review commit: https://reviewboard.mozilla.org/r/143108/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143108/

Comment 9

[Brian Birtles (:birtles)]

I didn't quite get this to review before going away but I'm putting the patches up now in case anyone else wants to build on top of these while I'm away. This should mostly work I think (I've tested locally with a simple by-animation and it seems to do the right thing). I'm still waiting to see what try brings back however.

For my own notes when I get back:

* I need to go over the first base styles patch. I'm not entirely confident it's right.
* There are probably (hopefully) some test expectations that need to be updated.
* Other than that, it's probably mostly a matter of seeing what tests fail to pass that should pass (e.g. see the XXX comment in the "Use Servo's initial values to fill in missing SMIL animation endpoints" about whether we need to do some kind of 0 value fixup).

Comment 10

[Brian Birtles (:birtles)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbb943d817f2c670747e8f375c39aabf1e7d6337

Comment 11

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Move calculation of pseudo type in nsComputedDOMStyle::DoGetStyleContextNoFlush;

This patch just moves the calculation of the pseudo type earlier in the method
so we can re-use it in the next patch in this series to get the style context
from the Servo backend for the case where we don't need to resolve style.

This patch also renames the local variable from 'type' to 'pseudoType' since
that seems less ambiguous.

Review commit: https://reviewboard.mozilla.org/r/145134/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145134/

Comment 12

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Don't introduce calc() when interpolating between length and percentages if either side is zero;

Without this patch anim-css-strokewidth-1-by-pct-pct.svg (and possibly others)
fails because we calculate the result as 'calc(0px + 10%)' and we don't support
calc on stroke-width (yet, see bug 1258270) so the rendered result is incorrect.

As a more thorough fix, we should make the zero-value for
LengthOrPercentageOrNumber a zero *number* (instead of a zero length) but that
won't work yet due to bug 1369614. Regardless of that bug, we still shouldn't
introduce calc in order to add a zero value using the LengthOrPercentage type,
so this change is still needed.

Review commit: https://reviewboard.mozilla.org/r/145136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145136/

Comment 13

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Treat properties that can't be animated by the Servo backend as unanimatable;

If we attempt to call animation-related methods on the Servo backend (e.g.
Servo_ComputedValues_ExtractAnimationValue) and pass a property that is not
(yet) animatable by Servo, it will panic so we should avoid passing these
properties.

An alternative, is to make methods like
Servo_ComputedValues_ExtractAnimationValue fallible by having them first check
if the passed-in value is animatable and return null in that case. That too, is
probably worth doing (call sites like KeyframeEffectReadOnly::EnsureBaseStyle
that assume it is fallible could assert that the result is non-null since,
provided that property is animatable, the method should still be fallible) but
refusing to animate these properties from the start is cleaner so we just do
that for now.

Review commit: https://reviewboard.mozilla.org/r/145138/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145138/

Comment 14

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Drop 'virtual' annotation from overridden methods in nsSMILCSSValueType.h;

Our coding style says we should only use one of either 'virtual' or 'override'.
In the next patch I would like to add another override to this header so first
we should tidy up the existing declarations.

Review commit: https://reviewboard.mozilla.org/r/145140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145140/

Comment 15

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Reformat a ternary operator to match coding style;

Review commit: https://reviewboard.mozilla.org/r/145142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145142/

Comment 16

[Brian Birtles (:birtles)]

Attachment: Bug 1355349 - Update stylo test expectations;

Review commit: https://reviewboard.mozilla.org/r/145144/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145144/

Comment 17

[Brian Birtles (:birtles)]

Comment on attachment 8871616 [details]
Bug 1355349 - Get unanimated style in nsComputedDOMStyle::DoGetStyleContextNoFlush for Servo too;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143098/diff/1-2/

Comment 18

[Brian Birtles (:birtles)]

Comment on attachment 8871617 [details]
Bug 1355349 - Add get_zero_value to Animatable trait;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143100/diff/1-2/

Comment 19

[Brian Birtles (:birtles)]

Comment on attachment 8871618 [details]
Bug 1355349 - Use Servo's zero values to fill in missing SMIL animation endpoints;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143102/diff/1-2/

Comment 20

[Brian Birtles (:birtles)]

Comment on attachment 8871619 [details]
Bug 1355349 - Add FFI for calling Servo's add and accumulate methods on animation values;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143104/diff/1-2/

Comment 21

[Brian Birtles (:birtles)]

Comment on attachment 8871621 [details]
Bug 1355349 - Call Servo's add and accumulate methods for SMIL animations;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143108/diff/1-2/

Comment 22

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8873734 [details]
Bug 1355349 - Move calculation of pseudo type in nsComputedDOMStyle::DoGetStyleContextNoFlush;

https://reviewboard.mozilla.org/r/145134/#review149092

Comment 23

[Brian Birtles (:birtles)]

The "Get unanimated style in nsComputedDOMStyle::DoGetStyleContextNoFlush for Servo too" patch is probably wrong.

Running the tests in dom/smil/tests I hit this failed assertion:

11182 INFO TEST-PASS | dom/smil/test/test_smilXHR.xhtml | animation of attribute shouldn't be taking effect
GECKO(11964) | [Parent 11964] WARNING: stylo: No docshell yet, assuming Gecko style system: file c:/moz/src2/dom/base/nsDocument.cpp, line 13174
GECKO(11964) | Assertion failure: IsStyledByServo(), at c:\moz\src2\obj-stylo-debug-opt\dist\include\mozilla/dom/Element.h:466
GECKO(11964) | #01: mozilla::ServoStyleSet::ResolveStyleLazily (c:\moz\src2\layout\style\servostyleset.cpp:1128)
GECKO(11964) | #02: mozilla::ServoStyleSet::ResolveTransientServoStyle (c:\moz\src2\layout\style\servostyleset.cpp:548)
GECKO(11964) | #03: mozilla::ServoStyleSet::ResolveTransientStyle (c:\moz\src2\layout\style\servostyleset.cpp:532)
GECKO(11964) | #04: nsComputedDOMStyle::DoGetStyleContextNoFlush (c:\moz\src2\layout\style\nscomputeddomstyle.cpp:671)
GECKO(11964) | #05: nsComputedDOMStyle::GetStyleContext (c:\moz\src2\layout\style\nscomputeddomstyle.cpp:425)
GECKO(11964) | #06: nsComputedDOMStyle::UpdateCurrentStyleSources (c:\moz\src2\layout\style\nscomputeddomstyle.cpp:897)
GECKO(11964) | #07: nsComputedDOMStyle::GetPropertyCSSValue (c:\moz\src2\layout\style\nscomputeddomstyle.cpp:1000)
GECKO(11964) | #08: nsComputedDOMStyle::GetPropertyValue (c:\moz\src2\layout\style\nscomputeddomstyle.cpp:380)
GECKO(11964) | #09: mozilla::dom::CSSStyleDeclarationBinding::getPropertyValue (c:\moz\src2\obj-stylo-debug-opt\dom\bindings\cssstyledeclarationbinding.cpp:165)
GECKO(11964) | #10: mozilla::dom::GenericBindingMethod (c:\moz\src2\dom\bindings\bindingutils.cpp:2954)
GECKO(11964) | #11: js::CallJSNative (c:\moz\src2\js\src\jscntxtinlines.h:293)
GECKO(11964) | #12: js::InternalCallOrConstruct (c:\moz\src2\js\src\vm\interpreter.cpp:470)
GECKO(11964) | #13: Interpret (c:\moz\src2\js\src\vm\interpreter.cpp:3028)

Comment 24

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8871617 [details]
Bug 1355349 - Add get_zero_value to Animatable trait;

https://reviewboard.mozilla.org/r/143100/#review149096

Comment 25

[Brian Birtles (:birtles)]

Comment on attachment 8871617 [details]
Bug 1355349 - Add get_zero_value to Animatable trait;

https://reviewboard.mozilla.org/r/143100/#review149102

::: servo/components/style/properties/helpers/animated_properties.mako.rs:1445
(Diff revision 2)
>              FontWeight::Weight900
>          })
>      }
>  
>      #[inline]
> +    fn get_zero_value(&self) -> Option<Self> { Some(FontWeight::Weight400) }

We should either change this to zero (except there is no zero value :( ) or we should make add_weighted add a difference from 400.

Comment 26

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8873735 [details]
Bug 1355349 - Don't introduce calc() when interpolating between length and percentages if either side is zero;

https://reviewboard.mozilla.org/r/145136/#review149104

Comment 27

[Brian Birtles (:birtles)]

(In reply to Brian Birtles (:birtles) from comment #23)
> GECKO(11964) | Assertion failure: IsStyledByServo(), at
> c:\moz\src2\obj-stylo-debug-opt\dist\include\mozilla/dom/Element.h:466
> GECKO(11964) | #01: mozilla::ServoStyleSet::ResolveStyleLazily
> (c:\moz\src2\layout\style\servostyleset.cpp:1128)

This is bizarre. Even in my local copy ResolveStyleLazily doesn't call IsStyledByServo as far as I can tell.

Something to investigate on Monday.

Comment 28

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8871618 [details]
Bug 1355349 - Use Servo's zero values to fill in missing SMIL animation endpoints;

https://reviewboard.mozilla.org/r/143102/#review149106

::: dom/smil/nsSMILCSSValueType.cpp:110
(Diff revision 2)
> -    if (!aValue1 || !aValue2) {
> -      NS_WARNING("stylo: Missing values are not yet supported (bug 1355349)");
> -      return false;
> +      aZeroValueStorage.mServo =
> +        Servo_AnimationValues_GetZeroValue(aValue2->mServo).Consume();
> +      aValue1 = &aZeroValueStorage;

This looks funny but I don't have other ways.  Honestely I am really looking forward to the day we drop the wrapper, AnimationValue.

Comment 29

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8871619 [details]
Bug 1355349 - Add FFI for calling Servo's add and accumulate methods on animation values;

https://reviewboard.mozilla.org/r/143104/#review149108

Comment 30

[Brian Birtles (:birtles)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #28)
> Comment on attachment 8871618 [details]
> Bug 1355349 - Use Servo's zero values to fill in missing SMIL animation
> endpoints;
> 
> https://reviewboard.mozilla.org/r/143102/#review149106
> 
> ::: dom/smil/nsSMILCSSValueType.cpp:110
> (Diff revision 2)
> > -    if (!aValue1 || !aValue2) {
> > -      NS_WARNING("stylo: Missing values are not yet supported (bug 1355349)");
> > -      return false;
> > +      aZeroValueStorage.mServo =
> > +        Servo_AnimationValues_GetZeroValue(aValue2->mServo).Consume();
> > +      aValue1 = &aZeroValueStorage;
> 
> This looks funny but I don't have other ways.  Honestely I am really looking
> forward to the day we drop the wrapper, AnimationValue.

Yeah, I thought of a few other ways but they all introduced extra copying. It's weird because in the Gecko codepath we can use statically initialized objects but in Servo we can't.

Comment 31

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8873736 [details]
Bug 1355349 - Treat properties that can't be animated by the Servo backend as unanimatable;

https://reviewboard.mozilla.org/r/145138/#review149110

Comment 32

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8873737 [details]
Bug 1355349 - Drop 'virtual' annotation from overridden methods in nsSMILCSSValueType.h;

https://reviewboard.mozilla.org/r/145140/#review149112

Comment 33

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8873738 [details]
Bug 1355349 - Reformat a ternary operator to match coding style;

https://reviewboard.mozilla.org/r/145142/#review149114

Comment 34

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8871621 [details]
Bug 1355349 - Call Servo's add and accumulate methods for SMIL animations;

https://reviewboard.mozilla.org/r/143108/#review149120

Comment 35

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8873739 [details]
Bug 1355349 - Update stylo test expectations;

https://reviewboard.mozilla.org/r/145144/#review149122

Comment 36

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8871616 [details]
Bug 1355349 - Get unanimated style in nsComputedDOMStyle::DoGetStyleContextNoFlush for Servo too;

https://reviewboard.mozilla.org/r/143098/#review149124

I think this basically works, but sometimes returns stale base style I guess. I don't actually remember when SMIL calls this code, if it's called in PreTraversal(), there might be some cases that we have stale styles.  Maybe, a subsequent tick right after we set inline style?

Even if there is a case we have stale styles, I am OK with fixing the case when we move SMIL on the web animation architecture.

Comment 37

[Brian Birtles (:birtles)]

(In reply to Brian Birtles (:birtles) from comment #23)
> The "Get unanimated style in nsComputedDOMStyle::DoGetStyleContextNoFlush
> for Servo too" patch is probably wrong.
> 
> Running the tests in dom/smil/tests I hit this failed assertion:
> 
> 11182 INFO TEST-PASS | dom/smil/test/test_smilXHR.xhtml | animation of
> attribute shouldn't be taking effect
> GECKO(11964) | [Parent 11964] WARNING: stylo: No docshell yet, assuming
> Gecko style system: file c:/moz/src2/dom/base/nsDocument.cpp, line 13174
> GECKO(11964) | Assertion failure: IsStyledByServo(), at
> c:\moz\src2\obj-stylo-debug-opt\dist\include\mozilla/dom/Element.h:466
> GECKO(11964) | #01: mozilla::ServoStyleSet::ResolveStyleLazily
> (c:\moz\src2\layout\style\servostyleset.cpp:1128)
> GECKO(11964) | #02: mozilla::ServoStyleSet::ResolveTransientServoStyle
> (c:\moz\src2\layout\style\servostyleset.cpp:548)
> GECKO(11964) | #03: mozilla::ServoStyleSet::ResolveTransientStyle
> (c:\moz\src2\layout\style\servostyleset.cpp:532)
> GECKO(11964) | #04: nsComputedDOMStyle::DoGetStyleContextNoFlush
> (c:\moz\src2\layout\style\nscomputeddomstyle.cpp:671)
> GECKO(11964) | #05: nsComputedDOMStyle::GetStyleContext
> (c:\moz\src2\layout\style\nscomputeddomstyle.cpp:425)
> GECKO(11964) | #06: nsComputedDOMStyle::UpdateCurrentStyleSources
> (c:\moz\src2\layout\style\nscomputeddomstyle.cpp:897)
> GECKO(11964) | #07: nsComputedDOMStyle::GetPropertyCSSValue
> (c:\moz\src2\layout\style\nscomputeddomstyle.cpp:1000)
> GECKO(11964) | #08: nsComputedDOMStyle::GetPropertyValue
> (c:\moz\src2\layout\style\nscomputeddomstyle.cpp:380)
> GECKO(11964) | #09:
> mozilla::dom::CSSStyleDeclarationBinding::getPropertyValue
> (c:\moz\src2\obj-stylo-debug-opt\dom\bindings\cssstyledeclarationbinding.cpp:
> 165)
> GECKO(11964) | #10: mozilla::dom::GenericBindingMethod
> (c:\moz\src2\dom\bindings\bindingutils.cpp:2954)
> GECKO(11964) | #11: js::CallJSNative
> (c:\moz\src2\js\src\jscntxtinlines.h:293)
> GECKO(11964) | #12: js::InternalCallOrConstruct
> (c:\moz\src2\js\src\vm\interpreter.cpp:470)
> GECKO(11964) | #13: Interpret (c:\moz\src2\js\src\vm\interpreter.cpp:3028)

It looks like this might not be related to this patch series after all. This is happening in test_smilXHR.html where we first do:

  var xhr = new XMLHttpRequest();
  xhr.open("GET", "smilXHR_helper.svg", false);
  xhr.send();
  var xdoc = xhr.responseXML

Then we pull out a circle element from the document:

  var circ = xdoc.getElementById("circ")

Then at the end we check the computed style of the circle:

  is(SMILUtil.getComputedStyleSimple(circ, "opacity"), "1",
     "animation of CSS property shouldn't be taking effect");

The trouble is, in nsComputedDOMStyle::DoGetStyleContextNoFlush we have the following check:

  if (ServoStyleSet* servoSet = styleSet->GetAsServo()) {
    StyleRuleInclusion rules = aStyleType == eDefaultOnly
                               ? StyleRuleInclusion::DefaultOnly
                               : StyleRuleInclusion::All;
    return servoSet->ResolveTransientStyle(aElement, aPseudo, type, rules);
  }

For whatever reason, styleSet->GetAsServo() returns a ServoStyleSet here (I haven't dug into exactly how we look up the styleSet there) so we go ahead and call ResolveTransientStyle.

From there we have the following call stack:

  ServoStyleSet::ResolveTransientStyle
  ServoStyleSet::ResolveTransientServoStyle
  ServoStyleSet::ResolveStyleLazily
  EffectCompositor::PreTraverse

In EffectCompositor::PreTraverse we have:

  bool flushThrottledRestyles = elementToRestyle &&
                                elementToRestyle->HasDirtyDescendantsForServo();

|elementToRestyle| here is the <circle> element but HasDirtyDescendantsForServo contains the assertion:

  MOZ_ASSERT(IsStyledByServo());

which calls:

  nsINode::IsStyledByServo() const
  {
    return OwnerDoc()->IsStyledByServo();
  }

and the OwnerDoc() here is the XHR doc, which is not styled by servo so the assertion fails.

So there's some kind of mismatch between consulting the element's owner doc to see if we're using Servo, and whatever we end up doing to get the style set for the element in DoGetStyleContextNoFlush.

I'm currently building without the patches in this bug to confirm that the assertion still fails without them. If it does, I'll file a separate bug for this issue.

Comment 38

[Brian Birtles (:birtles)]

(In reply to Brian Birtles (:birtles) from comment #37)
> I'm currently building without the patches in this bug to confirm that the
> assertion still fails without them. If it does, I'll file a separate bug for
> this issue.

Confirmed this test fails on a fresh checkout of m-c and filed bug 1370123 for fixing it.

Comment 39

[Brian Birtles (:birtles)]

Comment on attachment 8873734 [details]
Bug 1355349 - Move calculation of pseudo type in nsComputedDOMStyle::DoGetStyleContextNoFlush;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145134/diff/1-2/

Comment 40

[Brian Birtles (:birtles)]

Comment on attachment 8871616 [details]
Bug 1355349 - Get unanimated style in nsComputedDOMStyle::DoGetStyleContextNoFlush for Servo too;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143098/diff/2-3/

Comment 41

[Brian Birtles (:birtles)]

Comment on attachment 8871618 [details]
Bug 1355349 - Use Servo's zero values to fill in missing SMIL animation endpoints;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143102/diff/2-3/

Comment 42

[Brian Birtles (:birtles)]

Comment on attachment 8871619 [details]
Bug 1355349 - Add FFI for calling Servo's add and accumulate methods on animation values;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143104/diff/2-3/

Comment 43

[Brian Birtles (:birtles)]

Comment on attachment 8873736 [details]
Bug 1355349 - Treat properties that can't be animated by the Servo backend as unanimatable;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145138/diff/1-2/

Comment 44

[Brian Birtles (:birtles)]

Comment on attachment 8873737 [details]
Bug 1355349 - Drop 'virtual' annotation from overridden methods in nsSMILCSSValueType.h;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145140/diff/1-2/

Comment 45

[Brian Birtles (:birtles)]

Comment on attachment 8873738 [details]
Bug 1355349 - Reformat a ternary operator to match coding style;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145142/diff/1-2/

Comment 46

[Brian Birtles (:birtles)]

Comment on attachment 8871621 [details]
Bug 1355349 - Call Servo's add and accumulate methods for SMIL animations;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143108/diff/2-3/

Comment 47

[Brian Birtles (:birtles)]

Comment on attachment 8873739 [details]
Bug 1355349 - Update stylo test expectations;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145144/diff/1-2/

Comment 48

[Brian Birtles (:birtles)]

Attachment: Servo PR #17162

Comment 49

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38ae6e3d3a11
Move calculation of pseudo type in nsComputedDOMStyle::DoGetStyleContextNoFlush; r=hiro
https://hg.mozilla.org/integration/autoland/rev/862c08dd715b
Get unanimated style in nsComputedDOMStyle::DoGetStyleContextNoFlush for Servo too; r=hiro
https://hg.mozilla.org/integration/autoland/rev/47db7107c874
Use Servo's zero values to fill in missing SMIL animation endpoints; r=hiro
https://hg.mozilla.org/integration/autoland/rev/ef01cc3b84b8
Add FFI for calling Servo's add and accumulate methods on animation values; r=hiro
https://hg.mozilla.org/integration/autoland/rev/992504b822d2
Treat properties that can't be animated by the Servo backend as unanimatable; r=hiro
https://hg.mozilla.org/integration/autoland/rev/297d24c38ab3
Drop 'virtual' annotation from overridden methods in nsSMILCSSValueType.h; r=hiro
https://hg.mozilla.org/integration/autoland/rev/c0ef218a7f9e
Reformat a ternary operator to match coding style; r=hiro
https://hg.mozilla.org/integration/autoland/rev/2f7ad629f8b0
Call Servo's add and accumulate methods for SMIL animations; r=hiro
https://hg.mozilla.org/integration/autoland/rev/a3c3e847db4a
Update stylo test expectations; r=hiro

Comment 50

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/38ae6e3d3a11
https://hg.mozilla.org/mozilla-central/rev/862c08dd715b
https://hg.mozilla.org/mozilla-central/rev/47db7107c874
https://hg.mozilla.org/mozilla-central/rev/ef01cc3b84b8
https://hg.mozilla.org/mozilla-central/rev/992504b822d2
https://hg.mozilla.org/mozilla-central/rev/297d24c38ab3
https://hg.mozilla.org/mozilla-central/rev/c0ef218a7f9e
https://hg.mozilla.org/mozilla-central/rev/2f7ad629f8b0
https://hg.mozilla.org/mozilla-central/rev/a3c3e847db4a