Closed
Bug 1355578
Opened 8 years ago
Closed 8 years ago
Fix const* / Option mismatch in push_scroll_layer FFI signature
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(1 file)
It takes a const* for the mask on the C++ side, and an Option on the Rust side. While this is probably ok, it's not friendly to the binding generator. The rust side should take a *const as well, and we can use as_ref() to trivially convert it into an Option.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•8 years ago
|
||
Try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc43eb2c2bf394de8d8f6d896fb3bce71988579c includes this patch
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8857148 [details]
Bug 1355578 - Update push_scroll_layer's signature on the Rust die to match that on the C++ side.
https://reviewboard.mozilla.org/r/129088/#review131580
::: commit-message-3fcbe:1
(Diff revision 1)
> +Bug 1355578 - Update push_scroll_layer's signature on the Rust die to match that on the C++ side. r?jrmuizel
s/die/side/
Attachment #8857148 -
Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/0eff4453972d
Update push_scroll_layer's signature on the Rust side to match that on the C++ side. r=jrmuizel
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•8 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•8 years ago
|
status-firefox55:
--- → fixed
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•