1355596 - Disable Find Toolbar feature on Nightly

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, enhancement)

Description

[Marcia Knous [:marcia]]

Per email thread, we are recommending that this feature be disabled on Nightly (AFAIK it is currently on by default). As discussed, this feature has been in "red" signoff condition from QA and has been tracked as part of the merge criteria process since Nightly was in 52 - see https://docs.google.com/spreadsheets/d/1iOwNebxOTx07WhRYc5S5mKIKHJZ_imocMQF5HksMJsw/edit#gid=738646444 for tracking information.

Comment 1

[Marcia Knous [:marcia]]

ni on Mike to see about disabling this feature prior to the merge.

Comment 2

[Mike de Boer [:mikedeboer]]

This is enabled on Nightly _only_ and guarded to be that way by a build-time flag. This bug is about making Nightly use the older highlighting method.
I think that's a nice experiment to see if people will actually miss the modal highlighting mode at all, once it's disabled.

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1355596 - disable the modal highlighting feature on Nightly, until more progress is made on the bugs that are blocking this feature.

Review commit: https://reviewboard.mozilla.org/r/131518/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131518/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8859515 [details]
Bug 1355596 - disable the modal highlighting feature on Nightly, until more progress is made on the bugs that are blocking this feature.

https://reviewboard.mozilla.org/r/131518/#review134330

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb0bff3a629d
disable the modal highlighting feature on Nightly, until more progress is made on the bugs that are blocking this feature. r=jaws

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cb0bff3a629d

Comment 7

[Asif Youssuff]

FWIW, a new user calls the current default "garbage" and specifically references Chrome's behavior.

https://www.reddit.com/r/firefox/comments/7q1zzg/my_feedback_on_firefox/?st=jccyy2sh&sh=89711807 

Someone recommends enabling this preference: https://www.reddit.com/r/firefox/comments/7q1zzg/my_feedback_on_firefox/dslurqu/

Comment 8

[Mike de Boer [:mikedeboer]]

I <3 the feedback in that thread, but there are a few more things that we need to fix in order to switch it back being the default behavior; you can follow bug 1291278 to get notified when it happens!