135567 - menu accesskeys needed for closing tabs and window in multitab cases

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[sairuh (rarely reading bugmail)]

when i have more than one tab browser open, the File > Close Window doesn't have
an accesskey. when i discussed this with Jen, she recommended the following:

Close _T_ab --- Ctrl+W
_C_lose Window --- Ctrl+Shift+W

she now has this in her spec.

Comment 1

[sairuh (rarely reading bugmail)]

over to steve

Comment 2

[Peter Trudelle]

nsbeta1- per Nav triage team, ->1.2

Comment 3

[Jesse Ruderman]

Close Tab should be C for consistency with the file menu in the single-tab case.
 T should be reserved for New Navigator Tab (bug 135804) for consistency with
the link context menu.

Comment 4

[Stephen P. Morse]

reassigning to component owner

Comment 5

[sairuh (rarely reading bugmail)]

nominating.

Comment 6

[Aaron Leventhal]

-> jesse 

Comment 7

[Jessie Li]

sairuh,
_C_lose Window --- Ctrl+Shift+W is a way to implement.
Do you want to use Alt+one character to implement this?

Comment 8

[sairuh (rarely reading bugmail)]

it would be (barring web page access key conflicts ;)

Alt-F, which drops down the File menu, followed by hitting the 'c' key by itself
(or the 't' key) to close the window (or tab, respectively).

Comment 9

[piers]

Ok, how about:

_C_lose Tab (which is already there)
Close _W_indow

(Since Ctrl+W is the same for Close and Close Tab, the accesskey should be the
same also)

Comment 10

[sairuh (rarely reading bugmail)]

hm, unfortunately the W conflicts with the access key for _W_ork Offline. how
about the suggestion in comment 0? i don't see conflicts there.

Comment 11

[piers]

Good point, i must be blind :)

The reason against changing Close Tab to use a different letter is that it should
have the same letter as the Close item when no other tabs are open - in the same 
way that the keyboard shortcut is Ctrl+W in both instances. Only other option is
to use "i" for Close Window (its the only other free accesskey).

Comment 12

[sairuh (rarely reading bugmail)]

ah, good point. i wouldn't mind using "i".

jglick / aaronl, what do you think?

Comment 13

[Aaron Leventhal]

In general we should avoid using l or i unless there is no other choice, because
they are very thin, so it is hard to see the underline.

The is something I learned by reading Microsoft's guidelines for choosing
accesskeys. I folded all of their accesskey wisdom and ours into a XUL accesskey
FAQ, which is here: http://www.mozilla.org/projects/ui/accessibility/accesskey.html

Comment 14

[piers]

Aaron, do you reckon it better to leave the Close Tab accesskey as it is and use 
i for Close Window (see comment 11), or do you think its better to change it?

Comment 15

[Aaron Leventhal]

How about 
Close Ta_b_
_C_lose Window

This avoids using i for an accesskey, which is very hard to see the underline
on, and stays in line with our general accesskey principles.

Comment 16

[piers]

Aaron, ok, if you're up for changing the accesskey of Close Tab, what's wrong with
the suggestion in comment 0?

Comment 17

[Aaron Leventhal]

Sorry, I didn't read  the whole bug before. I guess what Jesse says in comme 3
makes sense.

Jesse, do you have a suggestion?

Comment 18

[sairuh (rarely reading bugmail)]

there's some talk of adding Close Other Tab to the File menu --see bug 103354
and 191818 (and maybe others, sigh).

Comment 19

[Samir Gehani]

adt: nsbeta1-

Comment 20

[(no longer active)]

Moving to Firefox.

I think "d" can be used as the access key for the Close Window item.  It's free, and it doesn't have the problem mentioned in comment 13.

I'll be posting a patch to do that shortly.

Comment 21

[(no longer active)]

Removing the helpwanted keyword.

Comment 22

[(no longer active)]

Attachment: [checked in] Firefox: Use "d" as the access key for the Close Window menu item

Set the accesskey for the Close Window menu item to "d".

Comment 23

[Asaf Romano (gone)]

Comment on attachment 271095 [details] [diff] [review]
[checked in] Firefox: Use "d" as the access key for the Close Window menu item

r=mano

Comment 24

[Phil Ringnalda (:philor)]

Comment on attachment 271095 [details] [diff] [review]
[checked in] Firefox: Use "d" as the access key for the Close Window menu item

browser/base/content/browser-menubar.inc 1.115
browser/locales/en-US/chrome/browser/browser.dtd 1.62

Leaving open for the SeaMonkey fix you volunteered to do, by stealing this bug instead of filing a new Firefox one ;)

Comment 25

[(no longer active)]

Attachment: Seamonkey: Correct File menu items access keys

This fix changes the "Send Link" access key from d to k, and then assigns the following access keys:

 * Close Other Tabs -> T
 * Close Window     -> d

Comment 26

[jag (Peter Annema)]

Comment on attachment 271487 [details] [diff] [review]
Seamonkey: Correct File menu items access keys

I would suggest leaving 'd' for "Send Link", and using 'i' for "Close Window". Less change that way for people who are used to alt+f d.

'T' for "Close Other Tabs" is fine, though I would pick 't' to associate with "Other", not "Tabs".

Neil, your thoughts?

Comment 27

[(no longer active)]

(In reply to comment #26)
> (From update of attachment 271487 [details] [diff] [review])
> I would suggest leaving 'd' for "Send Link", and using 'i' for "Close Window".
> Less change that way for people who are used to alt+f d.

Hmmm, but i is a narrow character, and once it's underlined, it may not be visible at first site.  See comment 13.

> 'T' for "Close Other Tabs" is fine, though I would pick 't' to associate with
> "Other", not "Tabs".

How come?

Comment 28

[[e-mail]]

(In reply to comment #27)
>(In reply to comment #26)
>>I would suggest leaving 'd' for "Send Link", and using 'i' for "Close Window".
>>Less change that way for people who are used to alt+f d.
>Hmmm, but i is a narrow character, and once it's underlined, it may not be
>visible at first site.  See comment 13.
For some reason Mail uses l for Offline and that's barely noticable.

(In reply to comment #26)
>I would suggest leaving 'd' for "Send Link", and using 'i' for "Close Window".
>Less change that way for people who are used to alt+f d.
Maybe change "Work Offline" to k? Fewer people would use that, I guess.

>'T' for "Close Other Tabs" is fine, though I would pick 't' to associate with
>"Other", not "Tabs".
No, you should always prefer to use capitals where possible.

Comment 29

[(no longer active)]

(In reply to comment #28)
> (In reply to comment #26)
> >I would suggest leaving 'd' for "Send Link", and using 'i' for "Close Window".
> >Less change that way for people who are used to alt+f d.
> Maybe change "Work Offline" to k? Fewer people would use that, I guess.

Hmmm, I for one use Alt+F, W extensively.  Of course I may not be considered typical user.

Thinking of it, recently I use that key combination less often in Firefox, since it now can automatically adjust offline settings with the network connectivity of the computer.  If there are similar plans for Seamonkey as well, then maybe we can switch Work Offline's access key.

> >'T' for "Close Other Tabs" is fine, though I would pick 't' to associate with
> >"Other", not "Tabs".
> No, you should always prefer to use capitals where possible.

Is the document previously located at <http://www.mozilla.org/projects/ui/accessibility/accesskey.html> available somewhere?

Comment 30

[Phil Ringnalda (:philor)]

http://developer.mozilla.org/en/docs/XUL_Accesskey_FAQ_and_Policies perhaps?

Comment 31

[(no longer active)]

jag, do you think you can review attachment 271847 [details]?  I'm not too familiar with seamonkey review process, but this has been in the review queue for over two months...

Thanks!

Comment 32

[jag (Peter Annema)]

Comment on attachment 271487 [details] [diff] [review]
Seamonkey: Correct File menu items access keys

I think I prefer Neil's suggestion of using 'k' for Work Offline, 'W' for Close Window, and keep 'd' on Send Link.

Comment 33

[(no longer active)]

Attachment: Seamonkey: Correct File menu items access keys (revised)

(In reply to comment #32)
> (From update of attachment 271487 [details] [diff] [review])
> I think I prefer Neil's suggestion of using 'k' for Work Offline, 'W' for Close
> Window, and keep 'd' on Send Link.
> 

Revised the patch according to the above.  This should be what you were looking for IINM...

Comment 34

[jag (Peter Annema)]

Comment on attachment 293113 [details] [diff] [review]
 Seamonkey: Correct File menu items access keys (revised)

r=jag

Comment 35

[(no longer active)]

Comment on attachment 293113 [details] [diff] [review]
 Seamonkey: Correct File menu items access keys (revised)

jag, perhaps you can handle sr on this as well?

Comment 36

[jag (Peter Annema)]

I was gonna say that Neil should get a chance to do it, but he already did.

Comment 37

[(no longer active)]

Thanks for r/sr, jag.

Nominating the patch in attachment 293113 [details] [diff] [review] for checkin, which should fix the SeaMonkey side of this bug, and mark it as RESOLVED FIX.

Comment 38

[jag (Peter Annema)]

Thank Neil for the sr.

Comment 39

[Reed Loden [:reed]]

Checking in suite/browser/navigatorOverlay.xul;
/cvsroot/mozilla/suite/browser/navigatorOverlay.xul,v  <--  navigatorOverlay.xul
new revision: 1.332; previous revision: 1.331
done
Checking in suite/locales/en-US/chrome/browser/navigator.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/browser/navigator.dtd,v  <--  navigator.dtd
new revision: 1.183; previous revision: 1.182
done
Checking in suite/locales/en-US/chrome/common/utilityOverlay.dtd;
/cvsroot/mozilla/suite/locales/en-US/chrome/common/utilityOverlay.dtd,v  <--  utilityOverlay.dtd
new revision: 1.34; previous revision: 1.33
done