convert uses of "defer" to "new Promise" - client/sourceeditor

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Source Editor
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: smfurqan, Assigned: stylizit)

Tracking

(Blocks: 1 bug)

52 Branch
Firefox 55
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170329150204

Updated

9 months ago
Assignee: nobody → smfurqan
Blocks: 1283869

Updated

9 months ago
Component: Untriaged → Developer Tools: Source Editor
(Reporter)

Comment 1

9 months ago
I have been going through the different files to locate the instances of "defer" that need to be updated but I'm a little confused on how I should convert them to "new promise". Could you provide some guidance please?
Flags: needinfo?(ttromey)
Flags: needinfo?(epinal99-bugzilla2)

Comment 2

9 months ago
I'm just triager.
Flags: needinfo?(epinal99-bugzilla2)

Comment 3

9 months ago
(In reply to smfurqan from comment #1)
> I have been going through the different files to locate the instances of
> "defer" that need to be updated but I'm a little confused on how I should
> convert them to "new promise". Could you provide some guidance please?

I think this message shows the ordinary approach:
https://groups.google.com/forum/#!msg/mozilla.dev.developer-tools/IYw2U4TCNYU/JwfhnfomAwAJ

It's possible there could be cases that can't be handled this way.
If you run across one of those we can discuss it here or on irc.
Flags: needinfo?(ttromey)
Comment hidden (mozreview-request)

Comment 5

8 months ago
mozreview-review
Comment on attachment 8869803 [details]
Bug 1355696 - convert uses of 'defer' to 'new Promise' in client/sourceeditor;

https://reviewboard.mozilla.org/r/141332/#review145262

Thanks for the patch.  This looks good to me.  I'll send it through try now.
Attachment #8869803 - Flags: review?(ttromey) → review+
(In reply to Tom Tromey :tromey from comment #5)
> Thanks for the patch.  This looks good to me.  I'll send it through try now.

Thanks for the review! Try results seem to show intermittent failures and Webcrypto. Those seem unrelated to me, so we should be good to go?

P.S: Sorry to flood you with so many review reqs
Assignee: smfurqan → matthieu.rigolot

Comment 7

8 months ago
(In reply to Matt R :stylizit from comment #6)
> (In reply to Tom Tromey :tromey from comment #5)
> > Thanks for the patch.  This looks good to me.  I'll send it through try now.
> 
> Thanks for the review! Try results seem to show intermittent failures and
> Webcrypto. Those seem unrelated to me, so we should be good to go?

Yep.  Going to land it now.  Thanks again for the patch.

> P.S: Sorry to flood you with so many review reqs

It's the sort of problem that's good to have :)
It may take me another day to review them due to my schedule here,
but I will make some progress today at least.

Comment 8

8 months ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fde169875b3
convert uses of 'defer' to 'new Promise' in client/sourceeditor; r=tromey

Comment 9

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2fde169875b3
Status: UNCONFIRMED → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.