1355735 - Custom tabs: Menu says "Open in Android-System" if no default browser is set

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Comment 1

[Sorina Florean [:sflorean]]

I can confirm this behavior, seen it while testing CustomTabs. And today found another one, "Open in Open" on Yahnac and Chromer, Google+. 
Here is a screenshot: https://i.imgur.com/0BP31QB.png.

Comment 2

[Sorina Florean [:sflorean]]

This issue is still reproducible with new CustomTab implementation. Setting the flag 57:affected.

Comment 3

[Julian Chu [:walkingice]]

Attachment: Bug 1355735 - Add util to pick name for default browser

The util PackageUtil helps to get ResolveInfo of default browser, then
we can use it in CustomTabs menu. If user hasn't set any default
browser, instead we display "..." for browser name.

Review commit: https://reviewboard.mozilla.org/r/178260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/178260/

Comment 4

[Jing-wei Wu [:jwu]]

Comment on attachment 8906493 [details]
Bug 1355735 - Add util to pick name for default browser

https://reviewboard.mozilla.org/r/178260/#review183166

::: mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java:373
(Diff revision 1)
>          final MenuItem openItem = geckoMenu.findItem(R.id.custom_tabs_menu_open_in);
>          if (openItem != null) {
> -            final Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse("http://"));
> -            final ResolveInfo info = getPackageManager()
> -                    .resolveActivity(browserIntent, PackageManager.MATCH_DEFAULT_ONLY);
> -            final String name = info.loadLabel(getPackageManager()).toString();
> +            final ResolveInfo info = PackageUtil.getDefaultBrowser(this);
> +
> +            final String name = (info == null)
> +                    ? "..."

Should we use R.string.ellipsis(unicode \u2026 for horizontal ellipsis), instead of three dots?

Comment 5

[Julian Chu [:walkingice]]

Comment on attachment 8906493 [details]
Bug 1355735 - Add util to pick name for default browser

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/178260/diff/1-2/

Comment 6

[Julian Chu [:walkingice]]

Comment on attachment 8906493 [details]
Bug 1355735 - Add util to pick name for default browser

https://reviewboard.mozilla.org/r/178260/#review183166

> Should we use R.string.ellipsis(unicode \u2026 for horizontal ellipsis), instead of three dots?

yes this one is much better

Comment 7

[Jing-wei Wu [:jwu]]

Comment on attachment 8906493 [details]
Bug 1355735 - Add util to pick name for default browser

https://reviewboard.mozilla.org/r/178260/#review183176

Comment 8

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 04c4813230fd -d 629ebf9fa725: rebasing 419163:04c4813230fd "Bug 1355735 - Add util to pick name for default browser r=jwu" (tip)
merging mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java
merging mobile/android/base/moz.build
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 9

[Julian Chu [:walkingice]]

Comment on attachment 8906493 [details]
Bug 1355735 - Add util to pick name for default browser

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/178260/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdd9f6610d88
Add util to pick name for default browser r=jwu

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cdd9f6610d88

Comment 12

[Sorina Florean [:sflorean]]

Verified as fixed on latest Nightly 60.0a1, Beta 59.0b11 and Relese build 58.0.2. 
Device: Samsung Galaxy Note 4 (Android 5.0.1).