Closed Bug 1355758 Opened 3 years ago Closed 3 years ago

stylo: Element.getAnimations() returns transitions with incorrect order

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: boris, Assigned: boris)

References

Details

Attachments

(1 file)

Bug 1341372 detects transition and make it run. However, the order of transitions are not correct, so a test is failed [1].

[1] http://searchfox.org/mozilla-central/rev/2fc8c8d483d9ec9fd0ec319c6c53807f7fa8e8a2/dom/animation/test/css-transitions/file_element-get-animations.html#127-143
Assignee: nobody → boris.chiou
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 8860311 [details]
Bug 1355758 - Update RestyleManager::mAnimationGeneration for non-animation update.

https://reviewboard.mozilla.org/r/132340/#review135496

::: layout/base/ServoRestyleManager.h:152
(Diff revision 1)
>  
>    // Only non-null while processing change hints. See the comment in
>    // ProcessPendingRestyles.
>    ReentrantChangeList* mReentrantChanges;
> +
> +  bool mHaveNonAnimationRestyles = false;

Can you please put a brief comment here explaining why we need to track this state.
Attachment #8860311 - Flags: review?(cam) → review+
Comment on attachment 8860311 [details]
Bug 1355758 - Update RestyleManager::mAnimationGeneration for non-animation update.

https://reviewboard.mozilla.org/r/132340/#review135496

> Can you please put a brief comment here explaining why we need to track this state.

OK. Sure.
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a418fa4ad285
Update RestyleManager::mAnimationGeneration for non-animation update. r=heycam
https://hg.mozilla.org/mozilla-central/rev/a418fa4ad285
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
See Also: → 1383998
Blocks: 1383998
See Also: 1383998
You need to log in before you can comment on or make changes to this bug.