1355834 - "LLVMSymbolizer: error reading file: Cannot allocate memory" should be reported as an error

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Andrew McCreight [:mccr8]]

Sometimes the LLVM symbolizer fails to run, with a message like this:

==1421==WARNING: Can't read from symbolizer at fd 3
LLVMSymbolizer: error reading file: Cannot allocate memory

This causes a baffling massive leak in LSan (because we rely on white lists to ignore leaks, and the white lists require the symbolizer).

Glandium hit this issue on try recently, and this came up on autoland just now:
https://treeherder.mozilla.org/logviewer.html#?job_id=90922093&repo=autoland&lineNumber=2851

We should make the "LLVMSymbolizer: error reading file: Cannot allocate memory" message into an error that will show up in the starring interface, so that sheriffs at least have something useful to guide starring, and it will also let us track how often it is happening.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1355834 - Report LLVM symbolizer OOMs as errors.

This will make it easier to correctly star these failures, which
otherwise simply show up as a false positive leak.

Review commit: https://reviewboard.mozilla.org/r/129614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129614/

Comment 2

[Intermittent Failures Robot]

22 failures in 817 pushes (0.027 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 22

Platform breakdown:
* linux64: 22

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1355834&startday=2017-04-17&endday=2017-04-23&tree=all

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8857660 [details]
Bug 1355834 - Report LLVM symbolizer OOMs as errors.

https://reviewboard.mozilla.org/r/129614/#review136352

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1dcb4f3e6e3
Report LLVM symbolizer OOMs as errors. r=jgraham

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f1dcb4f3e6e3