Closed Bug 1355834 Opened 3 years ago Closed 3 years ago

"LLVMSymbolizer: error reading file: Cannot allocate memory" should be reported as an error

Categories

(Testing :: General, defect)

Version 3
defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Sometimes the LLVM symbolizer fails to run, with a message like this:

==1421==WARNING: Can't read from symbolizer at fd 3
LLVMSymbolizer: error reading file: Cannot allocate memory

This causes a baffling massive leak in LSan (because we rely on white lists to ignore leaks, and the white lists require the symbolizer).

Glandium hit this issue on try recently, and this came up on autoland just now:
https://treeherder.mozilla.org/logviewer.html#?job_id=90922093&repo=autoland&lineNumber=2851

We should make the "LLVMSymbolizer: error reading file: Cannot allocate memory" message into an error that will show up in the starring interface, so that sheriffs at least have something useful to guide starring, and it will also let us track how often it is happening.
Comment on attachment 8857660 [details]
Bug 1355834 - Report LLVM symbolizer OOMs as errors.

https://reviewboard.mozilla.org/r/129614/#review136352
Attachment #8857660 - Flags: review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1dcb4f3e6e3
Report LLVM symbolizer OOMs as errors. r=jgraham
https://hg.mozilla.org/mozilla-central/rev/f1dcb4f3e6e3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
See Also: → 1361476
Attachment #8857660 - Flags: review?(ahalberstadt)
You need to log in before you can comment on or make changes to this bug.