Closed Bug 1355843 Opened 8 years ago Closed 8 years ago

stylo: Main thread assertion failure in mozilla::LangGroupFontPrefs::Initialize

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1355097

People

(Reporter: ferjm, Unassigned)

References

Details

I get this crash when running m-c 352202 with ./mach run --disable-e10s Assertion failure: NS_IsMainThread(), at /Users/ferjm/dev/mozilla/mozilla-central/modules/libpref/Preferences.cpp:481 #01: mozilla::Preferences::GetInt(char const*, int*)[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x14edac] #02: mozilla::LangGroupFontPrefs::Initialize(nsIAtom*)[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2dc24b7] #03: Gecko_GetBaseSize[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2c13199] #04: _$LT$style..gecko..wrapper..GeckoFontMetricsProvider$u20$as$u20$style..font_metrics..FontMetricsProvider$GT$::get_size::h2d1819528b0326c7[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5277e33] #05: style::gecko_string_cache::Atom::with::h82869195fec1c271[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5272b9e] #06: _$LT$style..properties..longhands..font_size..KeywordSize$u20$as$u20$style..values..computed..ToComputedValue$GT$::to_computed_value::h9df63a5a5d48ae12[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x507126b] #07: _$LT$style..properties..longhands..font_size..SpecifiedValue$u20$as$u20$style..values..computed..ToComputedValue$GT$::to_computed_value::hd81ae47a4867ea42[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5071352] #08: style::properties::longhands::font_size::cascade_property::_$u7b$$u7b$closure$u7d$$u7d$::h007539fefc728c5e[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5071502] #09: style::properties::substitute_variables_font_size::h3b8433c35619304a[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x50a897f] #10: style::properties::longhands::font_size::cascade_property::hf4caae87c29b5c4d[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x52a305f] #11: style::properties::apply_declarations::h084bd60e074def93[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x51092f1] #12: style::properties::cascade::hdc8175e8c4fdfbbd[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x510895b] #13: style::matching::PrivateMatchMethods::cascade_with_rules::h4ea9cb36d796c4ad[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x527d51c] #14: style::matching::PrivateMatchMethods::cascade_internal::hb6c31bedaa6678b8[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x527d698] #15: style::matching::PrivateMatchMethods::cascade_primary_or_pseudo::h2acaa94db47b90ab[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x527d73e] #16: style::matching::MatchMethods::match_and_cascade::hd1559d4bc9c76b46[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x527dc46] #17: style::traversal::compute_style::h20df25a0ad53470a[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x4f9f36e] #18: style::traversal::recalc_style_at::h1465cd50c20c5197[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5285f01] #19: _$LT$style..gecko..traversal..RecalcStyleOnly$LT$$u27$recalc$GT$$u20$as$u20$style..traversal..DomTraversal$LT$style..gecko..wrapper..GeckoElement$LT$$u27$le$GT$$GT$$GT$::process_preorder::h93c513402c870807[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5276a34] #20: style::parallel::traverse_nodes::h5988a46d60d6e2fe[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x4dee3db] #21: style::parallel::traverse_dom::_$u7b$$u7b$closure$u7d$$u7d$::_$u7b$$u7b$closure$u7d$$u7d$::hc946997fc5b3e14f[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x4e85ec4] #22: rayon::scope::Scope::execute_job_closure::_$u7b$$u7b$closure$u7d$$u7d$::hc1d7ab3988d8d175[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x4e7d7fc] #23: _$LT$std..panic..AssertUnwindSafe$LT$F$GT$$u20$as$u20$core..ops..FnOnce$LT$$LP$$RP$$GT$$GT$::call_once::he920b5abc5504268[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x4e8f8e0] #24: std::panicking::try::do_call::h62b72be19bb8e41b[/Users/ferjm/dev/mozilla/mozilla-central/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/XUL +0x4e6f490]
Manish, this is the FontGroup code you added recently, can you take a look?
Blocks: stylo
Flags: needinfo?(manishearth)
Summary: Crash in mozilla::LangGroupFontPrefs::Initialize → stylo: Main thread assertion failure in mozilla::LangGroupFontPrefs::Initialize
There probably needs to be an initialize call in nsLayoutStatics.
Oh, sorry, this was already fixed in bug 1355097
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(manishearth)
Resolution: --- → DUPLICATE
Are you sure? Those seem to be under Preferences::InitStaticMembers. The stack here seems different.
InitStaticMembers is probably inlined here and won't show up in the stack. The assertion is in Preferences.cpp:481 , which is InitStaticMembers.
You need to log in before you can comment on or make changes to this bug.