1355941 - Misuse of $TmpVal in installer

Status: RESOLVED FIXED

(Firefox :: Installer, task, P5)

Description

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

This use of $TmpVal in Function preSummary seems to be assuming it is either HKLM or HKCU, as it is in Section "-Application":

>    ${If} $TmpVal == "HKLM"
>      SetShellVarContext all ; Set SHCTX to all users
>    ${EndIf}

http://searchfox.org/mozilla-central/rev/2fc8c8d483d9ec9fd0ec319c6c53807f7fa8e8a2/browser/installer/windows/nsis/installer.nsi#1013

But when preSummary runs, $TmpVal is not yet set this way, as the install hasn't started yet, so the test will always fail. A few lines down there's a check of $TmpVal against values set in CheckExistingInstall, called from leaveOptions, leaveDirectory, leaveShortcuts, so even if $TmpVal had been set to "HKLM" it wouldn't have survived if there was a preexisting Firefox install.

It's not clear whether this matters, likely not as it seems this had never worked as intended.

Comment 1

[June Wilde (she/her) [:jewilde]]

Try CI builds happening here

Comment 2

[June Wilde (she/her) [:jewilde]]

Attachment: Bug 1355941 - Remove unused if block in installer.nsi; r?agashlin

In the preSummary function TmpVal was being checked before it could be set
causing the test to always fail.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66ae37d9ad69
Remove unused if block in installer.nsi; r=agashlin

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/66ae37d9ad69