1356027 - Add pref that disables loading any extensions without MPC=true

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1356027 Add pref to disable non-MPC extensions

Review commit: https://reviewboard.mozilla.org/r/129732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129732/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8857759 [details]
Bug 1356027 Add pref to disable non-MPC extensions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129732/diff/1-2/

Comment 3

[Andrew Swan [:aswan]]

Mossop: full context for this is in bug 1352204.  The test feels a little light to me, if you have ideas about scenarios I may have overlooked, I'd be glad to add more tests.

Comment 4

[Andrew Swan [:aswan]]

Mossop pointed out on IRC that appDisabled is stored in extensions.json and not generally recomputed when the browser starts, so without any further changes, when we flip the pref on Nightly this won't take effect for non-MPC extensions that are already installed.  Recomputing requires re-reading extensions.json which is expensive enough that we want to avoid it when it isn't necessary, but changing the schema version causes it to be rebuilt (which recomputes appDisabled).

I verified this manually by doing the following:
1. Install an old version of ghostery that is not marked MPC, it installs successfully.
2. Close the browser, edit profile/prefs.js to set extensions.allow-non-mpc-extensions to false, restart the browser, ghostery is not disabled.
3. Close the browser, increment DB_SCHEMA in XPIProvider.jsm, (clear the startup cache), restart the browser, ghostery is disabled.

So this should be good to go as-is, we'll need to increment DB_SCHEMA when we flip the pref as discussed in bug 1352204.

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8857759 [details]
Bug 1356027 Add pref to disable non-MPC extensions

https://reviewboard.mozilla.org/r/129732/#review133012

Looks good. A few things we could do to bulk out the test a little:

1. Also test an add-on that is mpc.
2. Test installing when the pref is not set.
3. Flip the pref back to false when the add-on is still installed and make sure it becomes disabled again.

Comment 6

[Andrew Swan [:aswan]]

Comment on attachment 8857759 [details]
Bug 1356027 Add pref to disable non-MPC extensions

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129732/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8987472ddb9f
Add pref to disable non-MPC extensions r=mossop

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8987472ddb9f