Closed
Bug 1356031
Opened 8 years ago
Closed 4 years ago
Remove toolkit error-16.png and replace usages with respective SVGs
Categories
(Toolkit :: Themes, defect)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
84 Branch
Tracking | Status | |
---|---|---|
firefox84 | --- | fixed |
People
(Reporter: florian, Assigned: ntim)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
chrome://global/skin/icons/error-16.png is only used on devtools and on Windows by http://searchfox.org/mozilla-central/rev/944f87c575e8a0bcefc1ed8efff10b34cf7a5169/toolkit/themes/windows/global/notification.css#56
I don't think devtools should rely on toolkit image files that aren't used anywhere else.
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Florens, do you know if there's an ongoing work to redesign the devtools notification bar ?
It'd be nice to be able to get rid of those 2 files:
https://searchfox.org/mozilla-central/source/toolkit/themes/windows/global/icons/error-16.png
https://searchfox.org/mozilla-central/source/toolkit/themes/osx/global/icons/error-16.png
Since devtools is the only consumer.
Flags: needinfo?(florens)
Assignee | ||
Updated•6 years ago
|
Blocks: png-cleanup
No longer depends on: png-cleanup
Comment 2•6 years ago
|
||
I'm not sure which notification bar this NotificationBox component is. It's seems mostly used in XUL tools (Scratchpad, Storage, old Console I think?), and I'm not sure I've actually seen it much in day-to-day use. There is probably no redesign in the works.
The simplest way to stop depending on this PNG icon to to switch to the corresponding "error.svg" in devtools/client/shared/components/NotificationBox.css:
.notificationbox .messageImage[data-type="critical"] {
- background-image: url("chrome://global/skin/icons/error-16.svg");
+ background-image: url("chrome://global/skin/icons/error.svg");
+ -moz-context-properties: fill;
+ fill: currentColor;
}
Apparently the "critical" message has white text and a red background, so filling the icon with the currentColor (white) seems like the best option.
Flags: needinfo?(florens)
Assignee | ||
Updated•4 years ago
|
Component: Framework → Themes
Product: DevTools → Toolkit
Summary: chrome://global/skin/icons/error-16.png should be moved to devtools → Remove toolkit error-16.png and replace usages with respective SVGs
Assignee | ||
Comment 3•4 years ago
|
||
Updated•4 years ago
|
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/cb8c18a63c90
Remove toolkit error-16.png and replace usages with respective SVGs. r=Itiel
Comment 5•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox84:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•