1356067 - Possible memory leak in nsUrlClassifierLookupCallback::CompletionV4

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Description

[Dimi Lee [:dimi]]

This is found by Coverty Scan

*** CID 1405018:  Resource leaks  (RESOURCE_LEAK)
/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp: 1238 in nsUrlClassifierLookupCallback::CompletionV4(const nsACString &, const nsACString &, unsigned int, nsIArray *)()
1232       result->response.negativeCacheExpirySec = nowSec + aNegativeCacheDuration;
1233
1234       // Fill in positive cache entries.
1235       uint32_t fullHashCount = 0;
1236       nsresult rv = aFullHashes->GetLength(&fullHashCount);
1237       if (NS_FAILED(rv)) {
>>>     CID 1405018:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "result" going out of scope leaks the storage it points to.
1238         return rv;
1239       }
1240
1241       for (uint32_t i = 0; i < fullHashCount; i++) {
1242         nsCOMPtr<nsIFullHashMatch> match = do_QueryElementAt(aFullHashes, i);
1243

Comment 1

[François Marier [:francois]]

Dimi, do you think it's important enough to put in M6 or can we fix it during M7?

Comment 2

[Dimi Lee [:dimi]]

(In reply to François Marier [:francois] from comment #1)
> Dimi, do you think it's important enough to put in M6 or can we fix it
> during M7?

It's not so critical because it won't cause memory leak unless aFullHashes->GetLength return error.
But I think we can leave it to M6 because it is regression of caching and is not very hard to fix.

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1356067 - Fix memory leak in nsUrlClassifierLookupCallback::CompletionV4.

Review commit: https://reviewboard.mozilla.org/r/129810/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129810/

Comment 4

[François Marier [:francois]]

Comment on attachment 8857809 [details]
Bug 1356067 - Fix memory leak in nsUrlClassifierLookupCallback::CompletionV4.

https://reviewboard.mozilla.org/r/129810/#review132730

Comment 5

[Dimi Lee [:dimi]]

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=545429ff579015a11725aa2b9a08fdc36859d8e4

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c5efe2090ff
Fix memory leak in nsUrlClassifierLookupCallback::CompletionV4. r=francois

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3c5efe2090ff