1356079 - Intermittent toolkit/components/places/tests/favicons/test_root_icons.js | test_removePagesByTimeframe - [test_removePagesByTimeframe : 75] There should only be 1 icon entry - 2 == 1

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=91060388&repo=autoland

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-macosx64/1492031528/autoland_yosemite_r7_test-xpcshell-bm132-tests1-macosx-build190.txt.gz

Comment 1

[Marco Bonardo [:mak]]

I'll see if I can figure out something.

Comment 2

[Marco Bonardo [:mak]]

I'll fix this in bug 1356567, the problem is that the test is passing milliseconds instead of microseconds to addVisits. I'm also adding protection for that.

Comment 3

[Marco Bonardo [:mak]]

To more exact, it's a bug in PlacesTestUtils.addVisits that uses instanceof Date on a date object that crossed a boundary between 2 global objects. Easy to fix, hard to find :)

Comment 4

[Marco Bonardo [:mak]]

fixed by bug 1356567.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Still occurring, e.g. https://treeherder.mozilla.org/logviewer.html#?job_id=94494086&repo=autoland

Comment 6

[Marco Bonardo [:mak]]

hm, may be just due to the concurrent connection reading from an outdated db snapshot. Worth a try.

Comment 7

[Marco Bonardo [:mak]]

Attachment: Bug 1356079 - Ensure the queried db snapshot is current in test_root_icons.js.

Review commit: https://reviewboard.mozilla.org/r/134238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/134238/

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 8862309 [details]
Bug 1356079 - Ensure the queried db snapshot is current in test_root_icons.js.

https://reviewboard.mozilla.org/r/134238/#review137836

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14244aafaa91
Ensure the queried db snapshot is current in test_root_icons.js. r=adw

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/14244aafaa91