Closed
Bug 1356111
Opened 8 years ago
Closed 8 years ago
Update bloom microbenchmark to use a real color
Categories
(Testing :: Talos, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
1.85 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
I realized that the CSS color property doesn't accept string colors. This doesn't make a difference on Gecko, but Servo seems to optimize out empty declarations, so we should fix this.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8857763 -
Flags: review?(cam)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8857763 [details] [diff] [review]
Fix bloom filter microbenchmark. v1
Review of attachment 8857763 [details] [diff] [review]:
-----------------------------------------------------------------
::: testing/talos/talos/tests/perf-reftest/bloom-basic.html
@@ +3,5 @@
> <head>
> <script src="util.js"></script>
> <script>
> window.onload = function() {
> + document.head.appendChild(build_rule("span div", 10000, '{ color: #ff0000; } '));
That's fine. Or you can remove the quotes and just do:
document.head.appendChild(build_rule("span div", 10000, '{ color: blue; } '));
Attachment #8857763 -
Flags: review?(cam) → review+
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6386d8f32e1d
Fix bloom filter microbenchmark. r=heycam
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•