1356182 - Custom tabs: cannot display long URL properly

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, enhancement, P2)

Description

[Julian Chu [:walkingice]]

Attachment: string_wrapping.png

If we navigate to long URL, the title-view or url-view doesn't wrap well.

I only reproduce it on Nexus-5/Android 6.0.1. (navigate to https://www.google.com.tw) Not sure whether prior Android version will be effect or not.

Comment 1

[Julian Chu [:walkingice]]

Attachment: set ellipsize to text view

We can set ellipse to the text view.

Sebastian, do you think it might cause potential security bug?

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: cct.png

(In reply to Julian Chu [:walkingice] from comment #1)
> Created attachment 8857888 [details]
> set ellipsize to text view
> 
> We can set ellipse to the text view.
> 
> Sebastian, do you think it might cause potential security bug?

It's one of those things where someone could try to spoof the URL by pretending to be another page by moving the actual page domain out of the visible area. A naive way of doing this would be [wwwwwwwwwwwwwwwwwww.google.com].evil-site.com where only the part between [] is visible.

Chrome custom tabs seem to suffer from the same problem (see attached screenshot).

This isn't even fully solved in Fennec - although you can at least click into the URL bar and the see everything. See bug 1236431 for some history. Back then we tried to solve this by only showing the *origin* part of the domain. We pulled this in bug 1268753 again. But this might still be a suitable approach for custom tabs - where we not want to show the full URL/domain necessarily. Also see bug 1271998 for a proposal to make this less problematic in Fennec.

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[triage]
P2 as not a sec-high. issue

Comment 4

[Julian Chu [:walkingice]]

Attachment: scrollable title and url textview

Tried to wrap textview in HorizontalScrollView, likely it is close to the proposal. This attachment is running on Android 4.4.4 CyanogenMod.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

this is likely the older implementation. does it still apply to 57 implementation? 
on a quick test, things look fine to me.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[triage] Potential spoofing so potentially critical - I'd suggest we consider Sebastian's approaches, in particular just showing the origin.

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.