Crash in profiler_set_frame_number

RESOLVED FIXED in Firefox 55

Status

()

Core
Gecko Profiler
--
critical
RESOLVED FIXED
9 months ago
5 months ago

People

(Reporter: calixte, Assigned: njn)

Tracking

(Blocks: 1 bug, {crash})

55 Branch
mozilla55
Unspecified
Windows 10
crash
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

Details

(Whiteboard: [clouseau], crash signature)

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
This bug was filed from the Socorro interface and is 
report bp-06b7d81b-708a-4649-a28b-4c72b2170412.
=============================================================

There are 18 crashes coming from 1 installation in nightly 55 with buildid 20170412030252.

:njn, I don't know if it's related to your recent modifications in this part of the code, but maybe...
Flags: needinfo?(n.nethercote)
The assertion is probably just wrong. I will take a look early next week.
Assignee: nobody → n.nethercote
Flags: needinfo?(n.nethercote)
(Reporter)

Comment 2

9 months ago
In report [1], the user added this comment:
"enabled user_pref("layers.frame-counter", true); wanted to see what it is doing. crashing permarnently. have to remove it manually from prefs.js"

[1] https://crash-stats.mozilla.com/report/index/e3de443d-5d57-4d79-bec9-d0cdb2170417
Created attachment 8859011 [details] [diff] [review]
Fix assertion in profiler_set_frame_number()

This function can run off the main thread when 'layers.frame-counter' is
enabled.
Attachment #8859011 - Flags: review?(mstange)
Attachment #8859011 - Flags: review?(mstange) → review+

Comment 4

9 months ago
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bbf24f5eb3b
Fix assertion in profiler_set_frame_number(). r=mstange.

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9bbf24f5eb3b
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1342306
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox-esr52: --- → unaffected
Blocks: 1396527
You need to log in before you can comment on or make changes to this bug.