1356249 - Crash in profiler_set_frame_number

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is 
report bp-06b7d81b-708a-4649-a28b-4c72b2170412.
=============================================================

There are 18 crashes coming from 1 installation in nightly 55 with buildid 20170412030252.

:njn, I don't know if it's related to your recent modifications in this part of the code, but maybe...

Comment 1

[Nicholas Nethercote [inactive]]

The assertion is probably just wrong. I will take a look early next week.

Comment 2

[Calixte Denizet (:calixte)]

In report [1], the user added this comment:
"enabled user_pref("layers.frame-counter", true); wanted to see what it is doing. crashing permarnently. have to remove it manually from prefs.js"

[1] https://crash-stats.mozilla.com/report/index/e3de443d-5d57-4d79-bec9-d0cdb2170417

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Fix assertion in profiler_set_frame_number()

This function can run off the main thread when 'layers.frame-counter' is
enabled.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bbf24f5eb3b
Fix assertion in profiler_set_frame_number(). r=mstange.

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9bbf24f5eb3bb3e5313db5dd64b0aa2d426675f1
Bug 1356249 - Fix assertion in profiler_set_frame_number(). r=mstange.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9bbf24f5eb3b