Implement support for XSolarisGetVisualGamma()

ASSIGNED
Assigned to

Status

()

Core
XUL
ASSIGNED
16 years ago
16 years ago

People

(Reporter: Roland Mainz, Assigned: Roland Mainz)

Tracking

Trunk
mozilla1.0
Sun
Solaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
[Looking at bug 53597 ("CSS colors are missing gamma correction") I noticed that
we do not implement support for XSolarisGetVisualGamma() - therefore:]

RFE: Implemement support for XSolarisGetVisualGamma()
(Assignee)

Comment 1

16 years ago
Taking myself...
Assignee: jaggernaut → Roland.Mainz
Depends on: 53597
Target Milestone: --- → mozilla1.0
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

16 years ago
Created attachment 77844 [details] [diff] [review]
Patch for 2002-03-31-08-trunk (requires patch from bug 53597)
(Assignee)

Comment 3

16 years ago
Requesting r=/sr= ...
Keywords: patch, review
r=cls on the Makefile changes
you'll want to remove XSolarisGetVisualGamma from the comment that states that
it should be used
And: maybe you should add this code also to Qt

However, couldn't this be put into x11shared/ directory so only 1 file needs to
be changed if a new way for getting Gamma values is added?
(Assignee)

Comment 7

16 years ago
Christian Biesinger wrote:
> you'll want to remove XSolarisGetVisualGamma from the comment that states that
> it should be used

OK, I can do that at checkin time or when the (super-)reviewer wants a new
patch...

----

> And: maybe you should add this code also to Qt

Qt is another, bigger problem. Currently it is completly broken... and IMHO the
Qt API should provide a method to do this - we should not call the
Solaris-specific API directly...

> However, couldn't this be put into x11shared/ directory so only 1 file needs 
> to be changed if a new way for getting Gamma values is added?

Not really, the code is too small. I still hope that we get (someday) an unified
gfx code... ;-(
>IMHO the
>Qt API should provide a method to do this - we should not call the
>Solaris-specific API directly...

well, Gtk should, too, but apparently it doesn't :)

and yes, I know it doesn't compile, but this is an easy change, esp. if you
leave the PR_LOG stuff out. anyway, do it or not, I don't really care.
You need to log in before you can comment on or make changes to this bug.