135634 - Implement support for XSolarisGetVisualGamma()

Status: RESOLVED WONTFIX

(Core :: XUL, defect)

Description

[Roland Mainz]

[Looking at bug 53597 ("CSS colors are missing gamma correction") I noticed that
we do not implement support for XSolarisGetVisualGamma() - therefore:]

RFE: Implemement support for XSolarisGetVisualGamma()

Comment 1

[Roland Mainz]

Taking myself...

Comment 2

[Roland Mainz]

Attachment: Patch for 2002-03-31-08-trunk (requires patch from bug 53597)

Comment 3

[Roland Mainz]

Requesting r=/sr= ...

Comment 4

[hacker formerly known as [e-mail]]

r=cls on the Makefile changes

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

you'll want to remove XSolarisGetVisualGamma from the comment that states that
it should be used

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

And: maybe you should add this code also to Qt

However, couldn't this be put into x11shared/ directory so only 1 file needs to
be changed if a new way for getting Gamma values is added?

Comment 7

[Roland Mainz]

Christian Biesinger wrote:
> you'll want to remove XSolarisGetVisualGamma from the comment that states that
> it should be used

OK, I can do that at checkin time or when the (super-)reviewer wants a new
patch...

----

> And: maybe you should add this code also to Qt

Qt is another, bigger problem. Currently it is completly broken... and IMHO the
Qt API should provide a method to do this - we should not call the
Solaris-specific API directly...

> However, couldn't this be put into x11shared/ directory so only 1 file needs 
> to be changed if a new way for getting Gamma values is added?

Not really, the code is too small. I still hope that we get (someday) an unified
gfx code... ;-(

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

>IMHO the
>Qt API should provide a method to do this - we should not call the
>Solaris-specific API directly...

well, Gtk should, too, but apparently it doesn't :)

and yes, I know it doesn't compile, but this is an easy change, esp. if you
leave the PR_LOG stuff out. anyway, do it or not, I don't really care.

Comment 9

[Jonathan]

Solaris is no longer officially supported

Should this therefore be closed?

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:enndeakin, could you have a look please?
For more information, please visit auto_nag documentation.