1356421 - OpenVR controllers enumeration is not reliable

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Diego Marcos [:dmarcos]]

I have not found a consistent set of steps to reproduce the problems. Calling navigator.getGamepads() is not reliable on page reloads, or when controllers go on / off in the same session or across page reloads. These are the inconsistencies I observed:

- Sometimes when loading a page with a single Vive controller active the id of the gamepad is empty string "" (https://d3vv6lp55qjaqc.cloudfront.net/items/113p2847093n3z242x22/Image%202017-04-13%20at%201.23.47%20PM.png?X-CloudApp-Visitor-Id=3fb0ea5496d108de857ec2934e3b9ba7&v=226d5202)

- Sometimes when loading a page (https://aframe.io/aframe/examples/showcase/tracked-controls/) with two controllers and reloading the same page with just one controller active makes navigator.getGamepads() return an array of two elements where one is null: [Gamepad, null]

- With one tracker and two Vive controllers active navigator.getGamepads() returns an array of three gamepads but the gamepad.id of all of them is  "OpenVR Tracker" where I would expect to see two "OpenVR Gamepad" and one "OpenVR Tracker"

I spend several hours investigating this and I have not found yet a consistent series of steps that reproduce the problems above. I tried restarting Nightly, closing SteamVR, reloading the same page several times, switching on/off controllers. I end up in the bogus steps above often but not with a consistent series of actions.

Comment 1

[Fernando Serrano [:fserrano]]

An easy way to reproduce:
- On Nightly go to https://aframe.io/examples/showcase/tracked-controllers
- Enter VR and press the button on the controllers, they should show up, but they don't
- Go to http://html5gamepad.com and see how the gamepad are enumerated but they don't show any ID next to the controller number.

- Do the same on Chrome, and notice how in html5gamepad it shows 1. OpenVR Gamepad and 2. OpenVR Gamepad.

As we're using the ID to detect the kind of controller available, all the demos using vive are broken right now :(

Comment 2

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1356421 - Part 1: Fix for making OpenVR get correct device types for Gamepad id;

Review commit: https://reviewboard.mozilla.org/r/132760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132760/

Comment 3

[Daosheng Mu[:daoshengmu]]

Well. This is my mistake for implementing OpenVR Tracker support. After putting `deviceType` inside the loop will resolve the problem.

Comment 4

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1356421 - Part 2: Notify GamepadManager when controllers are removed in VR manager;

Review commit: https://reviewboard.mozilla.org/r/132788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132788/

Comment 5

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8860796 [details]
Bug 1356421 - Part 1: Fix for making OpenVR get correct device types for Gamepad id;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/132760/diff/1-2/

Comment 6

[:kip (Kearwood Gilbert)]

Comment on attachment 8860796 [details]
Bug 1356421 - Part 1: Fix for making OpenVR get correct device types for Gamepad id;

https://reviewboard.mozilla.org/r/132760/#review136534

LGTM, Thanks!

Comment 7

[:kip (Kearwood Gilbert)]

Comment on attachment 8860811 [details]
Bug 1356421 - Part 2: Notify GamepadManager when controllers are removed in VR manager;

https://reviewboard.mozilla.org/r/132788/#review136536

LGTM

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0b7e38e69bab
Part 1: Fix for making OpenVR get correct device types for Gamepad id; r=kip
https://hg.mozilla.org/integration/autoland/rev/5e53e3f11012
Part 2: Notify GamepadManager when controllers are removed in VR manager; r=kip

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0b7e38e69bab
https://hg.mozilla.org/mozilla-central/rev/5e53e3f11012