Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Change the type of MediaData::mTimecode to TimeUnit

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

3 months ago
Assignee: nobody → jwwang
Blocks: 1245019
Priority: -- → P3
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Attachment #8859820 - Flags: review?(gsquelart)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8859820 [details]
Bug 1356506 - change the type of MediaData::mTimecode to TimeUnit since int64_t is ambiguous.

https://reviewboard.mozilla.org/r/131806/#review134680

Nice as always. Thank you for including the rationale in the commit description.
Attachment #8859820 - Flags: review?(gsquelart) → review+
(Assignee)

Comment 3

3 months ago
Thanks!

Comment 4

3 months ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59ba67068ce1
change the type of MediaData::mTimecode to TimeUnit since int64_t is ambiguous. r=gerald

Comment 5

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/59ba67068ce1
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.