Closed
Bug 1356506
Opened 7 years ago
Closed 7 years ago
Change the type of MediaData::mTimecode to TimeUnit
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8859820 -
Flags: review?(gsquelart)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859820 [details] Bug 1356506 - change the type of MediaData::mTimecode to TimeUnit since int64_t is ambiguous. https://reviewboard.mozilla.org/r/131806/#review134680 Nice as always. Thank you for including the rationale in the commit description.
Attachment #8859820 -
Flags: review?(gsquelart) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Thanks!
Pushed by jwwang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/59ba67068ce1 change the type of MediaData::mTimecode to TimeUnit since int64_t is ambiguous. r=gerald
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/59ba67068ce1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•