Closed Bug 1356506 Opened 3 years ago Closed 3 years ago

Change the type of MediaData::mTimecode to TimeUnit

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → jwwang
Blocks: 1245019
Priority: -- → P3
Attachment #8859820 - Flags: review?(gsquelart)
Comment on attachment 8859820 [details]
Bug 1356506 - change the type of MediaData::mTimecode to TimeUnit since int64_t is ambiguous.

https://reviewboard.mozilla.org/r/131806/#review134680

Nice as always. Thank you for including the rationale in the commit description.
Attachment #8859820 - Flags: review?(gsquelart) → review+
Thanks!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59ba67068ce1
change the type of MediaData::mTimecode to TimeUnit since int64_t is ambiguous. r=gerald
https://hg.mozilla.org/mozilla-central/rev/59ba67068ce1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.