If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove the usage of nsContentUtils::IsInPrivateBrowsing() in HTMLMediaElement.cpp

RESOLVED FIXED in Firefox 55

Status

()

Core
DOM
P3
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: Ehsan, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Follow-up to bug 1194891.

We need to switch this code to pass in the private browsing ID instead.
Hi Blake, this looks at your wheelhouse.
Flags: needinfo?(bwu)
(Assignee)

Updated

5 months ago
Assignee: nobody → jwwang
Flags: needinfo?(bwu)
Priority: -- → P3
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Attachment #8859033 - Flags: review?(ehsan)
(Reporter)

Comment 3

5 months ago
mozreview-review
Comment on attachment 8859033 [details]
Bug 1356514 - remove the usage of nsContentUtils::IsInPrivateBrowsing() in HTMLMediaElement.cpp.

https://reviewboard.mozilla.org/r/131052/#review135390

Thanks!
Attachment #8859033 - Flags: review?(ehsan) → review+
(Assignee)

Comment 4

5 months ago
Thanks for the review!

Comment 5

5 months ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68798c23a30d
remove the usage of nsContentUtils::IsInPrivateBrowsing() in HTMLMediaElement.cpp. r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/68798c23a30d
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.