Closed
Bug 1356522
Opened 7 years ago
Closed 7 years ago
Remove unnecessary nsICryptoHash output CRLF filtering in nsCSPUtils.cpp
Categories
(Core :: DOM: Security, enhancement, P2)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
References
()
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
This filtering is no longer necessary now that the fix for Bug 1338897 has landed and has gotten rid of the CRLF behaviour.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8858758 [details] Bug 1356522 - Remove unnecessary nsICryptoHash output CRLF filtering in nsCSPUtils.cpp. https://reviewboard.mozilla.org/r/130796/#review133470 Thanks! r+ given our CSP tests within dom/security still work!
Attachment #8858758 -
Flags: review?(ckerschb) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Thanks for the review! https://treeherder.mozilla.org/#/jobs?repo=try&revision=717d67f2e8ea52174ea2342d0bb872c224922d0c
Keywords: checkin-needed
Comment 4•7 years ago
|
||
MozReview isn't showing this as having the necessary reviews required for Autoland to push it. Lack of Level 3 access maybe?
Keywords: checkin-needed
Comment 5•7 years ago
|
||
(In reply to [Out of Office Until 24-April] Ryan VanderMeulen [:RyanVM] from comment #4) > MozReview isn't showing this as having the necessary reviews required for > Autoland to push it. Lack of Level 3 access maybe? The patch has my r+. Any of the Sheriffs, what can we do to get that landed?
Comment 6•7 years ago
|
||
Get someone with Level 3 commit access to r+ it in MozReview.
Keywords: checkin-needed
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8858758 [details] Bug 1356522 - Remove unnecessary nsICryptoHash output CRLF filtering in nsCSPUtils.cpp. https://reviewboard.mozilla.org/r/130796/#review134300
Assignee | ||
Comment 8•7 years ago
|
||
Hmm, could the patch get landed to m-i instead then? ckerschb is module owner of code under dom/security/ (see https://wiki.mozilla.org/Modules/All#Content_Security), so there's really no one more appropriate to give r+. Thanks.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c1d7ee18b7d0 Remove unnecessary nsICryptoHash output CRLF filtering in nsCSPUtils.cpp. r=ckerschb
Keywords: checkin-needed
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c1d7ee18b7d0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•