1356522 - Remove unnecessary nsICryptoHash output CRLF filtering in nsCSPUtils.cpp

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[:Cykesiopka]

This filtering is no longer necessary now that the fix for Bug 1338897 has landed and has gotten rid of the CRLF behaviour.

Comment 1

[:Cykesiopka]

Attachment: Bug 1356522 - Remove unnecessary nsICryptoHash output CRLF filtering in nsCSPUtils.cpp.

This filtering is no longer necessary now that the fix for Bug 1338897 has landed and
has gotten rid of the CRLF behaviour.

Review commit: https://reviewboard.mozilla.org/r/130796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130796/

Comment 2

[Christoph Kerschbaumer [:ckerschb}]

Comment on attachment 8858758 [details]
Bug 1356522 - Remove unnecessary nsICryptoHash output CRLF filtering in nsCSPUtils.cpp.

https://reviewboard.mozilla.org/r/130796/#review133470

Thanks! r+ given our CSP tests within dom/security still work!

Comment 3

[:Cykesiopka]

Thanks for the review!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=717d67f2e8ea52174ea2342d0bb872c224922d0c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

MozReview isn't showing this as having the necessary reviews required for Autoland to push it. Lack of Level 3 access maybe?

Comment 5

[Christoph Kerschbaumer [:ckerschb}]

(In reply to [Out of Office Until 24-April] Ryan VanderMeulen [:RyanVM] from comment #4)
> MozReview isn't showing this as having the necessary reviews required for
> Autoland to push it. Lack of Level 3 access maybe?

The patch has my r+. Any of the Sheriffs, what can we do to get that landed?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Get someone with Level 3 commit access to r+ it in MozReview.

Comment 7

[Christoph Kerschbaumer [:ckerschb}]

Comment on attachment 8858758 [details]
Bug 1356522 - Remove unnecessary nsICryptoHash output CRLF filtering in nsCSPUtils.cpp.

https://reviewboard.mozilla.org/r/130796/#review134300

Comment 8

[:Cykesiopka]

Hmm, could the patch get landed to m-i instead then?

ckerschb is module owner of code under dom/security/ (see https://wiki.mozilla.org/Modules/All#Content_Security), so there's really no one more appropriate to give r+.

Thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1d7ee18b7d0
Remove unnecessary nsICryptoHash output CRLF filtering in nsCSPUtils.cpp. r=ckerschb

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c1d7ee18b7d0