1356531 - Remove moz_places_faviconindex

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P3)

Description

[Marco Bonardo [:mak]]

this index is no more needed, we can remove it.

Comment 1

[Marco Bonardo [:mak]]

also moz_favicons, but we must wait version 57 for both.

Comment 2

[Marco Bonardo [:mak]]

This cleanup should be trivial.

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1356531 - Remove moz_places_faviconindex and old Places migrations.

Review commit: https://reviewboard.mozilla.org/r/191772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/191772/

Comment 4

[:Paolo Amadini]

Comment on attachment 8920783 [details]
Bug 1356531 - Remove moz_places_faviconindex and old Places migrations.

https://reviewboard.mozilla.org/r/191772/#review196986

Yep, quite straightforward.

::: toolkit/components/places/tests/migration/test_current_from_v36.js:48
(Diff revision 1)
>                               WHERE fixed_icon_url_hash = hash(fixup_url(:icon_url))
>                                 AND icon_url = :icon_url
>                              `, { icon_url: entry.icon_url });

nit: might want to re-indent

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8920783 [details]
Bug 1356531 - Remove moz_places_faviconindex and old Places migrations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/191772/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89bfafd51a2c
Remove moz_places_faviconindex and old Places migrations. r=Paolo

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/89bfafd51a2c