Closed Bug 1356531 Opened 4 years ago Closed 4 years ago

Remove moz_places_faviconindex

Categories

(Toolkit :: Places, enhancement, P3)

Product:
Toolkit
Component:
Places
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox55 --- affected
firefox58 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1356531 - Remove moz_places_faviconindex and old Places migrations.
59 bytes, text/x-review-board-request
Paolo
: review+
Details 
this index is no more needed, we can remove it.
also moz_favicons, but we must wait version 57 for both.
This cleanup should be trivial.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Depends on: 1410457
Comment on attachment 8920783 [details]
Bug 1356531 - Remove moz_places_faviconindex and old Places migrations.

https://reviewboard.mozilla.org/r/191772/#review196986

Yep, quite straightforward.

::: toolkit/components/places/tests/migration/test_current_from_v36.js:48
(Diff revision 1)
>                               WHERE fixed_icon_url_hash = hash(fixup_url(:icon_url))
>                                 AND icon_url = :icon_url
>                              `, { icon_url: entry.icon_url });

nit: might want to re-indent
Attachment #8920783 - Flags: review?(paolo.mozmail) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/89bfafd51a2c
Remove moz_places_faviconindex and old Places migrations. r=Paolo
https://hg.mozilla.org/mozilla-central/rev/89bfafd51a2c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.