Closed Bug 1356537 Opened 3 years ago Closed 3 years ago

Revert the device reset check in EndFrame

Categories

(Core :: Graphics, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kechen, Assigned: kechen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The device reset check in EndFrame was to prevent the program from crashes caused by swapchain->present; however, we already have another check in BeginFrame which might be enough and also it causes some performance issues in Bug 1355416. Therefore, it might be advisable to remove the check here.

I will keep monitoring if there are any new crashes after this change.

[1] https://dxr.mozilla.org/mozilla-central/rev/f40e24f40b4c4556944c762d4764eace261297f5/gfx/layers/d3d11/CompositorD3D11.cpp#1433
Blocks: 1355416
Comment on attachment 8858265 [details]
Bug 1356537 - Revert device reset check in EndFrame;

https://reviewboard.mozilla.org/r/130248/#review134664

Sounds good, we should keep an eye to see if the original bug this check fixed re-appears. If so we can relegate it to the GPU process.
Attachment #8858265 - Flags: review?(dvander) → review+
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e5f7c3e9f1b9
Revert device reset check in EndFrame; r=dvander
https://hg.mozilla.org/mozilla-central/rev/e5f7c3e9f1b9
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.