59 bytes, text/x-review-board-request
The device reset check in EndFrame was to prevent the program from crashes caused by swapchain->present; however, we already have another check in BeginFrame which might be enough and also it causes some performance issues in Bug 1355416. Therefore, it might be advisable to remove the check here. I will keep monitoring if there are any new crashes after this change.  https://dxr.mozilla.org/mozilla-central/rev/f40e24f40b4c4556944c762d4764eace261297f5/gfx/layers/d3d11/CompositorD3D11.cpp#1433
Comment on attachment 8858265 [details] Bug 1356537 - Revert device reset check in EndFrame; https://reviewboard.mozilla.org/r/130248/#review134664 Sounds good, we should keep an eye to see if the original bug this check fixed re-appears. If so we can relegate it to the GPU process.
Attachment #8858265 - Flags: review?(dvander) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/e5f7c3e9f1b9 Revert device reset check in EndFrame; r=dvander
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.