1356583 - Crash in mozilla::MediaCache::Truncate

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: Playback, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-1b3052ac-066c-4b60-bd3e-a58ec2170411.
=============================================================

Seen while looking at Mac specific nightly crashes - crashes started using 20170411030208 build: http://bit.ly/2pB1yBI

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=731639fccc709a4dd95fed7e9dda88efb2227906&tochange=f914d40a48009c5acd1093e9939cc0ec035696dd

Bug 1350436 is in the range - ni on :billm

Comment 1

[Andrew McCreight [:mccr8]]

JW, could bug 1194891 have caused this? It looks like that landed a day before the first Nightly crash, but the crash volume is low enough (0 to 2 crashes per build) that it may just not have happened at first.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

It's very unlikely my patches caused this crash.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

We had https://crash-stats.mozilla.com/report/index/601de791-1200-413c-88e4-d5a2f2170315 on 45.8.0esr which also crashed at |if (entry->mNextBlock == aBlock) {|.

I think the bug is already there long ago. It is just that bug 1194891 makes it more likely to happen.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Btw, the code added by bug 1194891 is only useful when closing a private window. Is there any way to know from the crash report if private browsing is on?

Comment 5

[Marcia Knous [:marcia]]

(In reply to JW Wang [:jwwang] [:jw_wang] from comment #4)
> Btw, the code added by bug 1194891 is only useful when closing a private
> window. Is there any way to know from the crash report if private browsing
> is on?

Not that I know of, but I can check Monday with someone in the Breakpad team.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Now I am quite sure the crash is not caused by bug 1194891.

https://crash-stats.mozilla.com/report/index/645871d9-9b6e-4cb2-a6ec-e671b0170414
The Process Type is content which somehow won't notify "last-pb-context-exited" and will not run the code added by bug bug 1194891.

Comment 7

[Tzuhao Kuo [:kaku]]

According to the crash report, crashes stopped since FF55.0a1 (build id: 20170418030220). No crashes in the past 2 months. 
So, I think we can close this bug. :blake, WDYT?

Comment 8

[Blake Wu [:bwu][:blakewu]]

Great! Let's close it.

Comment 9

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is a P1 bug without an assignee. 

P1 are bugs which are being worked on for the current release cycle/iteration/sprint. 

If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.

Comment 10

[Bulk Bug Changes for mreavy's org]

Mass change P1->P2 to align with new Mozilla triage process

Comment 11

[Blake Wu [:bwu][:blakewu]]

No crashes found since 56, so close this bug.