Fix a few minor style issues in the XPConnect loader directory

RESOLVED FIXED in Firefox 55

Status

()

Core
XPConnect
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

Comment hidden (empty)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 5

8 months ago
This fixups are mostly taken from Bill's patch in bug 1186409.

Comment 6

8 months ago
mozreview-review
Comment on attachment 8858396 [details]
Bug 1356666, part 1 - Rename target_obj to targetObj in mozJSSubscriptLoader.

https://reviewboard.mozilla.org/r/130340/#review133072
Attachment #8858396 - Flags: review?(mrbkap) → review+

Comment 7

8 months ago
mozreview-review
Comment on attachment 8858397 [details]
Bug 1356666, part 2 - Fix some style issues in mozJSSubScriptLoader.

https://reviewboard.mozilla.org/r/130342/#review133074
Attachment #8858397 - Flags: review?(mrbkap) → review+

Comment 8

8 months ago
mozreview-review
Comment on attachment 8858409 [details]
Bug 1356666, part 3 - Mark some functions in mozJSSubscriptLoader static.

https://reviewboard.mozilla.org/r/130372/#review133076
Attachment #8858409 - Flags: review?(mrbkap) → review+

Comment 9

8 months ago
mozreview-review
Comment on attachment 8858410 [details]
Bug 1356666, part 4 - Use handles as arguments in mozJSSubscriptLoader.

https://reviewboard.mozilla.org/r/130374/#review133078
Attachment #8858410 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 10

8 months ago
Thanks for the fast reviews.

Comment 11

8 months ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9d502ba5b19
part 1 - Rename target_obj to targetObj in mozJSSubscriptLoader. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/f0ecc19eeda1
part 2 - Fix some style issues in mozJSSubScriptLoader. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/836c55d3e1ff
part 3 - Mark some functions in mozJSSubscriptLoader static. r=mrbkap
https://hg.mozilla.org/integration/autoland/rev/05474bd27af4
part 4 - Use handles as arguments in mozJSSubscriptLoader. r=mrbkap
(Assignee)

Updated

8 months ago
Blocks: 1356799
https://hg.mozilla.org/mozilla-central/rev/e9d502ba5b19
https://hg.mozilla.org/mozilla-central/rev/f0ecc19eeda1
https://hg.mozilla.org/mozilla-central/rev/836c55d3e1ff
https://hg.mozilla.org/mozilla-central/rev/05474bd27af4
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.