Closed Bug 1356675 Opened 3 years ago Closed 2 years ago

Non-admin user doesn't get notification for update failure

Categories

(Toolkit :: Application Update, defect, P1, blocker)

55 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kkumari, Assigned: dthayer)

References

Details

Attachments

(1 file)

Non-admin user doesn't get notification for update failure

Pre-requisite:
Firefox nightly is installed into a location that requires elevation such as C:\Program Files\Nightly\ or C:\Program Files\Nightly (x86)\ which are the defaults, that the system has UAC enabled which is the default, and the Windows account must be a member of Users and not a member of the Adminstrators group which is not the default.


On windows 10 with UAC enabled
----------------------------------------------
STR:
1. Install a nightly build (Fx55)that contains the patches for bug 893505 and has an update
2. Launch Firefox
3. Open about:config and 
   Change app.update.badgeWaitTime to 10
   Change app.update.lastUpdateTime.background-update-timer to 1
   Change app.update.promptWaitTime to 30
   Change app.update.service.enabled to false
   Change app.update.timerMinimumDelay to 10
4. Exit Firefox
5. Launch Firefox

Expected: In approximately a minute or two the hamburger menu badge should be displayed. In approximately 20 more seconds the doorhanger ui should be displayed with "Nightly can't update to the latest version"

Actual: There is no hamburger menu badge and doorhanger ui

On windows 7 with UAC enabled
----------------------------------------------
1. Launch Firefox
2. Open about:config and 
   Change app.update.badgeWaitTime to 10
   Change app.update.lastUpdateTime.background-update-timer to 1
   Change app.update.promptWaitTime to 30
   Change app.update.service.enabled to false
   Change app.update.timerMinimumDelay to 10
3. Exit Firefox
4. Launch Firefox
5. In approximately a minute or two the hamburger menu badge is displayed
6. In approximately 20 more seconds the doorhanger ui is displayed with "Restore & Restart" and "Not Now" options.
7. Select Restore and Restart
8. Windows 7 displays UAC window and waits for credentials
9. Enter non-admin's credentials (not the administrators)
10. Wait for Firefox to start
11. Wait 2-3 minutes for hamburger menu badge and doorhanger UI with notification


Expected: In approximately a minute or two the hamburger menu badge should be displayed. In approximately 20 more seconds the doorhanger ui should be displayed with "Nightly can't update to the latest version" message

Actual: There is no hamburger menu badge and doorhanger ui notification. On restarting Firefox again, hamburger menu badge and doorhanger ui appears but with same "Restore & Restart" and "Not Now" options.
Blocks: 893505
Severity: normal → blocker
Priority: -- → P1
The above patch should fix the STR on Windows 10, but regarding the Windows 7 steps, I believe this is just a consequence of this: https://bugzilla.mozilla.org/show_bug.cgi?id=893505#c150. rstrong, is this still how we want it to behave, or should we be showing the manual update notification after the first elevation failure?
Flags: needinfo?(robert.strong.bugs)
Comment on attachment 8864580 [details]
Bug 1356675 - Show manual update on cant-apply status

https://reviewboard.mozilla.org/r/136260/#review140382

Looks good but this can have a test for Windows. See the following for an example
https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/update/tests/chrome/test_0172_notify_noPerms_manual.xul
Attachment #8864580 - Flags: review?(robert.strong.bugs) → review-
Comment on attachment 8864580 [details]
Bug 1356675 - Show manual update on cant-apply status

https://reviewboard.mozilla.org/r/136260/#review140748
Attachment #8864580 - Flags: review?(robert.strong.bugs) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8dcfb6dd8393
Show manual update on cant-apply status r=rstrong
https://hg.mozilla.org/mozilla-central/rev/8dcfb6dd8393
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
I'll go through the different scenarios after this makes it to a nightly build so I can test those cases with that build
Flags: needinfo?(robert.strong.bugs)
I had a chance to check the no write access without UAC scenario and that worked as expected.

I'll go through the no write access with UAC hopefully Monday.
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #9)
> I had a chance to check the no write access without UAC scenario and that
> worked as expected.
I meant to say, I had a chance to check the no write access without being a member of the Administrators group scenario and that worked as expected.
I tested this bug fix on Windows 7 & 10 and found it to be working fine. On both platform non-admin user is getting door hanger ui with 'Nightly can't update to the latest version, download fresh copy of nightly' message.
Status: RESOLVED → VERIFIED
Reopening this bug as it is reproducible on OSX 10.12 with Beta builds.

Steps to Reproduce:
1. Install a Firefox 55.0b1 as admin user
2. Switch to non-admin (standard) user and run the installed Firefox build installed in step 1.
3. Go to about:config and change following prefs:
app.update.badgeWaitTime to 10
app.update.lastUpdateTime.background-update-timer to 1
app.update.promptWaitTime to 30
app.update.timerMinimumDelay to 10
4. Exit Firefox
5. Launch same Firefox build with same profile 
6. Verify hamburger menu badge and doorhanger


Actual Result:
No update badge or door-hanger menu appear. Firefox does not even update from the menu, about-Firefox.

Expected Result:

Firefox should display the update badge and then the door-hanger.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Abe, please open a new bug. Thanks!
Status: REOPENED → RESOLVED
Closed: 3 years ago2 years ago
Flags: needinfo?(amasresha)
Resolution: --- → FIXED
Bug 1382706 is created for the issue in the comment 12.

Updating this bug back to its previous status (verified-fixed).
Status: RESOLVED → VERIFIED
Flags: needinfo?(amasresha)
Assignee: nobody → dothayer
You need to log in before you can comment on or make changes to this bug.