Closed Bug 1356691 Opened 3 years ago Closed 3 years ago

Make DeadObjectProxies preserve IsCallable and IsConstructor statically instead of an extra slot

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: shu, Assigned: shu)

References

Details

Attachments

(1 file, 1 obsolete file)

Spun off from bug 1354294.
See Also: → 1354294
Attachment #8858423 - Flags: review?(wmccloskey) → review+
Hmm, this is causing a RecomputeWrappers assertion in try here: https://treeherder.mozilla.org/logviewer.html#?job_id=91779950&repo=try&lineNumber=2690
Summary: Make DeadObjectProxies always IsCallable and IsConstructor instead preserving the old targets' values → Make DeadObjectProxies preserve IsCallable and IsConstructor statically instead of an extra slot
Decided to not investigate test failure from comment 3 and still preserve
IsCallable and IsConstructor, just via templates this time.
Attachment #8858998 - Flags: review?(wmccloskey)
Attachment #8858423 - Attachment is obsolete: true
Attachment #8858998 - Flags: review?(wmccloskey) → review+
Pushed by shu@rfrn.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67bf37b2c974
Preserve DeadObjectProxy's IsCallable and IsConstructor values statically with templates. (r=billm)
https://hg.mozilla.org/mozilla-central/rev/67bf37b2c974
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Mark 54 won't fix as this is late for Beta54.
You need to log in before you can comment on or make changes to this bug.