Make DeadObjectProxies preserve IsCallable and IsConstructor statically instead of an extra slot

RESOLVED FIXED in Firefox 55

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: shu, Assigned: shu)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 wontfix, firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 months ago
Spun off from bug 1354294.
(Assignee)

Updated

6 months ago
See Also: → bug 1354294
(Assignee)

Comment 1

6 months ago
Created attachment 8858423 [details] [diff] [review]
Make DeadObjectProxies always IsConstructor and IsCallable to save on extra slot write barrier.
Attachment #8858423 - Flags: review?(wmccloskey)
Thanks :)
Assignee: nobody → shu
status-firefox52: --- → unaffected
status-firefox53: --- → unaffected
status-firefox54: --- → affected
status-firefox55: --- → affected
status-firefox-esr52: --- → unaffected

Updated

6 months ago
Attachment #8858423 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 3

6 months ago
Hmm, this is causing a RecomputeWrappers assertion in try here: https://treeherder.mozilla.org/logviewer.html#?job_id=91779950&repo=try&lineNumber=2690
(Assignee)

Updated

6 months ago
Summary: Make DeadObjectProxies always IsCallable and IsConstructor instead preserving the old targets' values → Make DeadObjectProxies preserve IsCallable and IsConstructor statically instead of an extra slot
(Assignee)

Comment 4

6 months ago
Created attachment 8858998 [details] [diff] [review]
Preserve DeadObjectProxy's IsCallable and IsConstructor values statically with templates.

Decided to not investigate test failure from comment 3 and still preserve
IsCallable and IsConstructor, just via templates this time.
Attachment #8858998 - Flags: review?(wmccloskey)
(Assignee)

Updated

6 months ago
Attachment #8858423 - Attachment is obsolete: true

Updated

6 months ago
Attachment #8858998 - Flags: review?(wmccloskey) → review+

Comment 5

6 months ago
Pushed by shu@rfrn.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67bf37b2c974
Preserve DeadObjectProxy's IsCallable and IsConstructor values statically with templates. (r=billm)

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/67bf37b2c974
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Mark 54 won't fix as this is late for Beta54.
status-firefox54: affected → wontfix
You need to log in before you can comment on or make changes to this bug.