1356691 - Make DeadObjectProxies preserve IsCallable and IsConstructor statically instead of an extra slot

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Shu-yu Guo [:shu]]

Spun off from bug 1354294.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Make DeadObjectProxies always IsConstructor and IsCallable to save on extra slot write barrier.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Thanks :)

Comment 3

[Shu-yu Guo [:shu]]

Hmm, this is causing a RecomputeWrappers assertion in try here: https://treeherder.mozilla.org/logviewer.html#?job_id=91779950&repo=try&lineNumber=2690

Comment 4

[Shu-yu Guo [:shu]]

Attachment: Preserve DeadObjectProxy's IsCallable and IsConstructor values statically with templates.

Decided to not investigate test failure from comment 3 and still preserve
IsCallable and IsConstructor, just via templates this time.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67bf37b2c974
Preserve DeadObjectProxy's IsCallable and IsConstructor values statically with templates. (r=billm)

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/67bf37b2c974

Comment 7

[Gerry Chang [:gchang]]

Mark 54 won't fix as this is late for Beta54.