1356853 - Crash in [@ shutdownhang | NtQueryAttributesFile]. CacheFileIOManager because SyncRemoveAllCacheFiles takes too long to Clear Cache on Shutdown for users with clear cache history on close

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect, P2)

Description

[(no longer active)]

This bug was filed from the Socorro interface and is 
report bp-ce0dc121-87a7-4b43-83c6-7eed72170416.
=============================================================

Currently number #21 topcrash on release.

Looks like CacheFileIOManager::SyncRemoveAllCacheFiles() takes too long to finish presumably because it does IO?

Comment 1

[Michal Novotny [:michal]]

(In reply to :Ehsan Akhgari (super long backlog, slow to respond) from comment #0)
> Looks like CacheFileIOManager::SyncRemoveAllCacheFiles() takes too long to
> finish presumably because it does IO?

It removes the whole cache, so it can take some time. It is called only when user choose to clear the cache when firefox closes. There is no way to speed this up. Maybe we should disable shutdown watchdog during this call if it is possible...

Comment 2

[Patrick McManus [:mcmanus]]

we should probably see what we can do about the watchdog.. I agree that just aborting is not going to work because the user is trading privacy for time on purpose.. the watchdog is actually creating a privacy problem by not cleaning up the data.

jason might be able to get someone else to take the bug if you ask him..

Comment 3

[Michal Novotny [:michal]]

Jason, could you please find someone to take a look at possibility to temporarily disable watchdog? It needs to be disabled here http://searchfox.org/mozilla-central/rev/9a7fbdee1d54f99cd548af95b81231d80e5f9ad1/netwerk/cache2/CacheFileIOManager.cpp#1205

Comment 4

[Marcia Knous [:marcia]]

This is the now the top crash on nightly, even though it only has 25 installs. I noticed a few other signatures have moved up, presumably related, such as [@ shutdownhang | NtOpenFile] which as CacheFileIOManager in the signature.

Comment 5

[[:philipp]]

marcia i think it's a single user creating havoc in yesterday's nightly crash data: https://crash-stats.mozilla.com/search/?install_time=1494594635&product=Firefox#facet-signature

Comment 6

[Michal Novotny [:michal]]

Marcia, why did you clear needinfo for Jason? I won't be able to work on this anytime soon so my question in comment #3 is still valid.

Comment 7

[Marcia Knous [:marcia]]

(In reply to Michal Novotny (:michal) from comment #6)
> Marcia, why did you clear needinfo for Jason? I won't be able to work on
> this anytime soon so my question in comment #3 is still valid.

Michal: philipp indicated in Comment 5 that these crashes are all coming from a single user on Desktop - I can re-add the ni if you think it is warranted.

Comment 8

[Michal Novotny [:michal]]

In this case this is not a topcrash, but we should still fix it.

Comment 9

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 10

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 11

[Sushant]

Is this bug NEVER going to be fixed? Looks like the people concerned have simply abandoned it. What, it's not high priority enough to merit any attention? Meanwhile users are getting ever more frustrated due to it and I'm at least seriously considering abandoning the browser for one that works and whose devs don't just ignore user complaints (especially when it comes to app crashes).

I've set FF to clear the cache on exit and after a lengthy browsing session when I exit the browser it ALWAYS crashes and irritates me about submitting a bug report. I've grown tired of doing that. What's the use anyway if the reports will simply be ignored?

Honestly I'm at the end of my tether here. A few more crashes (including no doubt one when I close the browser now) and I'm done. Thank you FF for being a decent browser back in the day. It was good while it lasted. Cheers!

Comment 12

[Michal Novotny [:michal]]

(In reply to Sushant from comment #11)
> I've set FF to clear the cache on exit and after a lengthy browsing session
> when I exit the browser it ALWAYS crashes and irritates me about submitting
> a bug report. I've grown tired of doing that. What's the use anyway if the
> reports will simply be ignored?

My recommendation is to turn off this option. If the disk is too slow and it takes too much time to clear the cache, it doesn't work anyway because some cache entries are left on the disk after the crash.

Comment 13

[Sushant]

Sorry to say that's the obvious, lazy response. Why have the option in the first place then? Shouldn't FF be smarter about this? Slow disks (or even disks temporarily slowed down because they're already busy with other requests) should be handled appropriately, instead of a simple blind assessment that if N secs. have passed and the clean-up process hasn't completed, FF must have crashed.

Comment 14

[Trevor Skywalker]

Firefox 52.5.2esr Crash Report [@ shutdownhang | NtQueryAttributesFile ]
ID: 3d6aa2f8-e6d3-4057-8cf2-9007d0171229

MOZ_CRASH Reason 	MOZ_CRASH(Shutdown too long, probably frozen, causing a crash.)
Crash Reason 	EXCEPTION_BREAKPOINT
Crash Address 	0x59cb94cf
User Comments 	
Total Virtual Memory 	4,294,836,224 bytes (4.29 GB)
Available Virtual Memory 	3,527,999,488 bytes (3.53 GB)
Available Page File 	5,444,775,936 bytes (5.44 GB)
Available Physical Memory 	2,334,203,904 bytes (2.33 GB)
System Memory Use Percentage 	42 

Crashing Thread (0)
Frame 	Module 	Signature 	Source
0 	ntdll.dll 	NtQueryAttributesFile 	
1 	kernelbase.dll 	GetFileAttributesW 	
2 	xul.dll 	nsLocalFile::HasFileAttribute(unsigned long, bool*) 	xpcom/io/nsLocalFileWin.cpp:3132
3 	xul.dll 	nsLocalFile::Remove(bool) 	xpcom/io/nsLocalFileWin.cpp:2420
4 	xul.dll 	nsLocalFile::Remove(bool) 	xpcom/io/nsLocalFileWin.cpp:2441
5 	xul.dll 	mozilla::net::CacheFileIOManager::SyncRemoveDir(nsIFile*, char const*) 	netwerk/cache2/CacheFileIOManager.cpp:3997
...
18 	firefox.exe 	__scrt_common_main_seh 	f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:253
19 	kernel32.dll 	BaseThreadInitThunk 	
20 	ntdll.dll 	__RtlUserThreadStart 	
21 	ntdll.dll 	_RtlUserThreadStart

Comment 16

[Trevor Skywalker]

(In reply to Marcia Knous [:marcia - needinfo? me] from comment #7)
> 
> Michal: philipp indicated in Comment 5 that these crashes are all coming
> from a single user on Desktop - I can re-add the ni if you think it is
> warranted.

These crashes are NOT all coming from a single user on Desktop.


Signature report for shutdownhang | NtQueryAttributesFile
Showing results from 3 months ago

Windows 10 	15247 	55.7%
Windows 7 	9153 	33.4%
Windows 8.1 	2028 	7.4%
Windows Vista 	583 	2.1%
Windows XP 	177 	0.6%
Windows 8 	175 	0.6%
Windows Server 2003 	5 	0.0%

Firefox 	59.0.1 	1136 	42.2% 	748
Firefox 	59.0.2 	594 	22.1% 	518
Firefox 	52.7.2esr 	187 	6.9% 	170
Firefox 	58.0.2 	102 	3.8% 	134
Firefox 	52.7.3esr 	101 	3.8% 	81
Firefox 	60.0b6 	68 	2.5% 	68
Firefox 	52.6.0esr 	61 	2.3% 	46

Firefox 	61.0a1 	19 	0.7% 	16
Firefox 	60.0b6 	68 	2.5% 	68
Firefox 	60.0b7 	36 	1.3% 	23
Firefox 	60.0b5 	24 	0.9% 	21
Firefox 	60.0b4 	5 	0.2% 	6
Firefox 	59.0.1 	1136 	42.2% 	748
Firefox 	59.0.2 	594 	22.1% 	518
Firefox 	59.0 	18 	0.7% 	21
Firefox 	59.0b99 	4 	0.1% 	2
Firefox 	58.0.2 	102 	3.8% 	134

Uptime
> 1 hour 	21617 	79.0%
1-5 min 	2718 	9.9%
15-60 min 	2097 	7.7%
5-15 min 	933 	3.4%
< 1 min 	3 	0.0%

Architecture
amd64 	16665 	60.9%
x86 	10703 	39.1%

Comment 17

[Trevor Skywalker]

The user comments on these crash reports reflect a negative user experience that is so bad that for some people they are abandoning the Firefox platform completely and are switching to a different browser.

Could this bug be given a higher priority?

This crash signature occurs 200-400 times a day (over the past 3 months).

https://crash-stats.mozilla.com/signature/?signature=shutdownhang%20%7C%20NtQueryAttributesFile&date=%3E%3D2017-12-30T16%3A11%3A40.000Z&date=%3C2018-03-30T17%3A11%3A40.000Z#comments

Signature report for shutdownhang | NtQueryAttributesFile
Showing results from 3 months ago to 5 hours ago.

673 Results … ← Prev 1 2 3 4 5 6 … 12 13 14 Next → 

9451128b-edda-49f7-a5f7-b89870180330 	I only closed Firefox. It's not Mozilla or Firefox's Problem. This Crash Reporter just popped up so I wrote this. There is no need to do anything. I love Firefox!!! My favourite browser!!! Cheers Mozilla!!!!!! 	2018-03-30 07:42:34 	en-US
32e8c2d6-d68d-40c2-8263-28e670180329 	Wht is the happening over and over? 	2018-03-29 22:44:24 	en-US
6805d275-ecb6-4e07-9a5c-ce3b20180329 	Happens all the time and is the main reason that I keep using Google browser even though I hate Google. Please stabalize your browser so I can go back to playing and browsing on it. 	2018-03-29 21:40:08 	en-US 
aacaa6e1-5b06-420c-bab3-168e70180329 	just quit went back to desk top, was on aol mail 	2018-03-29 15:12:57 	en-US
0af940f5-e058-472c-bd09-3b7ba0180329 	as always... happy easter... :( 	2018-03-29 15:00:01 	hu 
5fe985e5-95b4-47af-9aee-4a3c60180328 	hit update, and it crashed my Microsoft WORD - LOST IMPORTAND DOCs! Lost important Excell spreadsheets! and it crashed Internet Explorer too! Not to mention it stopped me for doing something financial before eod !!!! Which could cost me a LOT OF MONEY!!!! 	2018-03-28 19:59:13 	en-US
91a62762-9cae-4e9c-943b-94cc00180328 	I am having a ton of trouble with Firefox freezing up and crashing on me. Chrome did it before I switched to Firefox, so guess it's my PC? 	2018-03-28 05:12:29 	en-US 
9b96d4f8-259e-41aa-b518-fc82a0180327 	Crashing everyday several times a day - UGH!!! 	2018-03-27 16:50:14 	en-US
dd901650-1db0-451a-b6d4-ef4990180327 	It didn't crash. I turned it off (that is, I "X'd" out of it. About half the time when I X out of it, it seems to THINK it crashed, and it gives me this message. I'm not sure what site I was on just before I Xd out. 	2018-03-27 16:36:33 	en-US
799f86d4-79c4-43ee-afea-d70b50180327 	how would you like to smarten your act up 	2018-03-27 16:10:52 	en-GB
9a94c2bd-5ec4-49e8-ac14-8aa600180327 	Firefox is suck. Fucking stubid software, crash, crash and crash... 	2018-03-27 15:46:20 	fi 
ba051089-798d-4a1c-8dc1-18e2d0180326 	This has been happening a lot lately Is there anything I can do? Please send answer to [e-mail] and thank you in advance for any help you can recommend. 	2018-03-26 02:07:25 	en-US
1a4202fa-d35f-4200-9e15-efacb0180325 	the worst thing is, when I tell you to quit, you don't quit but piss around for 5 minutes, finally getting down to 2 processes, then crash 	2018-03-25 18:36:42 	en-US
142e8d01-ff9a-4d93-88c2-3f7410180325 	Firefox has been running very slowly today and has crashed more than once. And msn outlook email has been running even more slowly 	2018-03-25 18:13:21 	en-US
84f055ac-a59e-4c74-9e21-8c8500180325 	exit firefox. crashed again. 	2018-03-25 17:16:44 	en-US 
3a16e3fb-98f7-4e09-949e-0d2220180324 	FIX YOUR CRASHES 	2018-03-24 22:29:41 	en-US
27cd18d9-b293-4326-b8dd-6e7200180324 	very time i left mozillia firefox running with many tabs opened it lets my notebbo super slow and when i try to close it by clicking de close button upper right corner it crashs. since this is beggining i have choosed to use OPERA and it surprises me! 	2018-03-24 19:24:15 	pt-BR 
9db5b96e-45dd-447e-95b9-ed3050180323 	constant crashing lately, so unreliable. going back to IE 	2018-03-23 23:16:37 	en-US
dae312f6-21e7-4a7d-b287-542e40180323 	FIREFOX SUCKS!!!!! 	2018-03-23 21:57:52 	en-US 
ff591832-2778-42a2-b741-577a60180322 	it crashed all by itself 	2018-03-22 16:37:04 	en-US
9739fec8-3287-463e-88a9-e8e230180322 	tired of the crashes please fix it! 	2018-03-22 10:41:41 	en-US
d1ef2503-d3a9-4c64-8e98-a23740180322 	oh for god's sake -- why does this keep happening every time I shut the #&*$@&$&@ browser down !!!!!! 	2018-03-22 04:53:09 	en-US
a3fdb67b-5fd0-4f71-a937-72eaa0180322 	trying to install an upgrade. Crashes ecery time! 	2018-03-22 02:24:45 	en-US
c3cde7e3-7038-455a-b79c-1d9410180321 	Just curious. Does Firefox crash at once every day for other users too? P.S. This includes "crash" on close. 	2018-03-21 15:41:08 	en-US
54efbbb0-750f-4a3d-b00b-f940e0180321 	Just shutting it down with two instances. 	2018-03-21 14:33:00 	en-US 
8f960bf9-304f-46b0-bbd9-260e80180321 	damn how could that happen 	2018-03-21 00:59:54 	en-US
260124a6-6703-462e-a33f-2e4550180320 	happens many times a day web page slowing down your browser- stop or wait? soon need to change browsser if this contines 	2018-03-20 17:24:01 	en-US
5f908fa5-80f1-4f71-9956-7469c0180320 	The programs bogged down -seems like it happens after every Windows 10 upgrade. I am having to use FindAGrave.com on Edge (yuck!) because it keeps freezing up in Firefox. 	2018-03-20 16:48:27 	en-US
c06ecd18-74a7-4a32-8054-7b23b0180320 	pc just came out of sleep mode. Win 10 OP 	2018-03-20 15:18:00 	en-US
675700de-f229-478f-b3f7-9e5670180319 	Faux positif ! 	2018-03-19 19:50:11 	fr
d7ecdb4f-95f0-4f72-978b-dbf110180319 	Was updating the browser 	2018-03-19 18:09:48 	en-US
2dc9b3ec-4fbe-46e0-bb43-dbcb70180319 	FIREFOX SUCKS!!!!!! 	2018-03-19 14:58:35 	en-US
cb86021b-a39f-44b3-be65-68dc30180319 	This is Really Crap!!! 	2018-03-19 07:21:24 	en-US
282cf825-280c-43fb-b349-cd5d60180319 	6 x running not responding!!!! 	2018-03-19 02:15:47 	en-US
af54c40c-ee33-4059-b24b-afad40180319 	Every time I request a simple shtdown of FireFix (i.e. either using the 'X' or closing the last window), I get a message about a 'crash'. Why??? 	2018-03-19 01:55:35 	en-US
fe00a2f5-4ba0-456e-8392-d637a0180318 	This happens several times a week. 	2018-03-18 23:23:24 	en-US 
9b11ff57-90c7-4931-b567-1011d0180318 	I didn't even realize it had crashed till the message popped up on the screen that it crashed. 	2018-03-18 21:03:44 	en-US 
e6e0b83d-6fb3-4600-8946-ea6c40180316 	Attempted to close out Fox Fire 6 times, and it did not respond!!!!!!! 	2018-03-16 21:03:06 	en-US
13d8a934-8e64-47a0-a3f1-eddc40180316 	Always crashes at ebaumsworld.com 	2018-03-16 20:28:09 	en-US
e6a0e317-f54b-4fce-88a5-cb1f90180316 	Crashes several times a day while using Words With Friends on Facebook. It's gotten to the point where I can't even use Firefox. Started about 6 weeks ago and gets worse by the day :( 	2018-03-16 19:10:54 	en-US
155bd770-98a7-40e1-b7b1-58cdb0180316 	Have had a lot of problems with Firefox recently. There are long delays before it does anything, including showing what I type. 	2018-03-16 15:27:00 	en-US 
6ad4c586-7ab2-4b8f-8afc-ad6de0180316 	something is running in the background making firefox (and other browsers) unresponsive. Happens about once a week at start up. Start up is slow as well. Disk is very busy. Please advise as to what might be happening. ties up my computer for 10-15 minutes. 	2018-03-16 11:54:29 	en-US
9beda0b1-fcc6-4344-b96f-49c8c0180315 	For me this is a constant problem 	2018-03-15 21:26:05 	en-US
8b5787e3-f994-46dd-b63b-23bdf0180315 	memory usage grows indefinitely 	2018-03-15 18:26:49 	it
c34f284d-b9a9-4cfe-83e8-0702c0180315 	Crash, crash, crash 	2018-03-15 16:52:40 	en-US
612d03f4-3dbf-4b32-9ac8-43e460180315 	another crash 	2018-03-15 15:34:34 	en-US
25ccced9-7c26-4e19-86fe-3393d0180314 	100% disc usage for several minutes AGAIN! Had to force a close. 	2018-03-14 15:47:49 	en-GB
fbe74748-b93b-40ae-ab0a-676840180314 	Itry connecting to my gmail page but it can not load 	2018-03-14 07:52:37 	en-US
5f38edc3-3616-4dc9-86eb-1330f0180314 	All that the Firefox ever does is crash or hang!! 	2018-03-14 05:56:36 	en-US
28f0a9bc-ea55-480c-9f95-31ed60180314 	Restarting Nightly for update. 	2018-03-14 03:39:34 	en-US
2d9b3625-7450-4cb7-83b8-3e62a0180314 	I LITERALLY CLOSED THE PROGRAM CORRECTLY WTF. This keeps popping up. 	2018-03-14 02:10:19 	en-US
18abb24c-c0e0-4434-bd06-e2c820180313 	see previous crash reports 	2018-03-13 22:45:34 	en-US
94175909-d27f-490c-99ef-b88cc0180313 	fire fox crashes all the time POS 	2018-03-13 20:42:04 	en-US 
03ae8e9c-f0c7-4aa1-ab61-cce6d0180313 	came out of sleep mode. windows 10 	2018-03-13 17:03:54 	en-US
a212dc9e-2953-490d-9e5c-32f5e0180313 	I'm tired of your Firefox crashing and slowing down my laptop. I have no problem with my PC 	2018-03-13 15:47:09 	en-US
982b7ecb-f12e-41e9-aee6-de26e0180313 	not sure just would not open. use it to access emails 	2018-03-13 13:59:25 	en-US 
0d4d7547-0e5d-47e3-9f5a-3c2f60180313 	it seems this happens every day when I use this new updated version. Are you ever gonna get the bugs out! 	2018-03-13 04:11:47 	en-US
aacff7e9-f250-4371-b21f-baf4c0180313 	always crashes..... 	2018-03-13 01:36:21 	en-US 
2c60f27d-71a2-4e35-9af7-114f50180312 	Consumes massive amounts of memory (200-500MB) Constant "Not Responding" messages Always crashes on exit 	2018-03-12 20:09:27 	en-US
db41fcdc-f81f-4fab-8bd6-7c87a0180312 	Received this message. Had just turned on computer and this message came up. It actually happens often like couple of times a week lately 	2018-03-12 18:02:33 	en-US 
460910a9-2305-4e8a-b005-32d260180312 	Apparently Firefox crashed when I opened Internet Explorer. The Firefox window was minimized, and my desktop was showing at the time. I has AOL Mail open. 	2018-03-12 05:10:28 	en-US 
a4e282e5-6c95-44b0-93a4-bd53a0180311 	firefox seems to be taking up all available RAM, then crashes. 	2018-03-11 16:52:05 	en-US
280b3a34-a652-4f2e-beb3-147b50180311 	logged out of Facebook closed browser but i could tell it had not cleaned properly login name is always visable and i do not want that thank you 	2018-03-11 15:47:50 	en-US
8634ba93-d4fe-4154-9784-f22d70180310 	I was just closing Thunderbird. I didn't know it crashed until I saw the crash report. 	2018-03-10 22:33:53 	en-GB
e6ff8548-28cf-48fc-b73b-616f50180310 	I am uninstalling the new version is crap moving to chrome 	2018-03-10 22:06:12 	en-GB
ae565552-86a9-491f-a96b-fb9080180310 	Running too slow 	2018-03-10 21:15:46 	en-US 
f45e4472-84be-4e8a-982a-345af0180310 	Windows 10 seems to monitor Firefox & tag it as resource intensive...possible hindrance for those who do not choose Edge or IE?!? 	2018-03-10 16:11:15 	en-US
25a0cff0-308e-4131-a919-c0b620180310 	YAHOO ALWAYS CRASHES IT 	2018-03-10 16:03:13 	en-GB
192e5de4-2aa6-4f0f-90ac-525860180310 	keeps freezinn up and stopps rsponding. It is progressively getting worse and is gettting anoying. Im almost ready to change to a different browser due to this issue. please fix the issue. 	2018-03-10 00:35:18 	en-US
6983cbe8-5de9-4973-94ef-aa7410180309 	why is this doing this every time i close? 	2018-03-09 10:48:21 	en-US
6ce6dbc6-b68e-481b-a054-00dca0180309 	Sick of Firefox crashing 	2018-03-09 01:16:46 	en-US
719c5bed-4ff1-4bc7-bd64-e40b70180308 	There is a problem with this browser. It is running very slowy and keeps crashing 	2018-03-08 15:31:40 	en-US
16221b6f-fe49-45a7-8f12-cee730180308 	This stupid browser will not close without crashing! Don't you have developers that know what they are doing? 	2018-03-08 14:12:18 	en-US
bece0e3b-8a77-4822-85dd-ccb740180308 	Firefox is taking a combined 700+MB of memory just to operate one tab of gmail.... that's pretty obnoxicious. 	2018-03-08 10:08:34 	en-US
862b4ea7-9806-4525-9774-e27cb0180308 	I only see this box after I have quit Firefox and other full screen apps, if I crashed I didn't lose any windows or tabs that were opened. 	2018-03-08 04:51:13 	en-US 
55d0e75e-4f4b-4e5f-bbbc-8e0520180307 	So fucking done with this. At least once a day it hangs up my whole comp, and I work on my comp. Unacceptable. Whatever is going on can't just be me. Please fix!!!!! 	2018-03-07 16:27:43 	en-US 
e8cda6cf-b2e8-4a58-988c-d5c220180307 	CPU running away... again 	2018-03-07 05:28:44 	en-US
8f2cb2a7-bb58-4140-b677-3a7990180307 	I exited Firefox. This notice popped up a few seconds later. This has happened several times. 	2018-03-07 01:45:39 	en-US
83577529-9977-48ed-9b4e-000010180307 	I'm switching to Chrome. You guys crash too many times. 	2018-03-07 01:26:31 	en-US
7f726daa-7fe5-4459-83ba-939130180306 	it really sucks, i have being experiencing this crashing now every day!! just keeping loading and loading and then freezing and not respond 	2018-03-06 18:00:05 	es-ES
cdc10527-5f5a-4975-8bee-77ea50180306 	The current version of Firefox has a memory leak! If Firefox is left running, any webpage, the memory usage will build up. If left open overnight it will lockup Windows 10 due to lack of memory resources. This problem exists on multiple Windows 10 machines running current versions of Firefox. 	2018-03-06 16:36:11 	en-US 
a1b2a3cf-5a9f-4737-b71c-b2fa80180306 	If I leave a window open (any page) for a few minutes, mozilla stops responding 	2018-03-06 13:27:59 	en-US
d949572b-e97f-4195-964f-6643b0180306 	100% disc traffic by Firefox for several minutes before I gave up and closed it. This is happening every session, now. 	2018-03-06 08:26:41 	en-GB
46014426-c947-484c-ac7c-d135f0180306 	1. consumes massive amounts of ram (100-500MB) 2. On exit, constantly crashes 	2018-03-06 02:59:09 	en-US
f310f7a7-f7dd-43b7-b755-90a960180306 	This is becoming a frequent thing. Seems to be often on sites such as this one today (the hill.com). Makes me wonder if it has to do with opinions which aren't PC. Then again maybe i am just becoming a bit parinoid, lol. 	2018-03-06 02:57:40 	en-US
690fbaa6-e5da-45b3-8b10-a7e910180306 	Using a VPN 	2018-03-06 01:49:45 	en-US
70161a58-13d3-451f-a6ff-f45d40180305 	The usual crash a good amount of time after shutting down Firefox, after being on Facebook. Facebook also causes FIrefox to consume many Gigabytes of memory. 	2018-03-05 20:22:40 	en-US
9fc4dd6c-eaeb-4436-8760-9a28e0180305 	I'm afraid it has become very unstable of late. I think I will need to move to Chrome. 	2018-03-05 18:09:25 	en-GB
817c00d2-c520-48b1-8d52-45d630180305 	while playing farmville2 screen froze and then went to white screen has done this many times and have to shut down and reboot facebook and farmville 	2018-03-05 17:35:29 	en-GB
1e130153-9fc6-44d0-83fc-43fb50180305 	thunderbird not responding again 	2018-03-05 17:27:27 	en-US
5d3fac0f-94f1-49aa-b4ec-2114c0180305 	its disapoint and I hate Firefox now crashing when I open 2 or 3 tabs, and its worst, kinda of crazy hate, when opening any page with video 	2018-03-05 17:12:05 	es-ES
d2d2a73d-69f4-4fff-b90f-2fe750180305 	Mozilla SUCKS it crashes and when I get an update I have to replace all my folders I had created before the update. You should be putting out a better product than what you currently offer/ No way would and will I suggest to anyone to install such an inferior offering. Good luck with this product. 	2018-03-05 16:01:50 	en-US
61556d29-027a-4eb1-9a15-4b7190180305 	Ever since the upgrade last week the computer has slowed right down. I may have to revert to Google Chrome!! 	2018-03-05 14:04:17 	en-GB
389d8d1b-b9c6-4c75-b008-96df70180304 	Slow shutting down, and finally a crash, every time, after being on Facebook. I do use Facebook features, like chat, and watch video. Several (about half a dozen) instances of Firefox running in Task manager, using about 2 Gigabytes per instance, after closing Firefox, up to the crash. It takes a very long time for the instances to shut down after closing Firefox. 	2018-03-04 18:46:54 	en-US 
53f87c5c-c3ef-4fbc-8193-9b1000180304 	It crashs every month! 	2018-03-04 11:27:09 	en-US
654c1974-8e1c-4dbb-9464-b05ab0180304 	Facebook again... 	2018-03-04 07:46:52 	en-US
2ba156b0-bcdf-44c6-bacb-01fb00180304 	When I close down fire fox it will not close. I box comes up that says restart firefox or quit firefox. this just started a week ago 	2018-03-04 03:24:45 	en-US
59371c0c-778a-4b1c-b2ba-e5a850180303 	I can't even X this program out without it crashing and sucking up my memory. Fix it or scrap it would be my suggestion. 	2018-03-03 19:26:29 	en-US
b24010f1-47b6-4b37-a122-d52190180303 	Mozilla has been freezing up a lot. Then it crashed. 	2018-03-03 19:22:51 	en-US
42d668df-b058-44bc-b127-ef0c10180303 	Mozilla keeps getting all bogged down!! Then I have to shut completely down and use different browser 	2018-03-03 19:19:09 	en-US
ea8c8657-35ab-4b48-8cff-572840180303 	This crash, like several others, occurred after Firefox was closed, after being on Facebook. It seems to have multiple instances in memory after being on Facebook, which remain running for some time, and take up a couple Gig of memory. Other sites don't seem to do this. 	2018-03-03 19:16:57 	en-US 
9223d9a1-63df-4935-87b7-daf9f0180302 	I get this crash report , mostly , when I close the browser 	2018-03-02 18:57:39 	en-US 
87c4a948-8154-4d53-8d62-c72a50180301 	Firefox has become toxic on my Win10 system today, after using it for several years! 	2018-03-01 20:39:49 	en-US
c14b22db-a23a-46e4-bdd0-148690180301 	Excessive (100%) disc traffic for several minutes AGAIN/STILL!!!! before I gave up and closed. 	2018-03-01 10:45:43 	en-GB
5653850b-abc5-4ba7-a39d-e89990180301 	YOUR BROWSER FROZE WHILE I WAS VIEWING TIME MAGAZINE AND WAS FIRST TIME I'VE SEEN POPUPS ON THE BROWSER THAT FLASHED ON AND OFF. SOMETHING AKIN TO WHAT INTERNET EXPLORER DOES. MY REASON FOR USING FIREFOX. LOVE SCRIPTING BUT OUT OF HAND LATELY. 	2018-03-01 09:42:11 	en-US
e9201ba4-97d1-44c8-8fb1-671750180301 	Why is it everyday from 624 pm to 632 pm and 827 pm to 832 pm firefox fucks up everynight. Maybe firefox needs some new employees who know how to fix computer programs 	2018-03-01 02:42:56 	en-US

Comment 18

[Trevor Skywalker]

Top Crashers for Firefox 61.0a1

35 0.38% 	-0.19% 	shutdownhang | NtQueryAttributesFile	19 	19 	0 	0 	19 	0 	2015-01-21

Top Crashers for Firefox 60.0b

25 	0.37% 	0.03% 	shutdownhang | NtQueryAttributesFile	135 	135 	0 	0 	116 	0 	2015-01-21 
	
Top Crashers for Firefox 59.0.2

11 	0.94% 	new 	shutdownhang | NtQueryAttributesFile	609 	609 	0 	0 	582 	0 	2015-01-21 

Top Crashers for Firefox 59.0.1

12 	0.9% 	-0.16% 	shutdownhang | NtQueryAttributesFile	1126 	1126 	0 	0 	1061 	0 	2015-01-21

Top Crashers for Firefox 58.0.2

24 	0.58% 	-0.1% 	shutdownhang | NtQueryAttributesFile	100 	100 	0 	0 	95 	0 	2015-01-21 

Top Crashers for Firefox 52.7.3esr

67 	0.18% 	new 	shutdownhang | NtQueryAttributesFile	102 	102 	0 	0 	95 	1 	2015-01-21 
	

Top Crashers for Firefox 52.7.2esr

45  0.27% 	-0.11% 	shutdownhang | NtQueryAttributesFile	186 	186 	0 	0 	183 	0 	2015-01-21

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Disabling the watchdog seems like a sane idea for users who've gone out of their way to flip this pref.

Comment 20

[Trevor Skywalker]

(In reply to Sushant from comment #13)
> Sorry to say that's the obvious, lazy response. Why have the option in the
> first place then? Shouldn't FF be smarter about this? Slow disks (or even
> disks temporarily slowed down because they're already busy with other
> requests) should be handled appropriately, instead of a simple blind
> assessment that if N secs. have passed and the clean-up process hasn't
> completed, FF must have crashed.

I agree with this comment. Could these ideas be implemented? 

Is there any way for Firefox to determine or estimate how long it will take to empty the cache upon exiting (or restarting) firefox? Taking into account the speed of the disk, by measuring it's performance, or using some type of classification based on type/model (like SSD, HDD-fast, HDD-slow). Taking into consideration how much of the memory to be cleared is on disk (pagefile) vs in memory (RAM). And then using that information for the shutdown and watchdog sequences and timers.

For slow disks and large pagefiles that take a long time to clear, a message could be displayed to the user notifying them of what's happening (clearing the cache) and possibly offering them the suggestion that if it takes too long they could consider turning off "clear cache on exit". Maybe offer a checkbox or option right there to turn it off or leave it on.

Some of these problems might also be related to poor memory usage in general within Firefox leading to memory leaks. I can often restart firefox (manually or after a crash) and when the same tabs are reloaded, the memory usage can be decreased by a few Gigabytes compared to before the restart.

Comment 21

[Trevor Skywalker]

CacheFileIOManager::SyncRemove______() takes too long to finish Clearing the Cache on Shutdown causing a Hang and/or Crash.

Comment 22

[Worcester12345]

"Perf" key word?

Comment 23

[Trevor Skywalker]

Signature report for mozilla::net::CacheFileIOManager::SyncRemoveDir
Showing results from 3 months ago to 4 days ago

94 Results …

7e92c574-1f79-49e4-8037-3c7740180324 	2018-03-24 11:58:04 	Firefox 	59.0.1 	20180315233128 	Windows NT 	EXCEPTION_ACCESS_VIOLATION_READ 	0x0 	2018-03-16 20:39:23
62ba1012-ae44-44b2-b97a-4291d0180226 	2018-02-26 18:44:52 	Firefox 	58.0.2 	20180206200532 	Windows NT 	EXCEPTION_ACCESS_VIOLATION_READ 	0x0 	2018-02-09 04:40:48
dd35dd17-bb8d-4b17-81d4-69f550180201 	2018-02-01 06:52:43 	Firefox 	58.0.1 	20180128191252 	Windows NT 	EXCEPTION_ACCESS_VIOLATION_READ 	0x0 	2018-02-01 06:51:13
d4ff7ac8-3c03-49b1-a915-9bcab0180201 	2018-02-01 06:52:42 	Firefox 	58.0.1 	20180128191252 	Windows NT 	EXCEPTION_ACCESS_VIOLATION_READ 	0x0 	2018-02-01 06:51:13
a01bdd1a-db46-497b-8746-ee0d80180110 	2018-01-10 15:33:33 	Firefox 	57.0.4 	20180103231032 	Windows NT 	EXCEPTION_ACCESS_VIOLATION_READ 	0x0 	2018-01-09 17:01:40

Uptime Range
< 1 min 	93 	98.9%
5-15 min 	1 	1.1%

UUID 	7e92c574-1f79-49e4-8037-3c7740180324
Date Processed 	2018-03-24 11:58:04
Uptime 	4 seconds 

UUID 	62ba1012-ae44-44b2-b97a-4291d0180226
Date Processed 	2018-02-26 18:44:52
Uptime 	10 seconds 

UUID 	dd35dd17-bb8d-4b17-81d4-69f550180201
Date Processed 	2018-02-01 06:52:43
Uptime 	1 seconds
Last Crash 	8 seconds before submission 

UUID 	a01bdd1a-db46-497b-8746-ee0d80180110
Date Processed 	2018-01-10 15:33:33
Uptime 	1 seconds 

https://crash-stats.mozilla.com/report/index/dd35dd17-bb8d-4b17-81d4-69f550180201#allthreads

Thread 1
Frame 	Module 	Signature 	Source
0 	ntdll.dll 	ZwWaitForSingleObject 	
1 	KERNELBASE.dll 	WaitForSingleObjectEx 	
Ø 2 	tmmon64.dll 	tmmon64.dll@0x83175 	
Ø 3 	tmmon64.dll 	tmmon64.dll@0x71f0e 	
Ø 4 	tmmon64.dll 	tmmon64.dll@0x69ec6 	
Ø 5 	tmmon64.dll 	tmmon64.dll@0x6a06d 	
6 	ntdll.dll 	RtlUserThreadStart

Thread 2
Frame 	Module 	Signature 	Source
0 	ntdll.dll 	NtWaitForMultipleObjects 	
1 	KERNELBASE.dll 	RtlAnsiStringToUnicodeString 	
2 	kernel32.dll 	WaitForMultipleObjects 	
Ø 3 	TmUmEvt64.dll 	TmUmEvt64.dll@0x1b125 	
Ø 4 	TmUmEvt64.dll 	TmUmEvt64.dll@0x19fff 	
5 	ntdll.dll 	RtlUserThreadStart

https://crash-stats.mozilla.com/report/index/a01bdd1a-db46-497b-8746-ee0d80180110#allthreads

Crashing Thread (0)
Frame 	Module 	Signature 	Source
0 	xul.dll 	mozilla::net::CacheFileIOManager::SyncRemoveDir(nsIFile*, char const*) 	netwerk/cache2/CacheFileIOManager.cpp:4148

14 	kernel32.dll 	BaseThreadInitThunk 	
Ø 15 	ntdll.dll 	ntdll.dll@0x6efb0 	
16 	kernelbase.dll 	TerminateProcessOnMemoryExhaustion

Thread 1
Frame 	Module 	Signature 	Source
Ø 0 	ntdll.dll 	ntdll.dll@0x9ff94 	
1 	KERNELBASE.dll 	GetQueuedCompletionStatus 	
2 	firefox.exe 	sandbox::BrokerServicesBase::TargetEventsThread(void*) 	security/sandbox/chromium/sandbox/win/src/broker_services.cc:200
3 	kernel32.dll 	BaseThreadInitThunk 	
Ø 4 	ntdll.dll 	ntdll.dll@0x6efb0 	
Thread 2
Frame 	Module 	Signature 	Source
Ø 0 	ntdll.dll 	ntdll.dll@0xa1ba4 	
Ø 1 	ntdll.dll 	ntdll.dll@0x28931 	
Ø 2 	ntdll.dll 	ntdll.dll@0x28931 	
Ø 3 	ntdll.dll 	ntdll.dll@0x5f5b7 	
Ø 4 	ntdll.dll 	ntdll.dll@0x28931 	
Ø 5 	ntdll.dll 	ntdll.dll@0x1131af 	
Ø 6 	ntdll.dll 	ntdll.dll@0x1314f 	
Ø 7 	ntdll.dll 	ntdll.dll@0x20eda 	
Ø 8 	ntdll.dll 	ntdll.dll@0x5fecc 	
Ø 9 	ntdll.dll 	ntdll.dll@0x1907c 	
10 	dbgcore.dll 	guard_dispatch_icall_nop 	
11 	dbgcore.dll 	guard_dispatch_icall_nop

Comment 24

[Honza Bambas (:mayhemer)]

(sorry, too general alias)

Comment 25

[Jason Duell]

Nathan: in a nutshell, this bug is a crash that seems to happen because our shutdown hang timer times out while we're deleting the HTTP cache for users who have the "Clear history when Nightly closes" option set.

I think the answer here is a combo of 1) making the HTTP cache smaller for users with that option set: 100MB or less, I'm thinking, ought to give them most of the benefit of a cache w/o causing too long a delay at close.  2) Either increasing the shutdown timer for users who set the pref, or skipping the timeout altogether.  I'm curious as to Nathan's opinion on those as options (and how to implement it if it's OK)...

Comment 26

[Nathan Froyd [:froydnj]]

(In reply to Jason Duell [:jduell] (needinfo me) from comment #25)
> Nathan: in a nutshell, this bug is a crash that seems to happen because our
> shutdown hang timer times out while we're deleting the HTTP cache for users
> who have the "Clear history when Nightly closes" option set.

Bleh.

> I think the answer here is a combo of 1) making the HTTP cache smaller for
> users with that option set: 100MB or less, I'm thinking, ought to give them
> most of the benefit of a cache w/o causing too long a delay at close.  2)
> Either increasing the shutdown timer for users who set the pref, or skipping
> the timeout altogether.  I'm curious as to Nathan's opinion on those as
> options (and how to implement it if it's OK)...

I think some variant of #2 is the right thing here; #1 is probably going to lead to people complaining that the cache is too small?  Increasing the timeout is probably still going to lead to people complaining, and my sense is that measuring to try to adjust the timeout is Harder Than It Looks.  So disabling the timeout altogether would be the way to go.

Comment 27

[Worcester12345]

(In reply to Worcester12345 from comment #22)
> "Perf" key word?

?

Comment 28

[Wayne Mery (:wsmwk)]

(In reply to Nathan Froyd [:froydnj] (away until 16 July 2018) from comment #26)
> (..l
> I think some variant of #2 is the right thing here; #1 is probably going to
> lead to people complaining that the cache is too small?  Increasing the
> timeout is probably still going to lead to people complaining, and my sense
> is that measuring to try to adjust the timeout is Harder Than It Looks.  So
> disabling the timeout altogether would be the way to go.

Logical solution. However, perhaps if they knew the slow shutdown was related to their shutdown setting or the cache size, they might opt for a different solution?

Comment 31

[Jens Stutte [:jstutte]]

Removed signature for crashes occurring only on very old versions.

Comment 32

[Daniel Bodea [:danibodea]]

According to the crash reports, I have attempted reproducing this crash on the versions with the highest percentage (Release v85.0, v85.0.1) on Windows 10 by doubling the limit of the cache (with pref browser.cache.disk.capacity) and then navigating on ~10 different websites for at least a minute to attempt to collect enough cache and then simply close the browser to expect a crash at shutdown. I wasn't able to reproduce it in a few tries.

Do we have some kind of test case for this issue? At least a more reliable set of steps to reproduce would be nice in order to investigate it.
Can you give me some tips on how it'd be best to attempt its reproduction? Thank you.

Comment 33

[Jens Stutte [:jstutte]]

(In reply to Bodea Daniel [:danibodea] from comment #32)

Do we have some kind of test case for this issue? At least a more reliable set of steps to reproduce would be nice in order to investigate it.
Can you give me some tips on how it'd be best to attempt its reproduction? Thank you.

We do not have test cases for shutdown hangs in general, unfortunately. We might want to understand from the crash reports if there are places we want to add additional diagnostics in order to make this more actionable.

Comment 34

[edgul]

Putting back in triage for priority review.
Also NI'ing myself to revisit later this week.

Comment 35

[edgul]

Pulled out of back-log for closer monitoring

Comment 36

[Valentin Gosu [:valentin] (he/him)]

There is a good chance bug 1705676 will fix this. Let's see how it works on Nightly.

Comment 37

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the bug has the topcrash keyword.
:valentin, could you consider increasing the severity of this top-crash bug? If the crash isn't "top" anymore, could you drop the topcrash keyword?

For more information, please visit auto_nag documentation.

Comment 38

[Randell Jesup [:jesup] (needinfo me)]

As Valentin indicated by linking to bug 1786256, this should be solved by bug 1786256

Comment 39

[Jens Stutte [:jstutte]]

IIUC the instances I see now on crash-stats are a different thing - something is happening with patched_LdrLoadDll that makes us block.

I have no idea what this is and if we can do anything about this, but it looks different from this bug.

Comment 40

[Molly Howell (she/her) (mostly inactive)]

Hmm. It looks like our patched function might be a red herring there; we're already well into the "real" LdrLoadDll by the time the crash is triggered. I don't have access to minidumps anymore, but both the hang in NtQueryAttributesFile and also the LoadLibrary call happening from inside of PeekMessage during shutdown seem a little bit odd. I'm wondering if there's some really terrible I/O situation happening, or if something is trying to have hooks in user32, or both.

Comment 41

[Valentin Gosu [:valentin] (he/him)]

We should see the crash numbers go down in 109 once bug 1786256 rides the trains.

Comment 42

[Jens Stutte [:jstutte]]

The signature [@ shutdownhang | NtQueryAttributesFile ] shows a fair amount of hangs where we seem to do stub_LdrLoadDll intercepting a PeekMessageW. I cannot really see what kind of DLL we try to load here, but I'd assume, it is not really cache related.

Comment 43

[Worcester12345]

(In reply to Valentin Gosu [:valentin] (he/him) [PTO until Jan 2nd] from comment #41)

We should see the crash numbers go down in 109 once bug 1786256 rides the trains.

There must be some statistics by now. I don't know how to view/get these. Can you post something on this?

Comment 44

[Valentin Gosu [:valentin] (he/him)]

This was fixed by bug 1786256.
I think back-porting all of the background tasks work to ESR is too difficult.

(In reply to Jens Stutte [:jstutte] from comment #42)

The signature [@ shutdownhang | NtQueryAttributesFile ] shows a fair amount of hangs where we seem to do stub_LdrLoadDll intercepting a PeekMessageW. I cannot really see what kind of DLL we try to load here, but I'd assume, it is not really cache related.

I have filed bug 1809655 for the remaining crashes with this signature.