Closed Bug 1356898 Opened 3 years ago Closed 3 years ago

TelemetryHistogram::AccumulateChildKeyed shows up in profiles doing memory allocation for strings

Categories

(Toolkit :: Telemetry, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file)

The nsCString in internal_AccumulateChildKeyed can be an nsAutoCString instead, and that would save the memory allocation.
Comment on attachment 8858654 [details]
Bug 1356898 - Use nsAutoCString in two places in TelemetryHistogram.cpp.

https://reviewboard.mozilla.org/r/130636/#review133226
Attachment #8858654 - Flags: review?(nfroyd) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fb6e89f4e62b
Use nsAutoCString in two places in TelemetryHistogram.cpp. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/fb6e89f4e62b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.