1356905 - Record serialization incorrectly escapes control characters

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, enhancement)

Description

[Richard Newman [:rnewman]]

This is the root cause of Bug 1354935 -- Firefox for iOS 7.x doesn't correctly escape some unicode characters.

I hit this thanks to a vertical tab (char code 11) in an old history record in my profile; my iPad uploaded the old record to the server, and my phone crashed.

I've written a failing round-trip test.

Comment 1

[Richard Newman [:rnewman]]

A failing assertion:

    open func serializer<T: CleartextPayloadJSON>(_ f: @escaping (T) -> JSON) -> (Record<T>) -> JSON? {
        return { (record: Record<T>) -> JSON? in
            let json = f(record.payload)
            let data = (json.rawString([writtingOptionsKeys.castNilToNSNull: true]) ?? "").utf8EncodedData

            assert(!JSON(data).isNull())

Comment 2

[Richard Newman [:rnewman]]

Attachment: PR

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8858663 [details] [review]
PR

Adding two more reviewers since I don't have a ton of time today.

Comment 4

[Stephan Leroux [:sleroux]]

master 5d347f81e7fa0386be7e2423ec5d99237de06531
v7.x a09e460