Remove support for the mozapptype attribute

RESOLVED FIXED in Firefox 55

Status

()

Core
DOM
RESOLVED FIXED
a month ago
a month ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

This is dead functionality now that mozapp support has been removed.
Created attachment 8858662 [details] [diff] [review]
Remove support for the mozapptype attribute
Attachment #8858662 - Flags: review?(wmccloskey)
Assignee: nobody → ehsan
Blocks: 1306391
Comment on attachment 8858662 [details] [diff] [review]
Remove support for the mozapptype attribute

Review of attachment 8858662 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure what you're up for, but it looks like there's more dead code here:

- ParticularProcessPriorityManager::OnActivityOpened listens for an observer that never fires. Consequently, mIsActivityOpener should always be false.
- That should allow us to remove some of these priorities, specifically PROCESS_PRIORITY_FOREGROUND_HIGH:
http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/hal/HalTypes.h#59-72

It would be really nice if we could get rid of all the wakelock business. I don't know what that is, but it seems b2g specific, and it's tied into a lot of things.
Attachment #8858662 - Flags: review?(wmccloskey) → review+
I filed bug 1358005 for the rest.  I just saw this attribute when I was reading some other code and realized it's dead code, and didn't follow the thread too deeply...  :-)

Comment 4

a month ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7870b544dab
Remove support for the mozapptype attribute; r=billm
https://hg.mozilla.org/mozilla-central/rev/f7870b544dab
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.