1356913 - Remove support for the mozapptype attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[(no longer active)]

This is dead functionality now that mozapp support has been removed.

Comment 1

[(no longer active)]

Attachment: Remove support for the mozapptype attribute

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8858662 [details] [diff] [review]
Remove support for the mozapptype attribute

Review of attachment 8858662 [details] [diff] [review]:
-----------------------------------------------------------------

Not sure what you're up for, but it looks like there's more dead code here:

- ParticularProcessPriorityManager::OnActivityOpened listens for an observer that never fires. Consequently, mIsActivityOpener should always be false.
- That should allow us to remove some of these priorities, specifically PROCESS_PRIORITY_FOREGROUND_HIGH:
http://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/hal/HalTypes.h#59-72

It would be really nice if we could get rid of all the wakelock business. I don't know what that is, but it seems b2g specific, and it's tied into a lot of things.

Comment 3

[(no longer active)]

I filed bug 1358005 for the rest.  I just saw this attribute when I was reading some other code and realized it's dead code, and didn't follow the thread too deeply...  :-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7870b544dab
Remove support for the mozapptype attribute; r=billm

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f7870b544dab

Comment 6

[Chris Mills [:cmills]]

Adding ddn, just to check the docs for this.

Comment 7

[Chris Mills [:cmills]]

No mention of this on MDN, and I don't think this affects web developers in any way, so I'm not adding a note to the rel notes.

Let me know if that's OK.