1356921 - deviceorientation events not firing on devices without gyroscopes

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[gal007]

Attachment: demo.html

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170321232041

Steps to reproduce:

1) Install fennec 49 onwards (even 55) in Android 6.
2) try to use this application with orientation: http://orb.enclavegames.com/ 
or any other that is suscribed to deviceorientation, as explained here: http://stackoverflow.com/questions/43441602/how-to-get-the-device-orientation-from-a-firefox-for-android-extension

** you can open the demo in the mobile browser and chech it
*It works on other browsers or version 46 


Actual results:

the orientation is never notified


Expected results:

notify the orientation

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Reopening this and deduping from bug 1318293; it looks like this is an actual regression in how we handle device orientation on phones without gyroscopes.

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Attachment: demo2.html

Comment 4

[Dylan Roeh (:droeh) (he/him)]

gal007, if you get a chance, can you try out demo2.html (attached on the bug) on your device and let me know what you see? It's the same demo, but listening for "absolutedeviceorientation" rather than "deviceorientation" -- if you get expected results here, then I'm pretty sure we're failing to fall through to other sensors when a gyroscope is not present.

Comment 5

[Dylan Roeh (:droeh) (he/him)]

Attachment: Enable SENSOR_ROTATION_VECTOR for DeviceOrientation events

Eugen, flagging you for review on this since you touched it last. I think we need to enable SENSOR_ROTATION_VECTOR events for deviceorientation events for backward compatibility with phones that don't fire SENSOR_GAME_ROTATION_VECTOR events here. Tested by ignoring SENSOR_GAME_ROTATION_VECTOR events in GeckoAppShell.onSensorChanged() -- without the patch we never fire ondeviceorientation, with the patch we fire it as expected.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/758112b2c1fc
Enable SENSOR_ROTATION_VECTOR for DeviceOrientation events. r=esawin

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/758112b2c1fc

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 9

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8882608 [details] [diff] [review]
Enable SENSOR_ROTATION_VECTOR for DeviceOrientation events

Approval Request Comment
[Feature/Bug causing the regression]: 1205649
[User impact if declined]: Device orientation events will not be sent on devices which do not send SENSOR_GAME_ROTATION_VECTOR events
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No
[Why is the change risky/not risky?]: Should not change behavior in any case except for devices which do not fire SENSOR_GAME_ROTATION_VECTOR events, and fixes behavior for those devices.
[String changes made/needed]:

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8882608 [details] [diff] [review]
Enable SENSOR_ROTATION_VECTOR for DeviceOrientation events

fennec regression fix for some phones, beta55+

Comment 11

[Julien Cristau [:jcristau]]

(In reply to Dylan Roeh (:droeh) from comment #9)
> [Needs manual test from QE? If yes, steps to reproduce]: 
> [List of other uplifts needed for the feature/fix]:

In future please try to answer all the questions in the uplift request template.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ba0b7a246e87