Closed Bug 1356927 Opened 3 years ago Closed 3 years ago

Update non-cross mac builds to clang 3.9

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(3 files)

Several reasons to want this:
- Most everything else is using clang 3.9 already.
- Building clang 3.8 for mac with build-clang fails.
- Cross-mac builds are using clang 3.9

The minimal supported version of clang is 3.6, so we're already well past not testing builds with that version.
Assignee: nobody → mh+mozilla
Funny thing, the build fails with:

16:16:33     INFO -  /builds/slave/try-m64-0000000000000000000000/build/src/obj-firefox/_virtualenv/bin/python /builds/slave/try-m64-0000000000000000000000/build/src/config/expandlibs_exec.py --extract -- ar crs libhostbz2.a host_blocksort.o host_bzlib.o host_compress.o host_crctable.o host_decompress.o host_huffman.o host_randtable.o
16:16:34     INFO -  Executing: ar crs libhostbz2.a host_blocksort.o host_bzlib.o host_compress.o host_crctable.o host_decompress.o host_huffman.o host_randtable.o
16:16:34     INFO -  /usr/bin/ranlib: object: libhostbz2.a(host_bzlib.o) malformed object (unknown load command 2)
16:16:34     INFO -  ar: internal ranlib command failed
16:16:34     INFO -  /builds/slave/try-m64-0000000000000000000000/build/src/sccache2/sccache /builds/slave/try-m64-0000000000000000000000/build/src/clang/bin/clang++ -std=gnu++11 -o digitgrouping.o -c  -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DU_I18N_IMPLEMENTATION -DUCONFIG_NO_BREAK_ITERATION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DUCONFIG_NO_LEGACY_CONVERSION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_CHARSET_IS_UTF8 -I/builds/slave/try-m64-0000000000000000000000/build/src/config/external/icu/i18n -I/builds/slave/try-m64-0000000000000000000000/build/src/obj-firefox/config/external/icu/i18n -I/builds/slave/try-m64-0000000000000000000000/build/src/intl/icu/source/common -I/builds/slave/try-m64-0000000000000000000000/build/src/obj-firefox/dist/include  -I/builds/slave/try-m64-0000000000000000000000/build/src/obj-firefox/dist/include/nspr -I/builds/slave/try-m64-0000000000000000000000/build/src/obj-firefox/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /builds/slave/try-m64-0000000000000000000000/build/src/obj-firefox/mozilla-config.h -MD -MP -MF .deps/digitgrouping.o.pp -Qunused-arguments  -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe  -g -O3 -fno-omit-frame-pointer  -frtti  /builds/slave/try-m64-0000000000000000000000/build/src/intl/icu/source/i18n/digitgrouping.cpp
16:16:34     INFO -  make[5]: *** [libhostbz2.a] Error 1
Aha this is not using cctools at all...
Depends on: 1356929
Comment on attachment 8858678 [details]
Bug 1356927 - Use ar and ranlib from cctools on mac builds.

https://reviewboard.mozilla.org/r/130668/#review134044
Attachment #8858678 - Flags: review+
Comment on attachment 8858679 [details]
Bug 1356927 - Update non-cross mac builds to clang 3.9.

https://reviewboard.mozilla.org/r/130670/#review134048
Attachment #8858679 - Flags: review+
Comment on attachment 8858705 [details]
Bug 1356927 - Remove unused macosx64 tooltool manifest for ASAN.

https://reviewboard.mozilla.org/r/130718/#review134050
Attachment #8858705 - Flags: review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/48f55ddd400a
Use ar and ranlib from cctools on mac builds. r=gps
https://hg.mozilla.org/integration/autoland/rev/7e67993e7c5b
Update non-cross mac builds to clang 3.9. r=gps
https://hg.mozilla.org/integration/autoland/rev/34ac2d41dfda
Remove unused macosx64 tooltool manifest for ASAN. r=gps
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/278c3bf8f7f4
followup, touch CLOBBER for Mac ranlib change
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.