1356937 - `mach artifact toolchain` fails to get artifacts from clang-cl toolchain builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Error running mach:

    ['artifact', 'toolchain', '--from-build', 'win32-clang-cl']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

BadFilenameException

  File "/home/glandium/gecko-push/python/mozbuild/mozbuild/mach_commands.py", line 1711, in artifact_toolchain
    name, None, None, None, unpack=True)
  File "/home/glandium/gecko-push/python/mozbuild/mozbuild/mach_commands.py", line 1626, in __init__
    super(DownloadRecord, self).__init__(*args, **kwargs)
  File "/home/glandium/gecko-push/python/mozbuild/mozbuild/action/tooltool.py", line 88, in __init__
    raise BadFilenameException(filename=filename)


The cause is that the artifact for these toolchain jobs is public/build/clang.tar.bz2 instead of public/clang.tar.bz2.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1356937 - Avoid `mach artifact toolchain` failing to get taskcluster artifacts when they are not directly under public/.

Review commit: https://reviewboard.mozilla.org/r/130696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130696/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8858688 [details]
Bug 1356937 - Avoid `mach artifact toolchain` failing to get taskcluster artifacts when they are not directly under public/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130696/diff/1-2/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8858688 [details]
Bug 1356937 - Avoid `mach artifact toolchain` failing to get taskcluster artifacts when they are not directly under public/.

https://reviewboard.mozilla.org/r/130696/#review133530

I should have caught this during review :/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/410cb042a5d6
Avoid `mach artifact toolchain` failing to get taskcluster artifacts when they are not directly under public/. r=gps

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/410cb042a5d6