Build mac cross toolchains with clang 3.9

RESOLVED FIXED in Firefox 55

Status

Firefox Build System
General
RESOLVED FIXED
a year ago
3 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

a year ago
Blocks: 1313111
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Depends on: 1356932
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8858711 [details]
Bug 1356951 - Build mac cross toolchains with clang 3.9.

https://reviewboard.mozilla.org/r/130730/#review133338

Is there a particular motivation here beyond just making everything use the same toolchain?

::: browser/config/tooltool-manifests/linux64/clang.manifest:3
(Diff revision 5)
>  [
>    {
> -    "version": "clang 3.8.0, libgcc 4.8.5",
> +    "version": "clang 3.9.0",

You seem to have lost the libgcc version number here. Is that intentional or was it just a hand annotation that didn't surive an automated update?
Attachment #8858711 - Flags: review?(ted) → review+
(Assignee)

Comment 7

a year ago
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #6)
> Comment on attachment 8858711 [details]
> Bug 1356951 - Build mac cross toolchains with clang 3.9.
> 
> https://reviewboard.mozilla.org/r/130730/#review133338
> 
> Is there a particular motivation here beyond just making everything use the
> same toolchain?

Several:
- Less variation between cross-mac and mac builds
- Less numbers of clang versions used
- Building clang 3.8 with build-clang on automation fails, I'd rather update clang if I can than try to figure out why building clang 3.8 fails.

> ::: browser/config/tooltool-manifests/linux64/clang.manifest:3
> (Diff revision 5)
> >  [
> >    {
> > -    "version": "clang 3.8.0, libgcc 4.8.5",
> > +    "version": "clang 3.9.0",
> 
> You seem to have lost the libgcc version number here. Is that intentional or
> was it just a hand annotation that didn't surive an automated update?

Considering the main goal is to bring everything in line before bug 1313111, and that bug 1356989 will remove those lines, I thought "meh". Plus I'm not sure of the exact libgcc version that's in there (although I'm sure it's 4.9.something).

Comment 8

a year ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/491c54a660ae
Build mac cross toolchains with clang 3.9. r=ted

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/491c54a660ae
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.