1356951 - Build mac cross toolchains with clang 3.9

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1356951 - Build mac cross toolchains with clang 3.9.

Do dummy changes to the corresponding build scripts so that the builds
are force triggered (toolchain builds are not triggered automatically
when the tooltool manifest they use changes yet).

Review commit: https://reviewboard.mozilla.org/r/130730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/130730/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8858711 [details]
Bug 1356951 - Build mac cross toolchains with clang 3.9.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130730/diff/1-2/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8858711 [details]
Bug 1356951 - Build mac cross toolchains with clang 3.9.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130730/diff/2-3/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8858711 [details]
Bug 1356951 - Build mac cross toolchains with clang 3.9.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130730/diff/3-4/

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8858711 [details]
Bug 1356951 - Build mac cross toolchains with clang 3.9.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/130730/diff/4-5/

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 8858711 [details]
Bug 1356951 - Build mac cross toolchains with clang 3.9.

https://reviewboard.mozilla.org/r/130730/#review133338

Is there a particular motivation here beyond just making everything use the same toolchain?

::: browser/config/tooltool-manifests/linux64/clang.manifest:3
(Diff revision 5)
>  [
>    {
> -    "version": "clang 3.8.0, libgcc 4.8.5",
> +    "version": "clang 3.9.0",

You seem to have lost the libgcc version number here. Is that intentional or was it just a hand annotation that didn't surive an automated update?

Comment 7

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #6)
> Comment on attachment 8858711 [details]
> Bug 1356951 - Build mac cross toolchains with clang 3.9.
> 
> https://reviewboard.mozilla.org/r/130730/#review133338
> 
> Is there a particular motivation here beyond just making everything use the
> same toolchain?

Several:
- Less variation between cross-mac and mac builds
- Less numbers of clang versions used
- Building clang 3.8 with build-clang on automation fails, I'd rather update clang if I can than try to figure out why building clang 3.8 fails.

> ::: browser/config/tooltool-manifests/linux64/clang.manifest:3
> (Diff revision 5)
> >  [
> >    {
> > -    "version": "clang 3.8.0, libgcc 4.8.5",
> > +    "version": "clang 3.9.0",
> 
> You seem to have lost the libgcc version number here. Is that intentional or
> was it just a hand annotation that didn't surive an automated update?

Considering the main goal is to bring everything in line before bug 1313111, and that bug 1356989 will remove those lines, I thought "meh". Plus I'm not sure of the exact libgcc version that's in there (although I'm sure it's 4.9.something).

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/491c54a660ae
Build mac cross toolchains with clang 3.9. r=ted

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/491c54a660ae