Closed
Bug 1357025
Opened 8 years ago
Closed 8 years ago
Should let user able to create an Firefox account in the Firefox Sync tour
Categories
(Firefox :: General, enhancement, P1)
Firefox
General
Tracking
()
RESOLVED
DUPLICATE
of bug 1357023
Firefox 57
People
(Reporter: Fischer, Assigned: rexboy)
References
Details
Attachments
(1 file)
26.87 KB,
patch
|
Details | Diff | Splinter Review |
Should let user able to create an Firefox account in the Firefox Sync tour
Reporter | ||
Updated•8 years ago
|
Whiteboard: [photon-onboarding]
Assignee | ||
Comment 1•8 years ago
|
||
Things came up to us and may need to be discussed further:
- After signing up the user need to get their mail (maybe on another tab) and finish the sign-in flow there. Is the flow acceptable and what we want to show after the confirm letter has been sent out?
- And after signing in is successful, it automatically open a setting page by default (if we use https://accounts.firefox.com/signin). We may want to replace as some placeholder that can remind user their sign-in is successful.
Assignee | ||
Comment 2•8 years ago
|
||
Observe fxaccounts:onverified for push message of successful login:
os.addObserver(this, "fxaccounts:onverified");
http://searchfox.org/mozilla-central/source/browser/components/nsBrowserGlue.js#251
Updated•8 years ago
|
Priority: -- → P2
Target Milestone: --- → Firefox 57
Assignee | ||
Comment 3•8 years ago
|
||
I wrote a prototype for listening to fxaccounts:onverified. Works with no problem.
And just confirmed with Verdi what we need to do after signing in. What we will do is just removing the login iframe after logged in; And perhaps show something like an icon to indicate successful, and maybe a link for opening a page for further setting. Further detailed flow will be updated later.
Assignee | ||
Comment 4•8 years ago
|
||
A very rough WIP based on patch of bug 1354046. Just for reference.
Updated•8 years ago
|
Flags: qe-verify+
QA Contact: jwilliams
Updated•8 years ago
|
Assignee: nobody → rexboy
Status: NEW → ASSIGNED
Updated•8 years ago
|
Priority: P2 → P1
Assignee | ||
Comment 5•8 years ago
|
||
This should be resolved in the sync tour bug.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•