Crash in `anonymous namespace''::setup_wasapi_stream_one_side<T>




2 years ago
2 years ago


(Reporter: marcia, Assigned: chunmin)


({crash, stale-bug})

55 Branch
Windows 10
crash, stale-bug

Firefox Tracking Flags

(Not tracked)


(crash signature)


(2 attachments)

This bug was filed from the Socorro interface and is 
report bp-41788e6c-70f2-44b4-a37f-7b90b2170416.

Seen while looking at crash stats - All crashes are Windows 10. One crash showing up in 53 as well. Maybe from one of the cubeb updates?
Rank: 15
Priority: -- → P1
Chun-Min, this is in you multi-channel wasapi implementation. This is crashing in a (seemingly?) perfectly valid scenario: a multi-channel input device. We're adding (at least) stereo input in bug 971528, fwiw.

Do you have cycles to work on this, or should I take it ?
Flags: needinfo?(cchang)
(also, there is a crash in windows 7, now).

Comment 3

2 years ago
Feel free to take it, or I could do it tomorrow.
Flags: needinfo?(cchang)
Tomorrow is good, thanks.

Comment 5

2 years ago
The easiest way is to remove the assert [0] and let Windows to find a closest format for us(we could set layout to stereo to a N-track recording device, where N > 2). However, I need a multi-track recording device to reproduce and observe what's the behavior if I do the above modification.

Maybe use one of those virtual sound cards, or buy one and expense it.

I don't trust the thing where windows finds a suitable configuration for you. It sounds nice, but I've always had issues with it in real life. I think it's best to use the mix format that is guaranteed to work, and down/up mix manually if needed.

Comment 7

2 years ago
Created attachment 8859832 [details] [review]
pull on github

It's better to get a sound card to test how multi-track recording works for Windows and other backends we support.

Comment 8

2 years ago
(In reply to Chun-Min Chang[:chunmin] from comment #5)
(In reply to Chun-Min Chang[:chunmin] from comment #7)

The word *track* should be replaced by *channel*


2 years ago
Depends on: 1359451

Comment 9

2 years ago
Created attachment 8868401 [details] [review]
follow up: Fix setting channel layout for input and output in handle_channel_layout
Assignee: nobody → cchang
This is an assigned P1 bug without activity in two weeks. 

If you intend to continue working on this bug for the current release/iteration/sprint, remove the 'stale-bug' keyword.

Otherwise we'll reset the priority of the bug back to '--' on Monday, August 28th.
Keywords: stale-bug

Comment 11

2 years ago
This is already fixed and merged in cubeb repo.
Last Resolved: 2 years ago
Resolution: --- → FIXED
status-firefox53: affected → ---
status-firefox55: affected → ---
You need to log in before you can comment on or make changes to this bug.