1357059 - Crash in `anonymous namespace''::setup_wasapi_stream_one_side<T>

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-41788e6c-70f2-44b4-a37f-7b90b2170416.
=============================================================

Seen while looking at crash stats - http://bit.ly/2pIKEBf. All crashes are Windows 10. One crash showing up in 53 as well. Maybe from one of the cubeb updates?

Comment 1

[Paul Adenot (:padenot)]

Chun-Min, this is in you multi-channel wasapi implementation. This is crashing in a (seemingly?) perfectly valid scenario: a multi-channel input device. We're adding (at least) stereo input in bug 971528, fwiw.

Do you have cycles to work on this, or should I take it ?

Comment 2

[Paul Adenot (:padenot)]

(also, there is a crash in windows 7, now).

Comment 3

[C.M.Chang[:chunmin]]

Feel free to take it, or I could do it tomorrow.

Comment 4

[Paul Adenot (:padenot)]

Tomorrow is good, thanks.

Comment 5

[C.M.Chang[:chunmin]]

The easiest way is to remove the assert [0] and let Windows to find a closest format for us(we could set layout to stereo to a N-track recording device, where N > 2). However, I need a multi-track recording device to reproduce and observe what's the behavior if I do the above modification.

[0] https://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/media/libcubeb/src/cubeb_wasapi.cpp#1522
[1] https://searchfox.org/mozilla-central/rev/214345204f1e7d97abb571b7992b6deedb5ff98f/media/libcubeb/src/cubeb_wasapi.cpp#1424

Comment 6

[Paul Adenot (:padenot)]

Maybe use one of those virtual sound cards, or buy one and expense it.

I don't trust the thing where windows finds a suitable configuration for you. It sounds nice, but I've always had issues with it in real life. I think it's best to use the mix format that is guaranteed to work, and down/up mix manually if needed.

Comment 7

[C.M.Chang[:chunmin]]

Attachment: pull on github

It's better to get a sound card to test how multi-track recording works for Windows and other backends we support.

Comment 8

[C.M.Chang[:chunmin]]

(In reply to Chun-Min Chang[:chunmin] from comment #5)
(In reply to Chun-Min Chang[:chunmin] from comment #7)
s/track/channel/

The word *track* should be replaced by *channel*

Comment 9

[C.M.Chang[:chunmin]]

Attachment: follow up: Fix setting channel layout for input and output in handle_channel_layout

Comment 10

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This is an assigned P1 bug without activity in two weeks. 

If you intend to continue working on this bug for the current release/iteration/sprint, remove the 'stale-bug' keyword.

Otherwise we'll reset the priority of the bug back to '--' on Monday, August 28th.

Comment 11

[C.M.Chang[:chunmin]]

This is already fixed and merged in cubeb repo.