network.http.referer.hideOnionSource is not described correctly

RESOLVED FIXED in Firefox 55

Status

()

Core
Networking
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: francois, Assigned: arthuredelstein)

Tracking

({good-first-bug})

unspecified
mozilla55
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [necko-next])

Attachments

(1 attachment)

(Reporter)

Description

a year ago
In modules/libpref/init/all.js, the network.http.referer.hideOnionSource pref claims to be spoofing the referrer:

https://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/modules/libpref/init/all.js#1522

whereas in the actual implementation, it strips out the referrer instead:

https://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/netwerk/protocol/http/HttpBaseChannel.cpp#1514
https://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/netwerk/protocol/http/HttpBaseChannel.cpp#1669

We should fix the comment in modules/libpref/init/all.js
Can you take a look?
Flags: needinfo?(arthuredelstein)
Whiteboard: [necko-next]
Created attachment 8859793 [details] [diff] [review]
0001-Bug-1357247-Fix-comment-for-network.http.referer.hid.patch

Thanks for reporting this and sorry for the error.
Flags: needinfo?(arthuredelstein)
Attachment #8859793 - Flags: review?(mcmanus)
Attachment #8859793 - Flags: review?(mcmanus) → review+
Keywords: checkin-needed
Assignee: nobody → arthuredelstein

Comment 3

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f57b18615900
Fix comment for network.http.referer.hideOnionSource. r=mcmanus
Keywords: checkin-needed

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f57b18615900
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.