Closed
Bug 1357247
Opened 8 years ago
Closed 8 years ago
network.http.referer.hideOnionSource is not described correctly
Categories
(Core :: Networking, enhancement)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: francois, Assigned: arthur)
References
Details
(Keywords: good-first-bug, Whiteboard: [necko-next])
Attachments
(1 file)
|
964 bytes,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
In modules/libpref/init/all.js, the network.http.referer.hideOnionSource pref claims to be spoofing the referrer:
https://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/modules/libpref/init/all.js#1522
whereas in the actual implementation, it strips out the referrer instead:
https://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/netwerk/protocol/http/HttpBaseChannel.cpp#1514
https://searchfox.org/mozilla-central/rev/4bd7a206dea5382c97a8a0c30beef668cc449f5b/netwerk/protocol/http/HttpBaseChannel.cpp#1669
We should fix the comment in modules/libpref/init/all.js
|
||
Updated•8 years ago
|
Whiteboard: [necko-next]
|
Assignee | |
Comment 2•8 years ago
|
||
Thanks for reporting this and sorry for the error.
Flags: needinfo?(arthuredelstein)
Attachment #8859793 -
Flags: review?(mcmanus)
|
||
Updated•8 years ago
|
Attachment #8859793 -
Flags: review?(mcmanus) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Updated•8 years ago
|
Assignee: nobody → arthuredelstein
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f57b18615900
Fix comment for network.http.referer.hideOnionSource. r=mcmanus
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•