Closed Bug 1357286 Opened 4 years ago Closed 4 years ago

opt build bustage in dom/fetch/InternalResponse.cpp when Gecko 55 merges to beta on 2017-06-12

Categories

(Core :: DOM: Core & HTML, defect)

55 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr45 --- unaffected
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 + fixed

People

(Reporter: philor, Assigned: baku)

References

Details

Attachments

(1 file)

Apparently MOZ_DIAGNOSTIC_ASSERT resolves to nothing for opt builds on RELEASE_OR_BETA, so https://hg.mozilla.org/mozilla-central/annotate/c697e756f738ce37abc56f31bfbc48f55625d617/dom/fetch/InternalResponse.cpp#l130 leaves 'ok' unused, https://treeherder.mozilla.org/logviewer.html#?job_id=92204909&repo=try

(Should be able to test locally by just removing the a1 from the version number in config/milestone.txt)

[Tracking Requested - why for this release]:

Merge build bustage, permared, closed beta tree, much sadness.
Flags: needinfo?(amarchesini)
tracking as 55 beta merge blocker
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8859170 - Flags: review?(philringnalda)
Comment on attachment 8859170 [details] [diff] [review]
fix_release.patch

Works for me, other than needing the same thing in dom/fetch/InternalResponse.cpp, which I've already got in my tree.
Attachment #8859170 - Flags: review?(philringnalda) → review+
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a756b15ba7b
Fix warnings on release builds about unused return values from autoStream->Serialize, r=philor
https://hg.mozilla.org/mozilla-central/rev/7a756b15ba7b
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.