1357286 - opt build bustage in dom/fetch/InternalResponse.cpp when Gecko 55 merges to beta on 2017-06-12

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Phil Ringnalda (:philor)]

Apparently MOZ_DIAGNOSTIC_ASSERT resolves to nothing for opt builds on RELEASE_OR_BETA, so https://hg.mozilla.org/mozilla-central/annotate/c697e756f738ce37abc56f31bfbc48f55625d617/dom/fetch/InternalResponse.cpp#l130 leaves 'ok' unused, https://treeherder.mozilla.org/logviewer.html#?job_id=92204909&repo=try

(Should be able to test locally by just removing the a1 from the version number in config/milestone.txt)

[Tracking Requested - why for this release]:

Merge build bustage, permared, closed beta tree, much sadness.

Comment 1

[Phil Ringnalda (:philor)]

And the same for https://hg.mozilla.org/mozilla-central/annotate/c697e756f738ce37abc56f31bfbc48f55625d617/dom/cache/CacheStreamControlParent.cpp#l65

Comment 2

[Julien Cristau [:jcristau]]

tracking as 55 beta merge blocker

Comment 3

[Andrea Marchesini [:baku]]

Attachment: fix_release.patch

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 8859170 [details] [diff] [review]
fix_release.patch

Works for me, other than needing the same thing in dom/fetch/InternalResponse.cpp, which I've already got in my tree.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a756b15ba7b
Fix warnings on release builds about unused return values from autoStream->Serialize, r=philor

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7a756b15ba7b