1357287 - Crash in java.lang.RuntimeException: cannot get MediaCodecList at android.media.MediaCodecList.native_getCodecCount(Native Method)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P1)

Description

[Nicholas Nethercote [inactive]]

This bug was filed from the Socorro interface and is 
report bp-523303de-52cb-4c5e-8768-20b442170415.
=============================================================

Longstanding crash:

> product      version count perc  installations
> FennecAndroid 52.0.2 	366  83.9%  108
> FennecAndroid 53.0 	 27   6.2%    5
> FennecAndroid 53.0b11  27   6.2%    8
> FennecAndroid 54.0a2 	 11   2.5%    6
> FennecAndroid 53.0b9 	  5   1.1%    1

Java stack trace:

> java.lang.RuntimeException: cannot get MediaCodecList
>   at android.media.MediaCodecList.native_getCodecCount(Native Method)
>   at android.media.MediaCodecList.initCodecList(MediaCodecList.java:82)
>   at android.media.MediaCodecList.getCodecCount(MediaCodecList.java:43)
>   at org.mozilla.gecko.util.HardwareCodecCapabilityUtils.findDecoderCodecInfoForMimeType(HardwareCodecCapabilityUtils.java:43)
>   at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
>   at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:583)

jchen, any ideas?

Comment 1

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1357287-1.0-Catch-and-ignore-runtime-exception-d.patch

This looks like an Android bug to me on certain devices (mostly based on the "universal8890" SoC): https://android.googlesource.com/platform/frameworks/base/+/master/media/jni/android_media_MediaCodecList.cpp#39

I don't think we can do much here, so we should probably just block the media playback.

Want me to investigate more or forward it to the media or Android team?

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8859278 [details] [diff] [review]
0001-Bug-1357287-1.0-Catch-and-ignore-runtime-exception-d.patch

Review of attachment 8859278 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/HardwareCodecCapabilityUtils.java
@@ +41,5 @@
>    @WrapForJNI
>    public static boolean findDecoderCodecInfoForMimeType(String aMimeType) {
> +    int numCodecs = 0;
> +    try {
> +      numCodecs = MediaCodecList.getCodecCount();

This looks pretty strange without knowing about this bug, so maybe reference it in a comment.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/07e9e794d4ff
[1.1] Add multiprocess GeckoView setting. r=snorp

Comment 4

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1357287-1.1-Catch-and-ignore-runtime-exception-d.patch

Added error logging.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72812cf49ddf
[1.1] Catch and ignore runtime exception during media codec query. r=snorp

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72812cf49ddf

Comment 7

[Ryan VanderMeulen (PTO, back July 27)]

Seems worth a Beta nomination?

Comment 8

[Eugen Sawin [:esawin]]

Comment on attachment 8859754 [details] [diff] [review]
0001-Bug-1357287-1.1-Catch-and-ignore-runtime-exception-d.patch

Approval Request Comment
[Feature/Bug causing the regression]: N/A.
[User impact if declined]: Crash on media playback.
[Is this code covered by automated tests?]: No, we don't simulated Android system failures.
[Has the fix been verified in Nightly?]: So far there are no crash reports on 55.
[Needs manual test from QE? If yes, steps to reproduce]: N/A.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It only handles an exception thrown by Android. Instead of crashing, we break media playback.
[String changes made/needed]: None.

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8859754 [details] [diff] [review]
0001-Bug-1357287-1.1-Catch-and-ignore-runtime-exception-d.patch

Fix a crash. Beta54+. Should be in 54 beta 6 for mobile.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/72f8cd9a6898