Closed Bug 1357296 Opened 7 years ago Closed 7 years ago

stylo: Factor out text-zoom from font-size values in SMIL

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In the ValueFromStringHelper for Servo that is added in bug 1355348, we should factor out the text zoom from font-size values like we do for Gecko style.

  e.g. computedValue.mServo = Servo_DivideTextZoom(*computedValue.mServo,
                                aPresContext->EffectiveTextZoom());

We might end up tying this to bug 1357295 if we produce a special method for parsing CSS values for SMIL in Servo.
Priority: -- → P2
Stylo does not support text-zoom yet (bug 1290228).
Depends on: 1290228
How not? What exactly isn't working?
(Or wasn't working when comment 1 was written, I don't think anything related to what was or wasn't working has significantly changed since then)
I couldn't find bug 1358688 in comment 1.
Depends on: 1358688
Priority: P2 → P4
I think bug 1358688 covered this case. We just drop NS_WARNING in ValueFromStringHelper. But test_smilTextZoom.xhtml does not pass because of serialization issue, i.e. stylo serialize unit less value with 'px'.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Do'h!
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
I honestly don't understand how this works, but test_smilTextZoom.xhtml seems to pass now. I'm going to just drop that warning.
Assignee: nobody → bbirtles
Status: REOPENED → ASSIGNED
Comment on attachment 8905386 [details]
Bug 1357296 - Drop warning about needing to factor out text-zoom in SMIL;

https://reviewboard.mozilla.org/r/177166/#review182222

IIUC, text-zoom is not factored in computed values in the first place for SVG.
Attachment #8905386 - Flags: review?(hikezoe) → review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8852f9e7fb7e
Drop warning about needing to factor out text-zoom in SMIL; r=hiro
https://hg.mozilla.org/mozilla-central/rev/8852f9e7fb7e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.