1357296 - stylo: Factor out text-zoom from font-size values in SMIL

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Brian Birtles (:birtles)]

In the ValueFromStringHelper for Servo that is added in bug 1355348, we should factor out the text zoom from font-size values like we do for Gecko style.

  e.g. computedValue.mServo = Servo_DivideTextZoom(*computedValue.mServo,
                                aPresContext->EffectiveTextZoom());

We might end up tying this to bug 1357295 if we produce a special method for parsing CSS values for SMIL in Servo.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Stylo does not support text-zoom yet (bug 1290228).

Comment 2

[Emilio Cobos Álvarez (:emilio)]

How not? What exactly isn't working?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(Or wasn't working when comment 1 was written, I don't think anything related to what was or wasn't working has significantly changed since then)

Comment 4

[Hiroyuki Ikezoe (:hiro)]

I couldn't find bug 1358688 in comment 1.

Comment 5

[Hiroyuki Ikezoe (:hiro)]

I think bug 1358688 covered this case. We just drop NS_WARNING in ValueFromStringHelper. But test_smilTextZoom.xhtml does not pass because of serialization issue, i.e. stylo serialize unit less value with 'px'.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Do'h!

Comment 7

[Brian Birtles (:birtles)]

I honestly don't understand how this works, but test_smilTextZoom.xhtml seems to pass now. I'm going to just drop that warning.

Comment 8

[Brian Birtles (:birtles)]

Attachment: Bug 1357296 - Drop warning about needing to factor out text-zoom in SMIL;

I'm not sure exactly how this works, but test_smilTextZoom.xhtml passes so this
appears to be taken care of.

Review commit: https://reviewboard.mozilla.org/r/177166/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177166/

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8905386 [details]
Bug 1357296 - Drop warning about needing to factor out text-zoom in SMIL;

https://reviewboard.mozilla.org/r/177166/#review182222

IIUC, text-zoom is not factored in computed values in the first place for SVG.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8852f9e7fb7e
Drop warning about needing to factor out text-zoom in SMIL; r=hiro

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8852f9e7fb7e