Closed
Bug 1357341
Opened 7 years ago
Closed 7 years ago
devtools reps: update bundle to v0.6.0
Categories
(DevTools :: Shared Components, enhancement, P3)
DevTools
Shared Components
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jdescottes, Assigned: nchevobbe)
References
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → nchevobbe
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•7 years ago
|
||
TRY is green https://treeherder.mozilla.org/#/jobs?repo=try&revision=089d329088fc1961bf38b5f79bc1831955039b97
Reporter | ||
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8859987 [details] Bug 1357341 - Fix VariableView with new Reps bundle; https://reviewboard.mozilla.org/r/132032/#review134828
Attachment #8859987 -
Flags: review?(jdescottes) → review+
Reporter | ||
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8859986 [details] Bug 1357341 - Reps 0.6.0: update reps bundle from Github; https://reviewboard.mozilla.org/r/132030/#review134830 Should we update the following calls to createFactories after this lands? - createFactories(REPS.StringRep).rep; (http://searchfox.org/mozilla-central/source/devtools/client/webconsole/new-console-output/components/grip-message-body.js#27) - createFactory(REPS.Rep); (found in many files :) )
Attachment #8859986 -
Flags: review?(jdescottes) → review+
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8859986 [details] Bug 1357341 - Reps 0.6.0: update reps bundle from Github; https://reviewboard.mozilla.org/r/132030/#review134830 Yes, I planned to do it on a separate bug, since I wanted this one to be only about landing the bundle. Thanks !
Assignee | ||
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8859986 [details] Bug 1357341 - Reps 0.6.0: update reps bundle from Github; https://reviewboard.mozilla.org/r/132030/#review134836
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76d7e4ef5e0a Reps 0.6.0: update reps bundle from Github; r=jdescottes https://hg.mozilla.org/integration/autoland/rev/468405fee195 Fix VariableView with new Reps bundle; r=jdescottes
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/76d7e4ef5e0a https://hg.mozilla.org/mozilla-central/rev/468405fee195
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•