Note: There are a few cases of duplicates in user autocompletion which are being worked on.

devtools reps: update bundle to v0.6.0

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Shared Components
P3
enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: jdescottes, Assigned: nchevobbe)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment hidden (empty)

Updated

3 months ago
Blocks: 1353038
(Assignee)

Updated

3 months ago
Assignee: nobody → nchevobbe
(Assignee)

Updated

3 months ago
Blocks: 1307940
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

3 months ago
TRY is green https://treeherder.mozilla.org/#/jobs?repo=try&revision=089d329088fc1961bf38b5f79bc1831955039b97
(Assignee)

Updated

3 months ago
Blocks: 1313161
(Reporter)

Comment 4

3 months ago
mozreview-review
Comment on attachment 8859987 [details]
Bug 1357341 - Fix VariableView with new Reps bundle;

https://reviewboard.mozilla.org/r/132032/#review134828
Attachment #8859987 - Flags: review?(jdescottes) → review+
(Reporter)

Comment 5

3 months ago
mozreview-review
Comment on attachment 8859986 [details]
Bug 1357341 - Reps 0.6.0: update reps bundle from Github;

https://reviewboard.mozilla.org/r/132030/#review134830

Should we update the following calls to createFactories after this lands? 
- createFactories(REPS.StringRep).rep; (http://searchfox.org/mozilla-central/source/devtools/client/webconsole/new-console-output/components/grip-message-body.js#27)
- createFactory(REPS.Rep); (found in many files :) )
Attachment #8859986 - Flags: review?(jdescottes) → review+
(Assignee)

Comment 6

3 months ago
mozreview-review-reply
Comment on attachment 8859986 [details]
Bug 1357341 - Reps 0.6.0: update reps bundle from Github;

https://reviewboard.mozilla.org/r/132030/#review134830

Yes, I planned to do it on a separate bug, since I wanted this one to be only about landing the bundle.
Thanks !
(Assignee)

Comment 7

3 months ago
mozreview-review
Comment on attachment 8859986 [details]
Bug 1357341 - Reps 0.6.0: update reps bundle from Github;

https://reviewboard.mozilla.org/r/132030/#review134836

Comment 8

3 months ago
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/76d7e4ef5e0a
Reps 0.6.0: update reps bundle from Github; r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/468405fee195
Fix VariableView with new Reps bundle; r=jdescottes
(Assignee)

Updated

3 months ago
Blocks: 1358103

Comment 9

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/76d7e4ef5e0a
https://hg.mozilla.org/mozilla-central/rev/468405fee195
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.