1357438 - Web apps - Login autocomplete isn't working

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Oana Horvath [:ohorvath - out of office]]

Device: LG G4 (Android 6);
Build: Nightly 55.0a1 (2017-04-18);

Steps to reproduce:
1. Go to twitter.com web app and log in.
2. Save the password.
3. Log out and go back to the login page.
4. Tap the username field for autocomplete options.

Expected result:
Username & password should be auto-filled in if it was saved. If there are multiple logins saved, a drop-down should display the options.

Actual result:
The autocomplete feature is not working.

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

To me it's an essential function not working. Flagging P1.

Comment 2

[Oana Horvath [:ohorvath - out of office]]

Actually, today I've investigated further and seen that not all devices have this problem.

On all these, the autocomplete works on twitter:
-Huawei MediaPad M2 (Android 5.1.1)
-Motorola Nexus 6 (Android 7.0)
-Asus ZenPad 8.0 Z380KL (Android 6.0.1)

Not working on:
- LG G4 (Android 5.1)
- LG G4 (Android 6.0)
*on these, the autocomplete works in the browser.

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

let's revisit the priority once we have further info after investigation.

Comment 4

[Oana Horvath [:ohorvath - out of office]]

There was a thing I was missing in the first place. The issue is reproducible on any device and other web apps too, e.g. datememe.com, as it follows:
- when there is just one login saved, the autocomplete works: username and pass are auto-filled in when you start the web app.
- when there are 2 or more logins saved for the same site, passwords are filled in but usernames not. You have to type in the username and then the password will be autocompleted. In the browser, there is a username drop-down list for auto-complete that doesn't appear in the web app.
Apologies for the previous incomplete report.

Comment 5

[Dale Harvey (:daleharvey)]

Ok found whats happening here although a little confused, In standalone mode FormAssistPopup is not being constructed. 

As far as I can tell http://searchfox.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/GeckoApp.java#1654 is the only place where it gets created, however this code is being hit inside standalone mode, also when inside the browser mode this code gets hit after FormAssistPopup constructor is called, so not certain where this is getting created

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: Add form assist popup to custom tabs / webapps

This should fix autocomplete (login) for both webapps and custom tabs

Comment 7

[Dale Harvey (:daleharvey)]

By should I mean it does, I tested webapps at least

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e472f16bdd17
Add form assist popup to custom tabs / webapps. r=walkingice

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e472f16bdd17

Comment 10

[Oana Horvath [:ohorvath - out of office]]

Verified the login autocomplete on web apps in Nightly 55.0a1 (207-05-17).
Devices:
-LG G4 (Android 6)
-Huawei Honor 5X (Android 5.1.1)