1357480 - Crash in ShareTo PlugInKit: [PKService run] + 848 / 0xdead10cc

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This is the same problem as described in bug 1350861

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR https://github.com/mozilla-mobile/firefox-ios/pull/2638

This patch makes sure that we do not leave the *Profile* open when the *ShareTo* app extension goes into the background. It does this by removing the *Profile* as an instance variable and limit the scope where it is used (opened, used, closed) to absolute minimum.

Comment 2

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8859276 [details] [review]
PR https://github.com/mozilla-mobile/firefox-ios/pull/2638

LGTM

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Steps to reproduce the crash:

1) Install v7.x
2) Open Safari
3) Share the current URL to Firefox with the ShareTo extension (bookmarks or readinglist)
4) Immediately open the share extension again, but do not share, leave open
5) Lock device
6) Wait a minute
7) Unlock device

Expected: Share extension is still there.

Actual: Share extension has been killed by the OS. You can find a crash log for ShareTo that looks like this:

Exception Type:  EXC_CRASH (SIGKILL)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Exception Note:  EXC_CORPSE_NOTIFY
Termination Reason: Namespace SPRINGBOARD, Code 0xdead10cc
Triggered by Thread:  0

Comment 4

[Catalin Suciu [:csuciu]]

Able to reproduce both SendTo and ShareTo crashes on latest master. Stefan, do we need a separate bug for SendTo?

Comment 5

[Catalin Suciu [:csuciu]]

Unable to reproduce the crash on v7.3b2756. 

v8.0 is still affected so this patch needs to land there also.

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The followup fix for this bug landed a couple of hours after the previous comment. Catalin, can you give this a try again on master?

Comment 7

[Catalin Suciu [:csuciu]]

The crash is no longer reproducible on master. Tested on f9f4cf1ba.