Closed
Bug 1357546
Opened 8 years ago
Closed 8 years ago
ESLint of browser/base fails no Windows with lots of no-undef
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
Currently running ESLint on browser/base fails on Windows with lots of no-undef errors.
This is due to me trying to treat handle a relative path assuming it is in posix format - it needs a bit of translation.
| Comment hidden (mozreview-request) |
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8859339 [details]
Bug 1357546 - Fix how relative paths are handled in Windows for the ESLint import-browser-window-globals rule.
https://reviewboard.mozilla.org/r/131376/#review133948
Attachment #8859339 -
Flags: review?(dtownsend) → review+
|
||
Comment 3•8 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s 05fa345fdb2f -d 2963aec1e67f: rebasing 390475:05fa345fdb2f "Bug 1357546 - Fix how relative paths are handled in Windows for the ESLint import-browser-window-globals rule. r=mossop" (tip)
merging tools/lint/eslint/eslint-plugin-mozilla/package.json
warning: conflicts while merging tools/lint/eslint/eslint-plugin-mozilla/package.json! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
| Comment hidden (mozreview-request) |
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa863968ae18
Fix how relative paths are handled in Windows for the ESLint import-browser-window-globals rule. r=mossop
|
||
Updated•8 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•7 years ago
|
Product: Testing → Firefox Build System
|
||
Updated•6 years ago
|
Version: Version 3 → 3 Branch
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•