ESLint of browser/base fails no Windows with lots of no-undef

RESOLVED FIXED in Firefox 55

Status

defect
RESOLVED FIXED
2 years ago
8 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

3 Branch
mozilla55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Currently running ESLint on browser/base fails on Windows with lots of no-undef errors.

This is due to me trying to treat handle a relative path assuming it is in posix format - it needs a bit of translation.
Comment on attachment 8859339 [details]
Bug 1357546 - Fix how relative paths are handled in Windows for the ESLint import-browser-window-globals rule.

https://reviewboard.mozilla.org/r/131376/#review133948
Attachment #8859339 - Flags: review?(dtownsend) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 05fa345fdb2f -d 2963aec1e67f: rebasing 390475:05fa345fdb2f "Bug 1357546 - Fix how relative paths are handled in Windows for the ESLint import-browser-window-globals rule. r=mossop" (tip)
merging tools/lint/eslint/eslint-plugin-mozilla/package.json
warning: conflicts while merging tools/lint/eslint/eslint-plugin-mozilla/package.json! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa863968ae18
Fix how relative paths are handled in Windows for the ESLint import-browser-window-globals rule. r=mossop
https://hg.mozilla.org/mozilla-central/rev/fa863968ae18
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.