Closed
Bug 1357579
Opened 7 years ago
Closed 7 years ago
Clearing single site setting item fails
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(fennec54+, firefox53 wontfix, firefox54 verified, firefox55 fixed)
VERIFIED
FIXED
Firefox 55
People
(Reporter: JanH, Assigned: JanH)
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
ahunt
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
STR: 1. Go to https://www.openstreetmap.org 2. Press the little arrow and accept the location permission prompt. 3. Open the site settings, check the Location permission and hit Clear. 4. Open the site settings again and notice that the Location permission is in fact still present. 5. Try again. 6. Ditto. 7. Try checking the Logins permission instead. 8. Still nothing. 9. Check both Logins *and* Location. 10. Finally success - the Location permission no longer shows up. Tested and reproduced on both FF52 and 55.
Comment 1•7 years ago
|
||
I couldn't reproduce using nightly (55). Ioana, Could your team try reproducing this bug?
Flags: needinfo?(ioana.chiorean)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jh+bugzilla
Flags: needinfo?(ioana.chiorean)
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8860524 [details] Bug 1357579 - Correctly copy the sparse Boolean array when clearing Site Settings. https://reviewboard.mozilla.org/r/132524/#review136656 Yuck, good find!
Attachment #8860524 -
Flags: review?(ahunt) → review+
Pushed by mozilla@buttercookie.de: https://hg.mozilla.org/integration/autoland/rev/caefd3a1d7b7 Correctly copy the sparse Boolean array when clearing Site Settings. r=ahunt
Updated•7 years ago
|
tracking-fennec: ? → +
Comment 5•7 years ago
|
||
marked 54+ and let the RM decide if we need this uplifted.
tracking-fennec: + → 54+
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/caefd3a1d7b7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 7•7 years ago
|
||
RM isn't likely to even notice this bug until someone nominates it for approval. Jan, can you please do so if we indeed want to get this onto Beta54 still? :)
Flags: needinfo?(jh+bugzilla)
Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 8860524 [details] Bug 1357579 - Correctly copy the sparse Boolean array when clearing Site Settings. @Ryan: I was going to anyway, but unless it's really urgent, I always feel guilty about the "Has the fix been verified in Nightly?" question :-) Approval Request Comment [Feature/Bug causing the regression]: Site Settings (web site permission management) on Android [User impact if declined]: Clearing some - but not all - Site Settings may not work properly. [Is this code covered by automated tests?]: No. [Has the fix been verified in Nightly?]: Yes. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: No. [Why is the change risky/not risky?]: Tiny change to correctly iterate over a *sparse* array. [String changes made/needed]: none
Flags: needinfo?(jh+bugzilla)
Attachment #8860524 -
Flags: approval-mozilla-beta?
Comment 9•7 years ago
|
||
Hi Mihai, Can you help check if this issue is fixed in the latest nightly?
Flags: qe-verify+
Flags: needinfo?(mihai.ninu)
Comment 10•7 years ago
|
||
Comment on attachment 8860524 [details] Bug 1357579 - Correctly copy the sparse Boolean array when clearing Site Settings. Fix a web site permission management issue. Beta54+. Should be in 54 beta 6.
Attachment #8860524 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 11•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/90aefe217dc2
Comment 12•7 years ago
|
||
Verified as fixed on Beta 54.0b6. Device: -HTC 10 (Android 6.0.1)
Status: RESOLVED → VERIFIED
Comment 13•7 years ago
|
||
Providing info requested from Mihai, I'm taking out the NI.
Flags: needinfo?(mihai.ninu)
Comment 14•6 years ago
|
||
Based on comment 12 I will remove the qe-verify flag, thanks.
Flags: qe-verify+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•