Closed Bug 1357579 Opened 2 years ago Closed 2 years ago

Clearing single site setting item fails

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
fennec 54+ ---
firefox53 --- wontfix
firefox54 --- verified
firefox55 --- fixed

People

(Reporter: JanH, Assigned: JanH)

Details

Attachments

(1 file)

STR:
1. Go to https://www.openstreetmap.org
2. Press the little arrow and accept the location permission prompt.
3. Open the site settings, check the Location permission and hit Clear.
4. Open the site settings again and notice that the Location permission is in fact still present.
5. Try again.
6. Ditto.
7. Try checking the Logins permission instead.
8. Still nothing.
9. Check both Logins *and* Location.
10. Finally success - the Location permission no longer shows up.

Tested and reproduced on both FF52 and 55.
I couldn't reproduce using nightly (55).

Ioana,
Could your team try reproducing this bug?
Flags: needinfo?(ioana.chiorean)
Assignee: nobody → jh+bugzilla
Flags: needinfo?(ioana.chiorean)
Comment on attachment 8860524 [details]
Bug 1357579 - Correctly copy the sparse Boolean array when clearing Site Settings.

https://reviewboard.mozilla.org/r/132524/#review136656

Yuck, good find!
Attachment #8860524 - Flags: review?(ahunt) → review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/caefd3a1d7b7
Correctly copy the sparse Boolean array when clearing Site Settings. r=ahunt
tracking-fennec: ? → +
marked 54+ and let the RM decide if we need this uplifted.
tracking-fennec: + → 54+
https://hg.mozilla.org/mozilla-central/rev/caefd3a1d7b7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
RM isn't likely to even notice this bug until someone nominates it for approval. Jan, can you please do so if we indeed want to get this onto Beta54 still? :)
Flags: needinfo?(jh+bugzilla)
Comment on attachment 8860524 [details]
Bug 1357579 - Correctly copy the sparse Boolean array when clearing Site Settings.

@Ryan: I was going to anyway, but unless it's really urgent, I always feel guilty about the "Has the fix been verified in Nightly?" question :-)

Approval Request Comment
[Feature/Bug causing the regression]: Site Settings (web site permission management) on Android
[User impact if declined]: Clearing some - but not all - Site Settings may not work properly.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Tiny change to correctly iterate over a *sparse* array.
[String changes made/needed]: none
Flags: needinfo?(jh+bugzilla)
Attachment #8860524 - Flags: approval-mozilla-beta?
Hi Mihai,
Can you help check if this issue is fixed in the latest nightly?
Flags: qe-verify+
Flags: needinfo?(mihai.ninu)
Comment on attachment 8860524 [details]
Bug 1357579 - Correctly copy the sparse Boolean array when clearing Site Settings.

Fix a web site permission management issue. Beta54+. Should be in 54 beta 6.
Attachment #8860524 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on Beta 54.0b6.
Device:
-HTC 10 (Android 6.0.1)
Status: RESOLVED → VERIFIED
Providing info requested from Mihai, I'm taking out the NI.
Flags: needinfo?(mihai.ninu)
Based on comment 12 I will remove the qe-verify flag, thanks.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.