1357590 - Test drag and drop with mouse actions

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Add wdspec test for drag and drop with pointer actions, pointerType "mouse".

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1357590 - Add default button to pointer_up and pointer_down;

Review commit: https://reviewboard.mozilla.org/r/131416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131416/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1357590 - Test drag and drop with mouse actions;

Review commit: https://reviewboard.mozilla.org/r/131418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131418/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8859391 [details]
Bug 1357590 - Add default button to pointer_up and pointer_down;

https://reviewboard.mozilla.org/r/131416/#review134022

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8859392 [details]
Bug 1357590 - Test drag and drop with mouse actions;

https://reviewboard.mozilla.org/r/131418/#review134026

::: testing/web-platform/tests/webdriver/actions/support/test_actions_wdspec.html:95
(Diff revision 1)
>              allEvents.events.length = 0;
>              displayMessage("");
>          }
>  
> +        function drop(moveHandler) {
> +          return function(e) {

Nit: Space before parenthesis, otherwise it looks like you’re calling a function called "function" with argument "e".

::: testing/web-platform/tests/webdriver/actions/support/test_actions_wdspec.html:95
(Diff revision 1)
>              allEvents.events.length = 0;
>              displayMessage("");
>          }
>  
> +        function drop(moveHandler) {
> +          return function(e) {

Variable e is never used.  Leave out?

::: testing/web-platform/tests/webdriver/actions/support/test_actions_wdspec.html:104
(Diff revision 1)
> +            recordPointerEvent(e);
> +          };
> +        }
> +
> +        function move(el, offsetX, offsetY, timeout) {
> +          return (e) => {

e is usually used in try…catch clauses to mean “error”.  Maybe rename it ‘ev’ or ‘event’?

Comment 5

[Andreas Tolfsen ❲:ato❳]

I forgot to say in the review, that this looks like solid work.

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8859392 [details]
Bug 1357590 - Test drag and drop with mouse actions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131418/diff/1-2/

Comment 7

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8859392 [details]
Bug 1357590 - Test drag and drop with mouse actions;

https://reviewboard.mozilla.org/r/131418/#review134026

> Variable e is never used.  Leave out?

It is used, so dropping this issue.

Comment 8

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2922c563fec4 -d c6798f51e462: rebasing 390664:2922c563fec4 "Bug 1357590 - Add default button to pointer_up and pointer_down; r=ato"
rebasing 390665:043d0479af3f "Bug 1357590 - Test drag and drop with mouse actions; r=ato" (tip)
merging testing/web-platform/meta/MANIFEST.json
warning: conflicts while merging testing/web-platform/meta/MANIFEST.json! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 9

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

(In reply to Andreas Tolfsen ‹:ato› from comment #5)
> I forgot to say in the review, that this looks like solid work.

Thanks, and thanks for the quick review!

Comment 10

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8859391 [details]
Bug 1357590 - Add default button to pointer_up and pointer_down;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131416/diff/1-2/

Comment 11

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8859392 [details]
Bug 1357590 - Test drag and drop with mouse actions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/131418/diff/2-3/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4750ab2b56f2
Add default button to pointer_up and pointer_down; r=ato
https://hg.mozilla.org/integration/autoland/rev/8fd376fc9060
Test drag and drop with mouse actions; r=ato

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4750ab2b56f2
https://hg.mozilla.org/mozilla-central/rev/8fd376fc9060

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e1cde1c33e5
Add default button to pointer_up and pointer_down; r=ato

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2e1cde1c33e5