Closed Bug 1357590 Opened 4 years ago Closed 4 years ago

Test drag and drop with mouse actions

Categories

(Testing :: Marionette, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: impossibus, Assigned: impossibus)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Add wdspec test for drag and drop with pointer actions, pointerType "mouse".
Comment on attachment 8859391 [details]
Bug 1357590 - Add default button to pointer_up and pointer_down;

https://reviewboard.mozilla.org/r/131416/#review134022
Attachment #8859391 - Flags: review?(ato) → review+
Comment on attachment 8859392 [details]
Bug 1357590 - Test drag and drop with mouse actions;

https://reviewboard.mozilla.org/r/131418/#review134026

::: testing/web-platform/tests/webdriver/actions/support/test_actions_wdspec.html:95
(Diff revision 1)
>              allEvents.events.length = 0;
>              displayMessage("");
>          }
>  
> +        function drop(moveHandler) {
> +          return function(e) {

Nit: Space before parenthesis, otherwise it looks like you’re calling a function called "function" with argument "e".

::: testing/web-platform/tests/webdriver/actions/support/test_actions_wdspec.html:95
(Diff revision 1)
>              allEvents.events.length = 0;
>              displayMessage("");
>          }
>  
> +        function drop(moveHandler) {
> +          return function(e) {

Variable e is never used.  Leave out?

::: testing/web-platform/tests/webdriver/actions/support/test_actions_wdspec.html:104
(Diff revision 1)
> +            recordPointerEvent(e);
> +          };
> +        }
> +
> +        function move(el, offsetX, offsetY, timeout) {
> +          return (e) => {

e is usually used in try…catch clauses to mean “error”.  Maybe rename it ‘ev’ or ‘event’?
Attachment #8859392 - Flags: review?(ato) → review+
I forgot to say in the review, that this looks like solid work.
Comment on attachment 8859392 [details]
Bug 1357590 - Test drag and drop with mouse actions;

https://reviewboard.mozilla.org/r/131418/#review134026

> Variable e is never used.  Leave out?

It is used, so dropping this issue.
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2922c563fec4 -d c6798f51e462: rebasing 390664:2922c563fec4 "Bug 1357590 - Add default button to pointer_up and pointer_down; r=ato"
rebasing 390665:043d0479af3f "Bug 1357590 - Test drag and drop with mouse actions; r=ato" (tip)
merging testing/web-platform/meta/MANIFEST.json
warning: conflicts while merging testing/web-platform/meta/MANIFEST.json! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
(In reply to Andreas Tolfsen ‹:ato› from comment #5)
> I forgot to say in the review, that this looks like solid work.

Thanks, and thanks for the quick review!
Pushed by mjzffr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4750ab2b56f2
Add default button to pointer_up and pointer_down; r=ato
https://hg.mozilla.org/integration/autoland/rev/8fd376fc9060
Test drag and drop with mouse actions; r=ato
https://hg.mozilla.org/mozilla-central/rev/4750ab2b56f2
https://hg.mozilla.org/mozilla-central/rev/8fd376fc9060
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e1cde1c33e5
Add default button to pointer_up and pointer_down; r=ato
You need to log in before you can comment on or make changes to this bug.