Closed
Bug 1357633
Opened 8 years ago
Closed 8 years ago
Fennec doesn't request audio focus correctly when user resume media from page, not from media control
Categories
(Firefox for Android Graveyard :: Audio/Video, defect, P1)
Firefox for Android Graveyard
Audio/Video
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(2 files)
Fork from bug1348085 comment6.
---
STR:
1. Load YouTube and play any video;
2. Open the YouTube app and play a video.
3. Open Nightly again and resume video playback.
4. Open the YouTube app and resume the video.
Results:
After the 4th step video playback on Nightly does not pause. Is this to be expected? If yes the issue is fixed then.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Blocks: fennec-media-control-tests
Assignee | ||
Comment 4•8 years ago
|
||
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•8 years ago
|
||
Comment hidden (obsolete) |
Assignee | ||
Comment 9•8 years ago
|
||
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•8 years ago
|
||
mozreview-review |
Comment on attachment 8862355 [details]
Bug 1357633 - part2 : add tests.
https://reviewboard.mozilla.org/r/134282/#review139110
::: mobile/android/tests/browser/robocop/src/org/mozilla/gecko/tests/MediaPlaybackTest.java:238
(Diff revision 3)
> + * Can communicte with JS bey getJS(), but caller should create and destroy
> + * JSBridge manually.
> + */
> + protected JavascriptBridge getJS() {
> + if (mJs == null) {
> + mAsserter.ok(false,
How about "mAsserter.ok(mJs != null)"?
Attachment #8862355 -
Flags: review?(s.kaspari) → review+
Comment 13•8 years ago
|
||
mozreview-review |
Comment on attachment 8861848 [details]
Bug 1357633 - part1 : request audio focus again when resume media from page.
https://reviewboard.mozilla.org/r/133868/#review139634
Attachment #8861848 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 14•8 years ago
|
||
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 17•8 years ago
|
||
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c9d8ee77aca
part1 : request audio focus again when resume media from page. r=baku
https://hg.mozilla.org/integration/autoland/rev/152a4024af04
part2 : add tests. r=sebastian
Comment 18•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1c9d8ee77aca
https://hg.mozilla.org/mozilla-central/rev/152a4024af04
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 19•8 years ago
|
||
Device:
- Nexus 5 (Android 6.0.1);
Build:
- Nightly 55.0a1 (2017-05-17);
Hello,
I've verified this and audio/video playback pauses when the user switches to the YouTube app. But if the user goes and plays a video from the Photos app the playback is not paused.
Based on this I am reopening the issue since the fix only works with the YouTube app and ignores other audio/video apps.
Precondition:
- make sure you have a video saved on your device.
STR:
1. Go to https://goo.gl/odcAeP and play the video;
2. Open the Photos app, find and play your video;
After step 2 the video/audio playback in Fennec should stop.
Updated•8 years ago
|
Priority: -- → P1
Assignee | ||
Comment 20•8 years ago
|
||
It's Photos app's bug, it doesn't request system level audio focus properly. You can try to use other music apps, and they also won't be paused when starting video via Photo apps.
The system audio focus is requested by app, so if the app doesn't implement that, it won't affect any other apps, and vice versa.
---
Please see the following video, you can notice that when video starts playing via Photo app, it doesn't pause the background music from Music app.
https://goo.gl/cLlBl1
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Comment 21•8 years ago
|
||
Hello,
I have tried it with different audio apps and it would seem that the photos app does not properly request audio focus. Thank you Alastor for clearing that up.
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•